* [PATCH] arm64: allowing mmap to be traced
@ 2018-05-14 14:32 Christian Hansen
2018-05-14 14:38 ` Mark Rutland
2018-05-14 15:09 ` Christian Hansen (chansen3)
0 siblings, 2 replies; 3+ messages in thread
From: Christian Hansen @ 2018-05-14 14:32 UTC (permalink / raw)
To: catalin.marinas, linux
Cc: xe-linux-external, linux-arm-kernel, linux-kernel, Christian Hansen
Adding missing macro which is present all other system calls to
to mmap declaration for ARM. This allows it to appear as a kernel
tracing target.
Signed-off-by: Christian Hansen <chansen3@cisco.com>
---
arch/arm64/kernel/sys.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
index 72981ba..1ccdbfc 100644
--- a/arch/arm64/kernel/sys.c
+++ b/arch/arm64/kernel/sys.c
@@ -27,9 +27,9 @@
#include <linux/syscalls.h>
#include <asm/cpufeature.h>
-asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
- unsigned long prot, unsigned long flags,
- unsigned long fd, off_t off)
+SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len,
+ unsigned long, prot, unsigned long, flags,
+ unsigned long, fd, off_t, off)
{
if (offset_in_page(off) != 0)
return -EINVAL;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: allowing mmap to be traced
2018-05-14 14:32 [PATCH] arm64: allowing mmap to be traced Christian Hansen
@ 2018-05-14 14:38 ` Mark Rutland
2018-05-14 15:09 ` Christian Hansen (chansen3)
1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2018-05-14 14:38 UTC (permalink / raw)
To: Christian Hansen
Cc: catalin.marinas, linux, linux-kernel, linux-arm-kernel,
xe-linux-external
On Mon, May 14, 2018 at 02:32:42PM +0000, Christian Hansen wrote:
> Adding missing macro which is present all other system calls to
> to mmap declaration for ARM. This allows it to appear as a kernel
> tracing target.
>
> Signed-off-by: Christian Hansen <chansen3@cisco.com>
FWIW, I sent out a patch doing this earlier today [1], which is
identical modulo some spacing.
Mark.
[1] https://lkml.kernel.org/r/20180514094640.27569-17-mark.rutland@arm.com
> ---
> arch/arm64/kernel/sys.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
> index 72981ba..1ccdbfc 100644
> --- a/arch/arm64/kernel/sys.c
> +++ b/arch/arm64/kernel/sys.c
> @@ -27,9 +27,9 @@
> #include <linux/syscalls.h>
> #include <asm/cpufeature.h>
>
> -asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
> - unsigned long prot, unsigned long flags,
> - unsigned long fd, off_t off)
> +SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len,
> + unsigned long, prot, unsigned long, flags,
> + unsigned long, fd, off_t, off)
> {
> if (offset_in_page(off) != 0)
> return -EINVAL;
> --
> 2.5.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: allowing mmap to be traced
2018-05-14 14:32 [PATCH] arm64: allowing mmap to be traced Christian Hansen
2018-05-14 14:38 ` Mark Rutland
@ 2018-05-14 15:09 ` Christian Hansen (chansen3)
1 sibling, 0 replies; 3+ messages in thread
From: Christian Hansen (chansen3) @ 2018-05-14 15:09 UTC (permalink / raw)
To: catalin.marinas, linux, will.deacon
Cc: xe-linux-external(mailer list), linux-arm-kernel, linux-kernel
Indeed, you have the quicker draw. I concede to your patch.
On 2018-05-14, 10:32 AM, "Christian Hansen (chansen3)" <chansen3@cisco.com> wrote:
Adding missing macro which is present all other system calls to
to mmap declaration for ARM. This allows it to appear as a kernel
tracing target.
Signed-off-by: Christian Hansen <chansen3@cisco.com>
---
arch/arm64/kernel/sys.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/kernel/sys.c b/arch/arm64/kernel/sys.c
index 72981ba..1ccdbfc 100644
--- a/arch/arm64/kernel/sys.c
+++ b/arch/arm64/kernel/sys.c
@@ -27,9 +27,9 @@
#include <linux/syscalls.h>
#include <asm/cpufeature.h>
-asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
- unsigned long prot, unsigned long flags,
- unsigned long fd, off_t off)
+SYSCALL_DEFINE6(mmap, unsigned long, addr, unsigned long, len,
+ unsigned long, prot, unsigned long, flags,
+ unsigned long, fd, off_t, off)
{
if (offset_in_page(off) != 0)
return -EINVAL;
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-14 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 14:32 [PATCH] arm64: allowing mmap to be traced Christian Hansen
2018-05-14 14:38 ` Mark Rutland
2018-05-14 15:09 ` Christian Hansen (chansen3)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).