From: Rajendra Nayak <rnayak@codeaurora.org>
To: ulf.hansson@linaro.org, robh+dt@kernel.org,
bjorn.andersson@linaro.org, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, rojay@codeaurora.org,
Rajendra Nayak <rnayak@codeaurora.org>
Subject: [PATCH v2 2/3] PM / Domains: Add support for 'assigned-performance-states'
Date: Thu, 27 May 2021 11:42:28 +0530 [thread overview]
Message-ID: <1622095949-2014-3-git-send-email-rnayak@codeaurora.org> (raw)
In-Reply-To: <1622095949-2014-1-git-send-email-rnayak@codeaurora.org>
For devices which have 'assigned-performance-states' specified in DT,
set the specified performance state during attach and drop it on detach.
Also drop/set as part of runtime suspend/resume callbacks.
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
drivers/base/power/domain.c | 27 +++++++++++++++++++++++++++
include/linux/pm_domain.h | 1 +
2 files changed, 28 insertions(+)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index b6a782c..145ce12 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -888,6 +888,10 @@ static int genpd_runtime_suspend(struct device *dev)
if (irq_safe_dev_in_no_sleep_domain(dev, genpd))
return 0;
+ /* Drop the assigned performance state */
+ if (dev_gpd_data(dev)->assigned_pstate)
+ dev_pm_genpd_set_performance_state(dev, 0);
+
genpd_lock(genpd);
genpd_power_off(genpd, true, 0);
genpd_unlock(genpd);
@@ -907,6 +911,7 @@ static int genpd_runtime_resume(struct device *dev)
{
struct generic_pm_domain *genpd;
struct gpd_timing_data *td = &dev_gpd_data(dev)->td;
+ unsigned int assigned_pstate = dev_gpd_data(dev)->assigned_pstate;
bool runtime_pm = pm_runtime_enabled(dev);
ktime_t time_start;
s64 elapsed_ns;
@@ -935,6 +940,9 @@ static int genpd_runtime_resume(struct device *dev)
if (ret)
return ret;
+ /* Set the assigned performance state */
+ if (assigned_pstate)
+ dev_pm_genpd_set_performance_state(dev, assigned_pstate);
out:
/* Measure resume latency. */
time_start = 0;
@@ -967,6 +975,8 @@ static int genpd_runtime_resume(struct device *dev)
genpd_stop_dev(genpd, dev);
err_poweroff:
if (!pm_runtime_is_irq_safe(dev) || genpd_is_irq_safe(genpd)) {
+ if (assigned_pstate)
+ dev_pm_genpd_set_performance_state(dev, 0);
genpd_lock(genpd);
genpd_power_off(genpd, true, 0);
genpd_unlock(genpd);
@@ -2568,6 +2578,12 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off)
dev_dbg(dev, "removing from PM domain %s\n", pd->name);
+ /* Drop the assigned performance state */
+ if (dev_gpd_data(dev)->assigned_pstate) {
+ dev_pm_genpd_set_performance_state(dev, 0);
+ dev_gpd_data(dev)->assigned_pstate = 0;
+ }
+
for (i = 1; i < GENPD_RETRY_MAX_MS; i <<= 1) {
ret = genpd_remove_device(pd, dev);
if (ret != -EAGAIN)
@@ -2605,6 +2621,7 @@ static void genpd_dev_pm_sync(struct device *dev)
static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
unsigned int index, bool power_on)
{
+ unsigned int assigned_pstate;
struct of_phandle_args pd_args;
struct generic_pm_domain *pd;
int ret;
@@ -2648,6 +2665,16 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
if (ret)
genpd_remove_device(pd, dev);
+ /* Set the assigned performance state */
+ if (!of_property_read_u32_index(base_dev->of_node,
+ "assigned-performance-states",
+ index, &assigned_pstate)) {
+ if (assigned_pstate) {
+ dev_pm_genpd_set_performance_state(dev, assigned_pstate);
+ dev_gpd_data(dev)->assigned_pstate = assigned_pstate;
+ }
+ }
+
return ret ? -EPROBE_DEFER : 1;
}
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index dfcfbce..71c1b11 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -198,6 +198,7 @@ struct generic_pm_domain_data {
struct notifier_block *power_nb;
int cpu;
unsigned int performance_state;
+ unsigned int assigned_pstate;
ktime_t next_wakeup;
void *data;
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-05-27 6:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 6:12 [PATCH v2 0/3] PM / Domains: Add support for assigned-performance-states Rajendra Nayak
2021-05-27 6:12 ` [PATCH v2 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property Rajendra Nayak
2021-05-27 6:16 ` Viresh Kumar
2021-05-27 6:21 ` Rajendra Nayak
2021-05-27 14:23 ` Rob Herring
2021-05-27 14:26 ` Rob Herring
2021-06-01 10:33 ` Ulf Hansson
2021-06-01 11:12 ` Stephan Gerhold
2021-06-01 11:44 ` Viresh Kumar
2021-06-02 10:45 ` Ulf Hansson
2021-06-02 10:54 ` Viresh Kumar
2021-06-02 12:50 ` Ulf Hansson
2021-06-15 15:05 ` Ulf Hansson
2021-06-18 6:01 ` Rajendra Nayak
2021-05-27 6:12 ` Rajendra Nayak [this message]
2021-05-27 6:12 ` [PATCH v2 3/3] arm64: dts: sc7180: Add assigned-performance-states for i2c Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622095949-2014-3-git-send-email-rnayak@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).