From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Rajendra Nayak <rnayak@codeaurora.org>,
ulf.hansson@linaro.org, robh+dt@kernel.org,
bjorn.andersson@linaro.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, swboyd@chromium.org,
rojay@codeaurora.org
Subject: Re: [PATCH v2 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property
Date: Tue, 1 Jun 2021 17:14:26 +0530 [thread overview]
Message-ID: <20210601114426.3vhh2twocqx254b6@vireshk-i7> (raw)
In-Reply-To: <YLYV3ov/iBffZMg4@gerhold.net>
On 01-06-21, 13:12, Stephan Gerhold wrote:
> > + child4: consumer@12341000 {
> > + compatible = "foo,consumer";
> > + reg = <0x12341000 0x1000>;
> > + power-domains = <&parent4>, <&parent5>;
> > + assigned-performance-states = <0>, <256>;
> > + };
>
> Bjorn already asked this in v1 [1]:
>
> > May I ask how this is different from saying something like:
> >
> > required-opps = <&??>, <&rpmpd_opp_svs>;
>
> and maybe this was already discussed further elsewhere. But I think at
> the very least we need some clarification in the commit message + the
> binding documentation how your new property relates to the existing
> "required-opps" binding.
>
> Because even if it might not be implemented at the moment,
> Documentation/devicetree/bindings/power/power_domain.txt actually also
> specifies "required-opps" for device nodes e.g. with the following example:
>
> leaky-device0@12350000 {
> compatible = "foo,i-leak-current";
> reg = <0x12350000 0x1000>;
> power-domains = <&power 0>;
> required-opps = <&domain0_opp_0>;
> };
>
> It looks like Viresh added that in commit e856f078bcf1
> ("OPP: Introduce "required-opp" property").
>
> And in general I think it's a bit inconsistent that we usually refer to
> performance states with phandles into the OPP table, but the
> assigned-performance-states suddenly use "raw numbers".
I must have missed that discussion, sorry about that.
The required-opps property, when present in device's node directly, is about the
(default) OPPs to choose for that device's normal functioning as they may not do
DVFS.
Good point Stephan.
--
viresh
next prev parent reply other threads:[~2021-06-01 11:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 6:12 [PATCH v2 0/3] PM / Domains: Add support for assigned-performance-states Rajendra Nayak
2021-05-27 6:12 ` [PATCH v2 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property Rajendra Nayak
2021-05-27 6:16 ` Viresh Kumar
2021-05-27 6:21 ` Rajendra Nayak
2021-05-27 14:23 ` Rob Herring
2021-05-27 14:26 ` Rob Herring
2021-06-01 10:33 ` Ulf Hansson
2021-06-01 11:12 ` Stephan Gerhold
2021-06-01 11:44 ` Viresh Kumar [this message]
2021-06-02 10:45 ` Ulf Hansson
2021-06-02 10:54 ` Viresh Kumar
2021-06-02 12:50 ` Ulf Hansson
2021-06-15 15:05 ` Ulf Hansson
2021-06-18 6:01 ` Rajendra Nayak
2021-05-27 6:12 ` [PATCH v2 2/3] PM / Domains: Add support for 'assigned-performance-states' Rajendra Nayak
2021-05-27 6:12 ` [PATCH v2 3/3] arm64: dts: sc7180: Add assigned-performance-states for i2c Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601114426.3vhh2twocqx254b6@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).