From: Stephen Boyd <sboyd@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
mturquette@baylibre.com, linux-clk@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, khilman@baylibre.com,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] clk: divider: Switch from .round_rate to .determine_rate by default
Date: Fri, 02 Jul 2021 14:00:53 -0700 [thread overview]
Message-ID: <162525965307.3570193.9588997729905273358@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <e21c34a3-2586-057d-013b-6c8ec094d1a8@samsung.com>
Quoting Marek Szyprowski (2021-07-02 05:46:11)
> Hi
>
> On 02.07.2021 11:19, Martin Blumenstingl wrote:
> > Hi Stephen,
> >
> > On Fri, Jul 2, 2021 at 3:02 AM Stephen Boyd <sboyd@kernel.org> wrote:
> > [...]
> >> My guess is that we have drivers copying the clk_ops from the
> >> divider_ops structure and so they are copying over round_rate but not
> >> determine_rate.
> > I just learned something new - thanks for investigating this as well!
> >
> > $ git grep "clk_divider_ops\.round_rate" drivers/
> > drivers/clk/bcm/clk-bcm2835.c: return clk_divider_ops.round_rate(hw,
> > rate, parent_rate);
>
> I confirm that this issue appears also on Raspberry Pi 3b+ board. I was
> about to write a bug report, but you were faster. The funny thing is
> that is so nondeterministic, that automated bisecting failed to catch it.
>
I'd think it was deterministic. The function pointer is NULL after this
patch so it should always try to set the PC to 0 and fail to execute.
Unless that is somehow executable?
next prev parent reply other threads:[~2021-07-02 21:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 22:39 [PATCH v3 0/3] clk: meson: rounding for fast clocks on 32-bit SoCs Martin Blumenstingl
2021-06-27 22:39 ` [PATCH v3 1/3] clk: divider: Add re-usable determine_rate implementations Martin Blumenstingl
2021-06-30 18:39 ` Stephen Boyd
2021-06-27 22:39 ` [PATCH v3 2/3] clk: divider: Switch from .round_rate to .determine_rate by default Martin Blumenstingl
2021-06-30 18:39 ` Stephen Boyd
2021-07-01 20:25 ` Guenter Roeck
2021-07-01 20:57 ` Martin Blumenstingl
2021-07-01 21:43 ` Guenter Roeck
2021-07-02 0:53 ` Stephen Boyd
2021-07-02 1:02 ` Stephen Boyd
2021-07-02 9:19 ` Martin Blumenstingl
[not found] ` <CGME20210702124612eucas1p1762911deb37e4fb03adc9239bb715135@eucas1p1.samsung.com>
2021-07-02 12:46 ` Marek Szyprowski
2021-07-02 21:00 ` Stephen Boyd [this message]
2021-07-02 20:59 ` Stephen Boyd
2021-07-02 22:57 ` Martin Blumenstingl
2021-07-02 1:04 ` Stephen Boyd
2021-06-27 22:39 ` [PATCH v3 3/3] clk: meson: regmap: switch to determine_rate for the dividers Martin Blumenstingl
2021-06-30 18:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162525965307.3570193.9588997729905273358@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.szyprowski@samsung.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).