From: Kalle Valo <kvalo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [RESEND PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant
Date: Sun, 10 Apr 2022 12:20:54 +0000 (UTC) [thread overview]
Message-ID: <164959325197.9942.3706539176103286377.kvalo@kernel.org> (raw)
In-Reply-To: <Ykx0iRlvtBnKqtbG@zn.tnic>
Borislav Petkov <bp@alien8.de> wrote:
> Fix:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant
> case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17):
> ^~~~
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant
> case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13):
> ^~~~
>
> See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
> details as to why it triggers with older gccs only.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Arend van Spriel <aspriel@gmail.com>
> Cc: Franky Lin <franky.lin@broadcom.com>
> Cc: Hante Meuleman <hante.meuleman@broadcom.com>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: brcm80211-dev-list.pdl@broadcom.com
> Cc: netdev@vger.kernel.org
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless.git, thanks.
6fb3a5868b21 brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant
--
https://patchwork.kernel.org/project/linux-wireless/patch/Ykx0iRlvtBnKqtbG@zn.tnic/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-04-10 12:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 15:15 [PATCH 00/11] treewide: Fix a bunch of shift overflows Borislav Petkov
2022-04-05 15:15 ` [PATCH 01/11] scsi: aacraid: Fix undefined behavior due to shift overflowing the constant Borislav Petkov
2022-04-25 18:47 ` Randy Dunlap
2022-04-26 3:05 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
2022-04-05 15:15 ` [PATCH 02/11] ALSA: usb-audio: " Borislav Petkov
2022-04-05 15:32 ` Takashi Iwai
2022-04-05 16:06 ` Borislav Petkov
2022-04-05 16:16 ` Takashi Iwai
2022-04-05 15:15 ` [PATCH 03/11] bnx2x: " Borislav Petkov
2022-04-05 19:53 ` Jakub Kicinski
2022-04-05 19:59 ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 04/11] drm/r128: " Borislav Petkov
2022-04-25 18:46 ` Randy Dunlap
2022-05-19 13:05 ` Daniel Vetter
2022-06-16 16:06 ` Randy Dunlap
2022-06-24 20:13 ` Daniel Vetter
2022-04-05 15:15 ` [PATCH 05/11] i2c: ismt: " Borislav Petkov
2022-04-05 21:18 ` Seth Heasley
2022-04-05 15:15 ` [PATCH 06/11] brcmfmac: sdio: " Borislav Petkov
2022-04-05 15:25 ` Kalle Valo
2022-04-05 16:06 ` Borislav Petkov
2022-04-05 16:37 ` Kalle Valo
2022-04-05 16:55 ` [RESEND PATCH " Borislav Petkov
2022-04-05 19:11 ` Arend van Spriel
2022-04-10 12:20 ` Kalle Valo [this message]
2022-04-05 15:15 ` [PATCH 07/11] usb: typec: tcpm: " Borislav Petkov
2022-04-05 15:15 ` [PATCH 08/11] mt76: " Borislav Petkov
2022-04-06 5:43 ` Kalle Valo
2022-04-10 12:20 ` Kalle Valo
2022-04-05 15:15 ` [PATCH 09/11] perf/imx_ddr: " Borislav Petkov
2022-04-08 10:47 ` Will Deacon
2022-04-08 11:01 ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 10/11] IB/mlx5: " Borislav Petkov
2022-04-05 18:31 ` Leon Romanovsky
2022-04-05 19:42 ` Borislav Petkov
2022-04-06 7:17 ` Leon Romanovsky
2022-04-05 15:15 ` [PATCH 11/11] drm/i915: " Borislav Petkov
2022-05-17 23:05 ` Randy Dunlap
2022-05-18 7:44 ` Borislav Petkov
2022-05-18 11:39 ` Jani Nikula
2022-04-06 9:23 ` [PATCH 00/11] treewide: Fix a bunch of shift overflows David Laight
2022-04-08 13:58 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164959325197.9942.3706539176103286377.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=aspriel@gmail.com \
--cc=bp@alien8.de \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).