From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frank Li <Frank.li@nxp.com>, Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/11] perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant
Date: Tue, 5 Apr 2022 17:15:15 +0200 [thread overview]
Message-ID: <20220405151517.29753-10-bp@alien8.de> (raw)
In-Reply-To: <20220405151517.29753-1-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
Fix:
In file included from <command-line>:0:0:
In function ‘ddr_perf_counter_enable’,
inlined from ‘ddr_perf_irq_handler’ at drivers/perf/fsl_imx8_ddr_perf.c:651:2:
././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_729’ \
declared with attribute error: FIELD_PREP: mask is not constant
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
...
See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Frank Li <Frank.li@nxp.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/perf/fsl_imx8_ddr_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
index 94ebc1ecace7..b1b2a55de77f 100644
--- a/drivers/perf/fsl_imx8_ddr_perf.c
+++ b/drivers/perf/fsl_imx8_ddr_perf.c
@@ -29,7 +29,7 @@
#define CNTL_OVER_MASK 0xFFFFFFFE
#define CNTL_CSV_SHIFT 24
-#define CNTL_CSV_MASK (0xFF << CNTL_CSV_SHIFT)
+#define CNTL_CSV_MASK (0xFFU << CNTL_CSV_SHIFT)
#define EVENT_CYCLES_ID 0
#define EVENT_CYCLES_COUNTER 0
--
2.35.1
next prev parent reply other threads:[~2022-04-05 20:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 15:15 [PATCH 00/11] treewide: Fix a bunch of shift overflows Borislav Petkov
2022-04-05 15:15 ` [PATCH 01/11] scsi: aacraid: Fix undefined behavior due to shift overflowing the constant Borislav Petkov
2022-04-25 18:47 ` Randy Dunlap
2022-04-26 3:05 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
2022-04-05 15:15 ` [PATCH 02/11] ALSA: usb-audio: " Borislav Petkov
2022-04-05 15:32 ` Takashi Iwai
2022-04-05 16:06 ` Borislav Petkov
2022-04-05 16:16 ` Takashi Iwai
2022-04-05 15:15 ` [PATCH 03/11] bnx2x: " Borislav Petkov
2022-04-05 19:53 ` Jakub Kicinski
2022-04-05 19:59 ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 04/11] drm/r128: " Borislav Petkov
2022-04-25 18:46 ` Randy Dunlap
2022-05-19 13:05 ` Daniel Vetter
2022-06-16 16:06 ` Randy Dunlap
2022-06-24 20:13 ` Daniel Vetter
2022-04-05 15:15 ` [PATCH 05/11] i2c: ismt: " Borislav Petkov
2022-04-05 21:18 ` Seth Heasley
2022-04-05 15:15 ` [PATCH 06/11] brcmfmac: sdio: " Borislav Petkov
2022-04-05 15:25 ` Kalle Valo
2022-04-05 16:06 ` Borislav Petkov
2022-04-05 16:37 ` Kalle Valo
2022-04-05 16:55 ` [RESEND PATCH " Borislav Petkov
2022-04-05 19:11 ` Arend van Spriel
2022-04-10 12:20 ` Kalle Valo
2022-04-05 15:15 ` [PATCH 07/11] usb: typec: tcpm: " Borislav Petkov
2022-04-05 15:15 ` [PATCH 08/11] mt76: " Borislav Petkov
2022-04-06 5:43 ` Kalle Valo
2022-04-10 12:20 ` Kalle Valo
2022-04-05 15:15 ` Borislav Petkov [this message]
2022-04-08 10:47 ` [PATCH 09/11] perf/imx_ddr: " Will Deacon
2022-04-08 11:01 ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 10/11] IB/mlx5: " Borislav Petkov
2022-04-05 18:31 ` Leon Romanovsky
2022-04-05 19:42 ` Borislav Petkov
2022-04-06 7:17 ` Leon Romanovsky
2022-04-05 15:15 ` [PATCH 11/11] drm/i915: " Borislav Petkov
2022-05-17 23:05 ` Randy Dunlap
2022-05-18 7:44 ` Borislav Petkov
2022-05-18 11:39 ` Jani Nikula
2022-04-06 9:23 ` [PATCH 00/11] treewide: Fix a bunch of shift overflows David Laight
2022-04-08 13:58 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405151517.29753-10-bp@alien8.de \
--to=bp@alien8.de \
--cc=Frank.li@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).