From: Borislav Petkov <bp@alien8.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 02/11] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant
Date: Tue, 5 Apr 2022 18:06:19 +0200 [thread overview]
Message-ID: <Ykxo+0p5IeeM7mge@zn.tnic> (raw)
In-Reply-To: <s5hwng35yvz.wl-tiwai@suse.de>
On Tue, Apr 05, 2022 at 05:32:48PM +0200, Takashi Iwai wrote:
> > +#define USB_ID(vendor, product) ((((unsigned int)vendor) << 16) | (product))
>
> Parentheses are needed around vendor (as usual for a macro).
> Could you resubmit with it?
Or you can fix it up while applying. :)
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-04-06 0:09 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 15:15 [PATCH 00/11] treewide: Fix a bunch of shift overflows Borislav Petkov
2022-04-05 15:15 ` [PATCH 01/11] scsi: aacraid: Fix undefined behavior due to shift overflowing the constant Borislav Petkov
2022-04-25 18:47 ` Randy Dunlap
2022-04-26 3:05 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
2022-04-05 15:15 ` [PATCH 02/11] ALSA: usb-audio: " Borislav Petkov
2022-04-05 15:32 ` Takashi Iwai
2022-04-05 16:06 ` Borislav Petkov [this message]
2022-04-05 16:16 ` Takashi Iwai
2022-04-05 15:15 ` [PATCH 03/11] bnx2x: " Borislav Petkov
2022-04-05 19:53 ` Jakub Kicinski
2022-04-05 19:59 ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 04/11] drm/r128: " Borislav Petkov
2022-04-25 18:46 ` Randy Dunlap
2022-05-19 13:05 ` Daniel Vetter
2022-06-16 16:06 ` Randy Dunlap
2022-06-24 20:13 ` Daniel Vetter
2022-04-05 15:15 ` [PATCH 05/11] i2c: ismt: " Borislav Petkov
2022-04-05 21:18 ` Seth Heasley
2022-04-05 15:15 ` [PATCH 06/11] brcmfmac: sdio: " Borislav Petkov
2022-04-05 15:25 ` Kalle Valo
2022-04-05 16:06 ` Borislav Petkov
2022-04-05 16:37 ` Kalle Valo
2022-04-05 16:55 ` [RESEND PATCH " Borislav Petkov
2022-04-05 19:11 ` Arend van Spriel
2022-04-10 12:20 ` Kalle Valo
2022-04-05 15:15 ` [PATCH 07/11] usb: typec: tcpm: " Borislav Petkov
2022-04-05 15:15 ` [PATCH 08/11] mt76: " Borislav Petkov
2022-04-06 5:43 ` Kalle Valo
2022-04-10 12:20 ` Kalle Valo
2022-04-05 15:15 ` [PATCH 09/11] perf/imx_ddr: " Borislav Petkov
2022-04-08 10:47 ` Will Deacon
2022-04-08 11:01 ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 10/11] IB/mlx5: " Borislav Petkov
2022-04-05 18:31 ` Leon Romanovsky
2022-04-05 19:42 ` Borislav Petkov
2022-04-06 7:17 ` Leon Romanovsky
2022-04-05 15:15 ` [PATCH 11/11] drm/i915: " Borislav Petkov
2022-05-17 23:05 ` Randy Dunlap
2022-05-18 7:44 ` Borislav Petkov
2022-05-18 11:39 ` Jani Nikula
2022-04-06 9:23 ` [PATCH 00/11] treewide: Fix a bunch of shift overflows David Laight
2022-04-08 13:58 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykxo+0p5IeeM7mge@zn.tnic \
--to=bp@alien8.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).