linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ariel Elior <aelior@marvell.com>,
	Sudarsana Kalluru <skalluru@marvell.com>,
	Manish Chopra <manishc@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org
Subject: [PATCH 03/11] bnx2x: Fix undefined behavior due to shift overflowing the constant
Date: Tue,  5 Apr 2022 17:15:09 +0200	[thread overview]
Message-ID: <20220405151517.29753-4-bp@alien8.de> (raw)
In-Reply-To: <20220405151517.29753-1-bp@alien8.de>

From: Borislav Petkov <bp@suse.de>

Fix:

  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function ‘bnx2x_check_blocks_with_parity3’:
  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:4917:4: error: case label does not reduce to an integer constant
      case AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY:
      ^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Ariel Elior <aelior@marvell.com>
Cc: Sudarsana Kalluru <skalluru@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h
index 5caa75b41b73..881ac33fe914 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h
@@ -6218,7 +6218,7 @@
 #define AEU_INPUTS_ATTN_BITS_GPIO0_FUNCTION_0			 (0x1<<2)
 #define AEU_INPUTS_ATTN_BITS_IGU_PARITY_ERROR			 (0x1<<12)
 #define AEU_INPUTS_ATTN_BITS_MCP_LATCHED_ROM_PARITY		 (0x1<<28)
-#define AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY		 (0x1<<31)
+#define AEU_INPUTS_ATTN_BITS_MCP_LATCHED_SCPAD_PARITY		 (0x1U<<31)
 #define AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_RX_PARITY		 (0x1<<29)
 #define AEU_INPUTS_ATTN_BITS_MCP_LATCHED_UMP_TX_PARITY		 (0x1<<30)
 #define AEU_INPUTS_ATTN_BITS_MISC_HW_INTERRUPT			 (0x1<<15)
-- 
2.35.1


  parent reply	other threads:[~2022-04-05 23:26 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 15:15 [PATCH 00/11] treewide: Fix a bunch of shift overflows Borislav Petkov
2022-04-05 15:15 ` [PATCH 01/11] scsi: aacraid: Fix undefined behavior due to shift overflowing the constant Borislav Petkov
2022-04-25 18:47   ` Randy Dunlap
2022-04-26  3:05   ` Martin K. Petersen
2022-05-03  0:51   ` Martin K. Petersen
2022-04-05 15:15 ` [PATCH 02/11] ALSA: usb-audio: " Borislav Petkov
2022-04-05 15:32   ` Takashi Iwai
2022-04-05 16:06     ` Borislav Petkov
2022-04-05 16:16       ` Takashi Iwai
2022-04-05 15:15 ` Borislav Petkov [this message]
2022-04-05 19:53   ` [PATCH 03/11] bnx2x: " Jakub Kicinski
2022-04-05 19:59     ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 04/11] drm/r128: " Borislav Petkov
2022-04-25 18:46   ` Randy Dunlap
2022-05-19 13:05     ` Daniel Vetter
2022-06-16 16:06       ` Randy Dunlap
2022-06-24 20:13         ` Daniel Vetter
2022-04-05 15:15 ` [PATCH 05/11] i2c: ismt: " Borislav Petkov
2022-04-05 21:18   ` Seth Heasley
2022-04-05 15:15 ` [PATCH 06/11] brcmfmac: sdio: " Borislav Petkov
2022-04-05 15:25   ` Kalle Valo
2022-04-05 16:06     ` Borislav Petkov
2022-04-05 16:37       ` Kalle Valo
2022-04-05 16:55         ` [RESEND PATCH " Borislav Petkov
2022-04-05 19:11           ` Arend van Spriel
2022-04-10 12:20           ` Kalle Valo
2022-04-05 15:15 ` [PATCH 07/11] usb: typec: tcpm: " Borislav Petkov
2022-04-05 15:15 ` [PATCH 08/11] mt76: " Borislav Petkov
2022-04-06  5:43   ` Kalle Valo
2022-04-10 12:20   ` Kalle Valo
2022-04-05 15:15 ` [PATCH 09/11] perf/imx_ddr: " Borislav Petkov
2022-04-08 10:47   ` Will Deacon
2022-04-08 11:01     ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 10/11] IB/mlx5: " Borislav Petkov
2022-04-05 18:31   ` Leon Romanovsky
2022-04-05 19:42     ` Borislav Petkov
2022-04-06  7:17   ` Leon Romanovsky
2022-04-05 15:15 ` [PATCH 11/11] drm/i915: " Borislav Petkov
2022-05-17 23:05   ` Randy Dunlap
2022-05-18  7:44     ` Borislav Petkov
2022-05-18 11:39       ` Jani Nikula
2022-04-06  9:23 ` [PATCH 00/11] treewide: Fix a bunch of shift overflows David Laight
2022-04-08 13:58 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405151517.29753-4-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=skalluru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).