RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[Song Bao Hua (Barry Song)]

> -----Original Message-----
> From: liwei (CM)
> Sent: Wednesday, July 8, 2020 1:56 PM
> To: catalin.marinas@arm.com; will@kernel.org
> Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng
> <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de;
> steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song)
> <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
> Subject: [PATCH] arm64: mm: free unused memmap for sparse memory model
> that define VMEMMAP
> 
> For the memory hole, sparse memory model that define
> SPARSEMEM_VMEMMAP do not free the reserved memory for the page map,
> this patch do it.

Hello Wei,
Just curious if this patch breaks MEMORY_HOTPLUG?

> 
> Signed-off-by: Wei Li <liwei213@huawei.com>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> ---
>  arch/arm64/mm/init.c | 81
> +++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 71 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index
> 1e93cfc7c47a..d1b56b47d5ba 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -441,7 +441,48 @@ void __init bootmem_init(void)
>  	memblock_dump_all();
>  }
> 

Thanks
Barry

答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[liwei (CM)]

Hi, baohua

Thank you for your attention.

In my understanding of the MEMORY_HOTPLUG this patch has no effect on it. The reason is that in sparse_add_one_section() the memory that memmap needs from Slab if kernel start completed，this memory has nothing to do with memblock alloc/ free memory in the process of kernel start.

You may have a look vmemmap_alloc_block () this function.

If I don't understand right welcome pointed out in a timely manner.

Thanks!


-----邮件原件-----
发件人: Song Bao Hua (Barry Song) 
发送时间: 2020年7月8日 15:19
收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org
抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP



> -----Original Message-----
> From: liwei (CM)
> Sent: Wednesday, July 8, 2020 1:56 PM
> To: catalin.marinas@arm.com; will@kernel.org
> Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng 
> <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) 
> <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
> Subject: [PATCH] arm64: mm: free unused memmap for sparse memory model 
> that define VMEMMAP
> 
> For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP 
> do not free the reserved memory for the page map, this patch do it.

Hello Wei,
Just curious if this patch breaks MEMORY_HOTPLUG?

> 
> Signed-off-by: Wei Li <liwei213@huawei.com>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> ---
>  arch/arm64/mm/init.c | 81
> +++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 71 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 
> 1e93cfc7c47a..d1b56b47d5ba 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -441,7 +441,48 @@ void __init bootmem_init(void)
>  	memblock_dump_all();
>  }
> 

Thanks
Barry

RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[Song Bao Hua (Barry Song)]

> -----Original Message-----
> From: liwei (CM)
> Sent: Wednesday, July 8, 2020 7:52 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>;
> catalin.marinas@arm.com; will@kernel.org
> Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de;
> steve.capper@arm.com; rppt@linux.ibm.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei
> <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>;
> Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com>
> Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory
> model that define VMEMMAP
> 
> Hi, baohua
> 
> Thank you for your attention.
> 
> In my understanding of the MEMORY_HOTPLUG this patch has no effect on it.
> The reason is that in sparse_add_one_section() the memory that memmap
> needs from Slab if kernel start completed，this memory has nothing to do with
> memblock alloc/ free memory in the process of kernel start.
> 
> You may have a look vmemmap_alloc_block () this function.
> 
> If I don't understand right welcome pointed out in a timely manner.

At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory.
If you confirm this won't happen, please ignore my noise.

BTW, next time, bear in mind that top-post is not a good way to reply mail :-)

> 
> Thanks!
> 
> 
> -----邮件原件-----
> 发件人: Song Bao Hua (Barry Song)
> 发送时间: 2020年7月8日 15:19
> 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com;
> will@kernel.org
> 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de;
> steve.capper@arm.com; rppt@linux.ibm.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei
> <sujunfei2@hisilicon.com>
> 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory
> model that define VMEMMAP
> 
> 
> 
> > -----Original Message-----
> > From: liwei (CM)
> > Sent: Wednesday, July 8, 2020 1:56 PM
> > To: catalin.marinas@arm.com; will@kernel.org
> > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng
> > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de;
> > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song)
> > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
> > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory
> model
> > that define VMEMMAP
> >
> > For the memory hole, sparse memory model that define
> SPARSEMEM_VMEMMAP
> > do not free the reserved memory for the page map, this patch do it.
> 
> Hello Wei,
> Just curious if this patch breaks MEMORY_HOTPLUG?
> 
> >
> > Signed-off-by: Wei Li <liwei213@huawei.com>
> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> > ---
> >  arch/arm64/mm/init.c | 81
> > +++++++++++++++++++++++++++++++++++++++++++++-------
> >  1 file changed, 71 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index
> > 1e93cfc7c47a..d1b56b47d5ba 100644
> > --- a/arch/arm64/mm/init.c
> > +++ b/arch/arm64/mm/init.c
> > @@ -441,7 +441,48 @@ void __init bootmem_init(void)
> >  	memblock_dump_all();
> >  }
> >
> 
> Thanks
> Barry

答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[liwei (CM)]

Hi, all

I'm sorry to bother you, but still very hope you can give comments or suggestions to this patch, thank you very much.


-----邮件原件-----
发件人: Song Bao Hua (Barry Song) 
发送时间: 2020年7月9日 20:27
收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org
抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com>
主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP



> -----Original Message-----
> From: liwei (CM)
> Sent: Wednesday, July 8, 2020 7:52 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; 
> catalin.marinas@arm.com; will@kernel.org
> Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> steve.capper@arm.com; rppt@linux.ibm.com; 
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 
> sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) 
> <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) 
> <yaobaofeng@huawei.com>
> Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory 
> model that define VMEMMAP
> 
> Hi, baohua
> 
> Thank you for your attention.
> 
> In my understanding of the MEMORY_HOTPLUG this patch has no effect on it.
> The reason is that in sparse_add_one_section() the memory that memmap 
> needs from Slab if kernel start completed，this memory has nothing to 
> do with memblock alloc/ free memory in the process of kernel start.
> 
> You may have a look vmemmap_alloc_block () this function.
> 
> If I don't understand right welcome pointed out in a timely manner.

At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory.
If you confirm this won't happen, please ignore my noise.

BTW, next time, bear in mind that top-post is not a good way to reply mail :-)

> 
> Thanks!
> 
> 
> -----邮件原件-----
> 发件人: Song Bao Hua (Barry Song)
> 发送时间: 2020年7月8日 15:19
> 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; 
> will@kernel.org
> 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> steve.capper@arm.com; rppt@linux.ibm.com; 
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 
> sujunfei <sujunfei2@hisilicon.com>
> 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model 
> that define VMEMMAP
> 
> 
> 
> > -----Original Message-----
> > From: liwei (CM)
> > Sent: Wednesday, July 8, 2020 1:56 PM
> > To: catalin.marinas@arm.com; will@kernel.org
> > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng 
> > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) 
> > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
> > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory
> model
> > that define VMEMMAP
> >
> > For the memory hole, sparse memory model that define
> SPARSEMEM_VMEMMAP
> > do not free the reserved memory for the page map, this patch do it.
> 
> Hello Wei,
> Just curious if this patch breaks MEMORY_HOTPLUG?
> 
> >
> > Signed-off-by: Wei Li <liwei213@huawei.com>
> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> > ---
> >  arch/arm64/mm/init.c | 81
> > +++++++++++++++++++++++++++++++++++++++++++++-------
> >  1 file changed, 71 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 
> > 1e93cfc7c47a..d1b56b47d5ba 100644
> > --- a/arch/arm64/mm/init.c
> > +++ b/arch/arm64/mm/init.c
> > @@ -441,7 +441,48 @@ void __init bootmem_init(void)
> >  	memblock_dump_all();
> >  }
> >
> 
> Thanks
> Barry

Re: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[Mike Rapoport]

Hi,

On Tue, Jul 21, 2020 at 01:56:33AM +0000, liwei (CM) wrote:
> Hi, all
> 
> I'm sorry to bother you, but still very hope you can give comments or suggestions to this patch, thank you very much.
 
I cannot find your patch neither in Inbox nor in the public archives.
Can you resend it please?


> -----邮件原件-----
> 发件人: Song Bao Hua (Barry Song) 
> 发送时间: 2020年7月9日 20:27
> 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org
> 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com>
> 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP
> 
> 
> 
> > -----Original Message-----
> > From: liwei (CM)
> > Sent: Wednesday, July 8, 2020 7:52 PM
> > To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; 
> > catalin.marinas@arm.com; will@kernel.org
> > Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> > steve.capper@arm.com; rppt@linux.ibm.com; 
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 
> > sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) 
> > <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) 
> > <yaobaofeng@huawei.com>
> > Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory 
> > model that define VMEMMAP
> > 
> > Hi, baohua
> > 
> > Thank you for your attention.
> > 
> > In my understanding of the MEMORY_HOTPLUG this patch has no effect on it.
> > The reason is that in sparse_add_one_section() the memory that memmap 
> > needs from Slab if kernel start completed，this memory has nothing to 
> > do with memblock alloc/ free memory in the process of kernel start.
> > 
> > You may have a look vmemmap_alloc_block () this function.
> > 
> > If I don't understand right welcome pointed out in a timely manner.
> 
> At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory.
> If you confirm this won't happen, please ignore my noise.
> 
> BTW, next time, bear in mind that top-post is not a good way to reply mail :-)
> 
> > 
> > Thanks!
> > 
> > 
> > -----邮件原件-----
> > 发件人: Song Bao Hua (Barry Song)
> > 发送时间: 2020年7月8日 15:19
> > 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; 
> > will@kernel.org
> > 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> > steve.capper@arm.com; rppt@linux.ibm.com; 
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 
> > sujunfei <sujunfei2@hisilicon.com>
> > 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model 
> > that define VMEMMAP
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: liwei (CM)
> > > Sent: Wednesday, July 8, 2020 1:56 PM
> > > To: catalin.marinas@arm.com; will@kernel.org
> > > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng 
> > > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> > > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) 
> > > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org;
> > > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
> > > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory
> > model
> > > that define VMEMMAP
> > >
> > > For the memory hole, sparse memory model that define
> > SPARSEMEM_VMEMMAP
> > > do not free the reserved memory for the page map, this patch do it.
> > 
> > Hello Wei,
> > Just curious if this patch breaks MEMORY_HOTPLUG?
> > 
> > >
> > > Signed-off-by: Wei Li <liwei213@huawei.com>
> > > Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> > > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> > > ---
> > >  arch/arm64/mm/init.c | 81
> > > +++++++++++++++++++++++++++++++++++++++++++++-------
> > >  1 file changed, 71 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 
> > > 1e93cfc7c47a..d1b56b47d5ba 100644
> > > --- a/arch/arm64/mm/init.c
> > > +++ b/arch/arm64/mm/init.c
> > > @@ -441,7 +441,48 @@ void __init bootmem_init(void)
> > >  	memblock_dump_all();
> > >  }
> > >
> > 
> > Thanks
> > Barry
> 

-- 
Sincerely yours,
Mike.

答复: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[liwei (CM)]

-----邮件原件-----
发件人: Mike Rapoport [mailto:rppt@linux.ibm.com] 
发送时间: 2020年7月21日 14:35
收件人: liwei (CM) <liwei213@huawei.com>
抄送: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; catalin.marinas@arm.com; will@kernel.org; fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com>
主题: Re: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

Hi,

On Tue, Jul 21, 2020 at 01:56:33AM +0000, liwei (CM) wrote:
> Hi, all
> 
> I'm sorry to bother you, but still very hope you can give comments or suggestions to this patch, thank you very much.
 
I cannot find your patch neither in Inbox nor in the public archives.
Can you resend it please?

Hi, Mike

I resend the patch, if you see please give advice, thanks!



> -----邮件原件-----
> 发件人: Song Bao Hua (Barry Song)
> 发送时间: 2020年7月9日 20:27
> 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; 
> will@kernel.org
> 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> steve.capper@arm.com; rppt@linux.ibm.com; 
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 
> sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) 
> <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) 
> <yaobaofeng@huawei.com>
> 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model 
> that define VMEMMAP
> 
> 
> 
> > -----Original Message-----
> > From: liwei (CM)
> > Sent: Wednesday, July 8, 2020 7:52 PM
> > To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; 
> > catalin.marinas@arm.com; will@kernel.org
> > Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; 
> > nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; 
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 
> > sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) 
> > <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) 
> > <yaobaofeng@huawei.com>
> > Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory 
> > model that define VMEMMAP
> > 
> > Hi, baohua
> > 
> > Thank you for your attention.
> > 
> > In my understanding of the MEMORY_HOTPLUG this patch has no effect on it.
> > The reason is that in sparse_add_one_section() the memory that 
> > memmap needs from Slab if kernel start completed，this memory has 
> > nothing to do with memblock alloc/ free memory in the process of kernel start.
> > 
> > You may have a look vmemmap_alloc_block () this function.
> > 
> > If I don't understand right welcome pointed out in a timely manner.
> 
> At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory.
> If you confirm this won't happen, please ignore my noise.
> 
> BTW, next time, bear in mind that top-post is not a good way to reply 
> mail :-)
> 
> > 
> > Thanks!
> > 
> > 
> > -----邮件原件-----
> > 发件人: Song Bao Hua (Barry Song)
> > 发送时间: 2020年7月8日 15:19
> > 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; 
> > will@kernel.org
> > 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; 
> > nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; 
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; 
> > sujunfei <sujunfei2@hisilicon.com>
> > 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory 
> > model that define VMEMMAP
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: liwei (CM)
> > > Sent: Wednesday, July 8, 2020 1:56 PM
> > > To: catalin.marinas@arm.com; will@kernel.org
> > > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng 
> > > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; 
> > > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry 
> > > Song) <song.bao.hua@hisilicon.com>; 
> > > linux-arm-kernel@lists.infradead.org;
> > > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
> > > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory
> > model
> > > that define VMEMMAP
> > >
> > > For the memory hole, sparse memory model that define
> > SPARSEMEM_VMEMMAP
> > > do not free the reserved memory for the page map, this patch do it.
> > 
> > Hello Wei,
> > Just curious if this patch breaks MEMORY_HOTPLUG?
> > 
> > >
> > > Signed-off-by: Wei Li <liwei213@huawei.com>
> > > Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> > > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> > > ---
> > >  arch/arm64/mm/init.c | 81
> > > +++++++++++++++++++++++++++++++++++++++++++++-------
> > >  1 file changed, 71 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 
> > > 1e93cfc7c47a..d1b56b47d5ba 100644
> > > --- a/arch/arm64/mm/init.c
> > > +++ b/arch/arm64/mm/init.c
> > > @@ -441,7 +441,48 @@ void __init bootmem_init(void)
> > >  	memblock_dump_all();
> > >  }
> > >
> > 
> > Thanks
> > Barry
> 

--
Sincerely yours,
Mike.

答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[liwei (CM)]

-----邮件原件-----
发件人: Anshuman Khandual [mailto:anshuman.khandual@arm.com] 
发送时间: 2020年7月23日 10:33
收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org
抄送: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; linux-arm-kernel@lists.infradead.org; steve.capper@arm.com; Chenfeng (puck) <puck.chen@hisilicon.com>; linux-kernel@vger.kernel.org; rppt@linux.ibm.com; fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; butao <butao@hisilicon.com>
主题: Re: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP



On 07/21/2020 01:02 PM, Wei Li wrote:
> For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP 
> do not free the reserved memory for the page map, this patch do it.
> 
> Signed-off-by: Wei Li <liwei213@huawei.com>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> ---
>  arch/arm64/mm/init.c | 81 
> +++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 71 insertions(+), 10 deletions(-)

This patch does not compile on 5.8-rc6 with defconfig.

Hi,

We're working on patch v2 as soon as possible.

Thanks.

Re: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[Catalin Marinas]

On Wed, Jul 22, 2020 at 08:41:17AM +0000, liwei (CM) wrote:
> Mike Rapoport wrote:
> > On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote:
> > > For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP 
> > > do not free the reserved memory for the page map, this patch do it.
> > 
> > Are there numbers showing how much memory is actually freed?
> > 
> > The freeing of empty memmap would become rather complex with these
> > changes, do the memory savings justify it?
> 
> In the sparse memory model, the size of a section is 1 GB
> (SECTION_SIZE_BITS 30) by default.

Can we reduce SECTION_SIZE_BITS instead? Say 26?

-- 
Catalin

答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

[liwei (CM)]

-----邮件原件-----
发件人: Mike Rapoport [mailto:rppt@linux.ibm.com] 
发送时间: 2020年7月22日 14:07
收件人: liwei (CM) <liwei213@huawei.com>
抄送: catalin.marinas@arm.com; will@kernel.org; Xiaqing (A) <saberlily.xia@hisilicon.com>; Chenfeng (puck) <puck.chen@hisilicon.com>; butao <butao@hisilicon.com>; fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>
主题: Re: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

Hi,

On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote:
> For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP 
> do not free the reserved memory for the page map, this patch do it.

Are there numbers showing how much memory is actually freed?

The freeing of empty memmap would become rather complex with these changes, do the memory savings justify it?

Hi, Mike
In the sparse memory model, the size of a section is 1 GB (SECTION_SIZE_BITS 30) by default. Therefore, when the memory is less than the size of a section, that is, when there is a hole, the patch takes effect：

1) For example, the DDR size used by our platform is 8 GB, however, 3.5 ~ 4 GB is the space where the SOC register is located. Therefore, if the page map is performed on memory3 (3 ~4 GB), 512 MB/4 KB x 64 bytes = 8 MB is wasted because the page map is not required for the 3.5~4 GB space; However, the DDR memory space of 3.5~4 GB is shift to 16~16.5 GB. In this case, memory is wasted because the page map is not required for 16.5~17 GB, the patch can also save 8 MB. Therefore, the total saved memory is 16 MB.

2) In the reserved memory, some modules need to reserve a large amount of memory (no-map attr). On our platform, the modem module needs to reserve more than 256 MB memory, and the patch can save 4 MB. Actually, if the reserved memory is greater than 128 MB, the patch can free unnecessary page map memory.

It may be possible to save some waste by reducing the section size, but free the waste page map that defines VMEMMAP is another approach similar to flat memory model and sparse memory mode that does not define VMEMMAP, and makes the entire code look more complete.

If you have a better idea, I'd be happy to discuss it with you.

Thanks!

> Signed-off-by: Wei Li <liwei213@huawei.com>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com>
> ---
>  arch/arm64/mm/init.c | 81 
> +++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 71 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 
> 1e93cfc7c47a..d1b56b47d5ba 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -441,7 +441,48 @@ void __init bootmem_init(void)
>  	memblock_dump_all();
>  }
> 
> -#ifndef CONFIG_SPARSEMEM_VMEMMAP
> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
> +#define VMEMMAP_PAGE_INUSE 0xFD
> +static inline void free_memmap(unsigned long start_pfn, unsigned long 
> +end_pfn) {
> +	unsigned long addr, end;
> +	unsigned long next;
> +	pmd_t *pmd;
> +	void *page_addr;
> +	phys_addr_t phys_addr;
> +
> +	addr = (unsigned long)pfn_to_page(start_pfn);
> +	end = (unsigned long)pfn_to_page(end_pfn);
> +
> +	pmd = pmd_offset(pud_offset(pgd_offset_k(addr), addr), addr);
> +	for (; addr < end; addr = next, pmd++) {
> +		next = pmd_addr_end(addr, end);
> +
> +		if (!pmd_present(*pmd))
> +			continue;
> +
> +		if (IS_ALIGNED(addr, PMD_SIZE) &&
> +			IS_ALIGNED(next, PMD_SIZE)) {
> +			phys_addr = __pfn_to_phys(pmd_pfn(*pmd));
> +			free_bootmem(phys_addr, PMD_SIZE);
> +			pmd_clear(pmd);
> +		} else {
> +			/* If here, we are freeing vmemmap pages. */
> +			memset((void *)addr, VMEMMAP_PAGE_INUSE, next - addr);
> +			page_addr = page_address(pmd_page(*pmd));
> +
> +			if (!memchr_inv(page_addr, VMEMMAP_PAGE_INUSE,
> +				PMD_SIZE)) {
> +				phys_addr = __pfn_to_phys(pmd_pfn(*pmd));
> +				free_bootmem(phys_addr, PMD_SIZE);
> +				pmd_clear(pmd);
> +			}
> +		}
> +	}
> +
> +	flush_tlb_all();
> +}
> +#else
>  static inline void free_memmap(unsigned long start_pfn, unsigned long 
> end_pfn)  {
>  	struct page *start_pg, *end_pg;
> @@ -468,31 +509,53 @@ static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn)
>  		memblock_free(pg, pgend - pg);
>  }
> 
> +#endif
> +
>  /*
>   * The mem_map array can get very big. Free the unused area of the memory map.
>   */
>  static void __init free_unused_memmap(void)  {
> -	unsigned long start, prev_end = 0;
> +	unsigned long start, cur_start, prev_end = 0;
>  	struct memblock_region *reg;
> 
>  	for_each_memblock(memory, reg) {
> -		start = __phys_to_pfn(reg->base);
> +		cur_start = __phys_to_pfn(reg->base);
> 
>  #ifdef CONFIG_SPARSEMEM
>  		/*
>  		 * Take care not to free memmap entries that don't exist due
>  		 * to SPARSEMEM sections which aren't present.
>  		 */
> -		start = min(start, ALIGN(prev_end, PAGES_PER_SECTION));
> -#endif
> +		start = min(cur_start, ALIGN(prev_end, PAGES_PER_SECTION));
> +
>  		/*
> -		 * If we had a previous bank, and there is a space between the
> -		 * current bank and the previous, free it.
> +		 * Free memory in the case of:
> +		 * 1. if cur_start - prev_end <= PAGES_PER_SECTION,
> +		 * free pre_end ~ cur_start.
> +		 * 2. if cur_start - prev_end > PAGES_PER_SECTION,
> +		 * free pre_end ~ ALIGN(prev_end, PAGES_PER_SECTION).
>  		 */
>  		if (prev_end && prev_end < start)
>  			free_memmap(prev_end, start);
> 
> +		/*
> +		 * Free memory in the case of:
> +		 * if cur_start - prev_end > PAGES_PER_SECTION,
> +		 * free ALIGN_DOWN(cur_start, PAGES_PER_SECTION) ~ cur_start.
> +		 */
> +		if (cur_start > start &&
> +		    !IS_ALIGNED(cur_start, PAGES_PER_SECTION))
> +			free_memmap(ALIGN_DOWN(cur_start, PAGES_PER_SECTION),
> +				    cur_start);
> +#else
> +		/*
> +		 * If we had a previous bank, and there is a space between the
> +		 * current bank and the previous, free it.
> +		 */
> +		if (prev_end && prev_end < cur_start)
> +			free_memmap(prev_end, cur_start);
> +#endif
>  		/*
>  		 * Align up here since the VM subsystem insists that the
>  		 * memmap entries are valid from the bank end aligned to @@ -507,7 
> +570,6 @@ static void __init free_unused_memmap(void)
>  		free_memmap(prev_end, ALIGN(prev_end, PAGES_PER_SECTION));  #endif  
> }
> -#endif	/* !CONFIG_SPARSEMEM_VMEMMAP */
> 
>  /*
>   * mem_init() marks the free areas in the mem_map and tells us how 
> much memory @@ -524,9 +586,8 @@ void __init mem_init(void)
> 
>  	set_max_mapnr(max_pfn - PHYS_PFN_OFFSET);
> 
> -#ifndef CONFIG_SPARSEMEM_VMEMMAP
>  	free_unused_memmap();
> -#endif
> +
>  	/* this will put all unused low memory onto the freelists */
>  	memblock_free_all();
> 
> --
> 2.15.0
> 

--
Sincerely yours,
Mike.