* [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP @ 2020-07-21 7:32 Wei Li 2020-07-22 6:07 ` Mike Rapoport 2020-07-23 2:33 ` Anshuman Khandual 0 siblings, 2 replies; 13+ messages in thread From: Wei Li @ 2020-07-21 7:32 UTC (permalink / raw) To: catalin.marinas, will Cc: liwei213, saberlily.xia, puck.chen, butao, fengbaopeng2, nsaenzjulienne, steve.capper, rppt, song.bao.hua, linux-arm-kernel, linux-kernel, sujunfei2 For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP do not free the reserved memory for the page map, this patch do it. Signed-off-by: Wei Li <liwei213@huawei.com> Signed-off-by: Chen Feng <puck.chen@hisilicon.com> Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> --- arch/arm64/mm/init.c | 81 +++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 71 insertions(+), 10 deletions(-) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 1e93cfc7c47a..d1b56b47d5ba 100644 --- a/arch/arm64/mm/init.c +++ b/arch/arm64/mm/init.c @@ -441,7 +441,48 @@ void __init bootmem_init(void) memblock_dump_all(); } -#ifndef CONFIG_SPARSEMEM_VMEMMAP +#ifdef CONFIG_SPARSEMEM_VMEMMAP +#define VMEMMAP_PAGE_INUSE 0xFD +static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) +{ + unsigned long addr, end; + unsigned long next; + pmd_t *pmd; + void *page_addr; + phys_addr_t phys_addr; + + addr = (unsigned long)pfn_to_page(start_pfn); + end = (unsigned long)pfn_to_page(end_pfn); + + pmd = pmd_offset(pud_offset(pgd_offset_k(addr), addr), addr); + for (; addr < end; addr = next, pmd++) { + next = pmd_addr_end(addr, end); + + if (!pmd_present(*pmd)) + continue; + + if (IS_ALIGNED(addr, PMD_SIZE) && + IS_ALIGNED(next, PMD_SIZE)) { + phys_addr = __pfn_to_phys(pmd_pfn(*pmd)); + free_bootmem(phys_addr, PMD_SIZE); + pmd_clear(pmd); + } else { + /* If here, we are freeing vmemmap pages. */ + memset((void *)addr, VMEMMAP_PAGE_INUSE, next - addr); + page_addr = page_address(pmd_page(*pmd)); + + if (!memchr_inv(page_addr, VMEMMAP_PAGE_INUSE, + PMD_SIZE)) { + phys_addr = __pfn_to_phys(pmd_pfn(*pmd)); + free_bootmem(phys_addr, PMD_SIZE); + pmd_clear(pmd); + } + } + } + + flush_tlb_all(); +} +#else static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) { struct page *start_pg, *end_pg; @@ -468,31 +509,53 @@ static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) memblock_free(pg, pgend - pg); } +#endif + /* * The mem_map array can get very big. Free the unused area of the memory map. */ static void __init free_unused_memmap(void) { - unsigned long start, prev_end = 0; + unsigned long start, cur_start, prev_end = 0; struct memblock_region *reg; for_each_memblock(memory, reg) { - start = __phys_to_pfn(reg->base); + cur_start = __phys_to_pfn(reg->base); #ifdef CONFIG_SPARSEMEM /* * Take care not to free memmap entries that don't exist due * to SPARSEMEM sections which aren't present. */ - start = min(start, ALIGN(prev_end, PAGES_PER_SECTION)); -#endif + start = min(cur_start, ALIGN(prev_end, PAGES_PER_SECTION)); + /* - * If we had a previous bank, and there is a space between the - * current bank and the previous, free it. + * Free memory in the case of: + * 1. if cur_start - prev_end <= PAGES_PER_SECTION, + * free pre_end ~ cur_start. + * 2. if cur_start - prev_end > PAGES_PER_SECTION, + * free pre_end ~ ALIGN(prev_end, PAGES_PER_SECTION). */ if (prev_end && prev_end < start) free_memmap(prev_end, start); + /* + * Free memory in the case of: + * if cur_start - prev_end > PAGES_PER_SECTION, + * free ALIGN_DOWN(cur_start, PAGES_PER_SECTION) ~ cur_start. + */ + if (cur_start > start && + !IS_ALIGNED(cur_start, PAGES_PER_SECTION)) + free_memmap(ALIGN_DOWN(cur_start, PAGES_PER_SECTION), + cur_start); +#else + /* + * If we had a previous bank, and there is a space between the + * current bank and the previous, free it. + */ + if (prev_end && prev_end < cur_start) + free_memmap(prev_end, cur_start); +#endif /* * Align up here since the VM subsystem insists that the * memmap entries are valid from the bank end aligned to @@ -507,7 +570,6 @@ static void __init free_unused_memmap(void) free_memmap(prev_end, ALIGN(prev_end, PAGES_PER_SECTION)); #endif } -#endif /* !CONFIG_SPARSEMEM_VMEMMAP */ /* * mem_init() marks the free areas in the mem_map and tells us how much memory @@ -524,9 +586,8 @@ void __init mem_init(void) set_max_mapnr(max_pfn - PHYS_PFN_OFFSET); -#ifndef CONFIG_SPARSEMEM_VMEMMAP free_unused_memmap(); -#endif + /* this will put all unused low memory onto the freelists */ memblock_free_all(); -- 2.15.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-21 7:32 [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP Wei Li @ 2020-07-22 6:07 ` Mike Rapoport 2020-07-22 8:41 ` 答复: " liwei (CM) 2020-07-23 2:33 ` Anshuman Khandual 1 sibling, 1 reply; 13+ messages in thread From: Mike Rapoport @ 2020-07-22 6:07 UTC (permalink / raw) To: Wei Li Cc: catalin.marinas, will, saberlily.xia, puck.chen, butao, fengbaopeng2, nsaenzjulienne, steve.capper, song.bao.hua, linux-arm-kernel, linux-kernel, sujunfei2 Hi, On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote: > For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP > do not free the reserved memory for the page map, this patch do it. Are there numbers showing how much memory is actually freed? The freeing of empty memmap would become rather complex with these changes, do the memory savings justify it? > Signed-off-by: Wei Li <liwei213@huawei.com> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > --- > arch/arm64/mm/init.c | 81 +++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index 1e93cfc7c47a..d1b56b47d5ba 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -441,7 +441,48 @@ void __init bootmem_init(void) > memblock_dump_all(); > } > > -#ifndef CONFIG_SPARSEMEM_VMEMMAP > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > +#define VMEMMAP_PAGE_INUSE 0xFD > +static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) > +{ > + unsigned long addr, end; > + unsigned long next; > + pmd_t *pmd; > + void *page_addr; > + phys_addr_t phys_addr; > + > + addr = (unsigned long)pfn_to_page(start_pfn); > + end = (unsigned long)pfn_to_page(end_pfn); > + > + pmd = pmd_offset(pud_offset(pgd_offset_k(addr), addr), addr); > + for (; addr < end; addr = next, pmd++) { > + next = pmd_addr_end(addr, end); > + > + if (!pmd_present(*pmd)) > + continue; > + > + if (IS_ALIGNED(addr, PMD_SIZE) && > + IS_ALIGNED(next, PMD_SIZE)) { > + phys_addr = __pfn_to_phys(pmd_pfn(*pmd)); > + free_bootmem(phys_addr, PMD_SIZE); > + pmd_clear(pmd); > + } else { > + /* If here, we are freeing vmemmap pages. */ > + memset((void *)addr, VMEMMAP_PAGE_INUSE, next - addr); > + page_addr = page_address(pmd_page(*pmd)); > + > + if (!memchr_inv(page_addr, VMEMMAP_PAGE_INUSE, > + PMD_SIZE)) { > + phys_addr = __pfn_to_phys(pmd_pfn(*pmd)); > + free_bootmem(phys_addr, PMD_SIZE); > + pmd_clear(pmd); > + } > + } > + } > + > + flush_tlb_all(); > +} > +#else > static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) > { > struct page *start_pg, *end_pg; > @@ -468,31 +509,53 @@ static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) > memblock_free(pg, pgend - pg); > } > > +#endif > + > /* > * The mem_map array can get very big. Free the unused area of the memory map. > */ > static void __init free_unused_memmap(void) > { > - unsigned long start, prev_end = 0; > + unsigned long start, cur_start, prev_end = 0; > struct memblock_region *reg; > > for_each_memblock(memory, reg) { > - start = __phys_to_pfn(reg->base); > + cur_start = __phys_to_pfn(reg->base); > > #ifdef CONFIG_SPARSEMEM > /* > * Take care not to free memmap entries that don't exist due > * to SPARSEMEM sections which aren't present. > */ > - start = min(start, ALIGN(prev_end, PAGES_PER_SECTION)); > -#endif > + start = min(cur_start, ALIGN(prev_end, PAGES_PER_SECTION)); > + > /* > - * If we had a previous bank, and there is a space between the > - * current bank and the previous, free it. > + * Free memory in the case of: > + * 1. if cur_start - prev_end <= PAGES_PER_SECTION, > + * free pre_end ~ cur_start. > + * 2. if cur_start - prev_end > PAGES_PER_SECTION, > + * free pre_end ~ ALIGN(prev_end, PAGES_PER_SECTION). > */ > if (prev_end && prev_end < start) > free_memmap(prev_end, start); > > + /* > + * Free memory in the case of: > + * if cur_start - prev_end > PAGES_PER_SECTION, > + * free ALIGN_DOWN(cur_start, PAGES_PER_SECTION) ~ cur_start. > + */ > + if (cur_start > start && > + !IS_ALIGNED(cur_start, PAGES_PER_SECTION)) > + free_memmap(ALIGN_DOWN(cur_start, PAGES_PER_SECTION), > + cur_start); > +#else > + /* > + * If we had a previous bank, and there is a space between the > + * current bank and the previous, free it. > + */ > + if (prev_end && prev_end < cur_start) > + free_memmap(prev_end, cur_start); > +#endif > /* > * Align up here since the VM subsystem insists that the > * memmap entries are valid from the bank end aligned to > @@ -507,7 +570,6 @@ static void __init free_unused_memmap(void) > free_memmap(prev_end, ALIGN(prev_end, PAGES_PER_SECTION)); > #endif > } > -#endif /* !CONFIG_SPARSEMEM_VMEMMAP */ > > /* > * mem_init() marks the free areas in the mem_map and tells us how much memory > @@ -524,9 +586,8 @@ void __init mem_init(void) > > set_max_mapnr(max_pfn - PHYS_PFN_OFFSET); > > -#ifndef CONFIG_SPARSEMEM_VMEMMAP > free_unused_memmap(); > -#endif > + > /* this will put all unused low memory onto the freelists */ > memblock_free_all(); > > -- > 2.15.0 > -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 13+ messages in thread
* 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-22 6:07 ` Mike Rapoport @ 2020-07-22 8:41 ` liwei (CM) 2020-07-22 12:49 ` Catalin Marinas 0 siblings, 1 reply; 13+ messages in thread From: liwei (CM) @ 2020-07-22 8:41 UTC (permalink / raw) To: Mike Rapoport Cc: catalin.marinas, will, Xiaqing (A), Chenfeng (puck), butao, fengbaopeng, nsaenzjulienne, steve.capper, Song Bao Hua (Barry Song), linux-arm-kernel, linux-kernel, sujunfei, zhaojiapeng -----邮件原件----- 发件人: Mike Rapoport [mailto:rppt@linux.ibm.com] 发送时间: 2020年7月22日 14:07 收件人: liwei (CM) <liwei213@huawei.com> 抄送: catalin.marinas@arm.com; will@kernel.org; Xiaqing (A) <saberlily.xia@hisilicon.com>; Chenfeng (puck) <puck.chen@hisilicon.com>; butao <butao@hisilicon.com>; fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com> 主题: Re: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP Hi, On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote: > For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP > do not free the reserved memory for the page map, this patch do it. Are there numbers showing how much memory is actually freed? The freeing of empty memmap would become rather complex with these changes, do the memory savings justify it? Hi, Mike In the sparse memory model, the size of a section is 1 GB (SECTION_SIZE_BITS 30) by default. Therefore, when the memory is less than the size of a section, that is, when there is a hole, the patch takes effect： 1) For example, the DDR size used by our platform is 8 GB, however, 3.5 ~ 4 GB is the space where the SOC register is located. Therefore, if the page map is performed on memory3 (3 ~4 GB), 512 MB/4 KB x 64 bytes = 8 MB is wasted because the page map is not required for the 3.5~4 GB space; However, the DDR memory space of 3.5~4 GB is shift to 16~16.5 GB. In this case, memory is wasted because the page map is not required for 16.5~17 GB, the patch can also save 8 MB. Therefore, the total saved memory is 16 MB. 2) In the reserved memory, some modules need to reserve a large amount of memory (no-map attr). On our platform, the modem module needs to reserve more than 256 MB memory, and the patch can save 4 MB. Actually, if the reserved memory is greater than 128 MB, the patch can free unnecessary page map memory. It may be possible to save some waste by reducing the section size, but free the waste page map that defines VMEMMAP is another approach similar to flat memory model and sparse memory mode that does not define VMEMMAP, and makes the entire code look more complete. If you have a better idea, I'd be happy to discuss it with you. Thanks! > Signed-off-by: Wei Li <liwei213@huawei.com> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > --- > arch/arm64/mm/init.c | 81 > +++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index > 1e93cfc7c47a..d1b56b47d5ba 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -441,7 +441,48 @@ void __init bootmem_init(void) > memblock_dump_all(); > } > > -#ifndef CONFIG_SPARSEMEM_VMEMMAP > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > +#define VMEMMAP_PAGE_INUSE 0xFD > +static inline void free_memmap(unsigned long start_pfn, unsigned long > +end_pfn) { > + unsigned long addr, end; > + unsigned long next; > + pmd_t *pmd; > + void *page_addr; > + phys_addr_t phys_addr; > + > + addr = (unsigned long)pfn_to_page(start_pfn); > + end = (unsigned long)pfn_to_page(end_pfn); > + > + pmd = pmd_offset(pud_offset(pgd_offset_k(addr), addr), addr); > + for (; addr < end; addr = next, pmd++) { > + next = pmd_addr_end(addr, end); > + > + if (!pmd_present(*pmd)) > + continue; > + > + if (IS_ALIGNED(addr, PMD_SIZE) && > + IS_ALIGNED(next, PMD_SIZE)) { > + phys_addr = __pfn_to_phys(pmd_pfn(*pmd)); > + free_bootmem(phys_addr, PMD_SIZE); > + pmd_clear(pmd); > + } else { > + /* If here, we are freeing vmemmap pages. */ > + memset((void *)addr, VMEMMAP_PAGE_INUSE, next - addr); > + page_addr = page_address(pmd_page(*pmd)); > + > + if (!memchr_inv(page_addr, VMEMMAP_PAGE_INUSE, > + PMD_SIZE)) { > + phys_addr = __pfn_to_phys(pmd_pfn(*pmd)); > + free_bootmem(phys_addr, PMD_SIZE); > + pmd_clear(pmd); > + } > + } > + } > + > + flush_tlb_all(); > +} > +#else > static inline void free_memmap(unsigned long start_pfn, unsigned long > end_pfn) { > struct page *start_pg, *end_pg; > @@ -468,31 +509,53 @@ static inline void free_memmap(unsigned long start_pfn, unsigned long end_pfn) > memblock_free(pg, pgend - pg); > } > > +#endif > + > /* > * The mem_map array can get very big. Free the unused area of the memory map. > */ > static void __init free_unused_memmap(void) { > - unsigned long start, prev_end = 0; > + unsigned long start, cur_start, prev_end = 0; > struct memblock_region *reg; > > for_each_memblock(memory, reg) { > - start = __phys_to_pfn(reg->base); > + cur_start = __phys_to_pfn(reg->base); > > #ifdef CONFIG_SPARSEMEM > /* > * Take care not to free memmap entries that don't exist due > * to SPARSEMEM sections which aren't present. > */ > - start = min(start, ALIGN(prev_end, PAGES_PER_SECTION)); > -#endif > + start = min(cur_start, ALIGN(prev_end, PAGES_PER_SECTION)); > + > /* > - * If we had a previous bank, and there is a space between the > - * current bank and the previous, free it. > + * Free memory in the case of: > + * 1. if cur_start - prev_end <= PAGES_PER_SECTION, > + * free pre_end ~ cur_start. > + * 2. if cur_start - prev_end > PAGES_PER_SECTION, > + * free pre_end ~ ALIGN(prev_end, PAGES_PER_SECTION). > */ > if (prev_end && prev_end < start) > free_memmap(prev_end, start); > > + /* > + * Free memory in the case of: > + * if cur_start - prev_end > PAGES_PER_SECTION, > + * free ALIGN_DOWN(cur_start, PAGES_PER_SECTION) ~ cur_start. > + */ > + if (cur_start > start && > + !IS_ALIGNED(cur_start, PAGES_PER_SECTION)) > + free_memmap(ALIGN_DOWN(cur_start, PAGES_PER_SECTION), > + cur_start); > +#else > + /* > + * If we had a previous bank, and there is a space between the > + * current bank and the previous, free it. > + */ > + if (prev_end && prev_end < cur_start) > + free_memmap(prev_end, cur_start); > +#endif > /* > * Align up here since the VM subsystem insists that the > * memmap entries are valid from the bank end aligned to @@ -507,7 > +570,6 @@ static void __init free_unused_memmap(void) > free_memmap(prev_end, ALIGN(prev_end, PAGES_PER_SECTION)); #endif > } > -#endif /* !CONFIG_SPARSEMEM_VMEMMAP */ > > /* > * mem_init() marks the free areas in the mem_map and tells us how > much memory @@ -524,9 +586,8 @@ void __init mem_init(void) > > set_max_mapnr(max_pfn - PHYS_PFN_OFFSET); > > -#ifndef CONFIG_SPARSEMEM_VMEMMAP > free_unused_memmap(); > -#endif > + > /* this will put all unused low memory onto the freelists */ > memblock_free_all(); > > -- > 2.15.0 > -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-22 8:41 ` 答复: " liwei (CM) @ 2020-07-22 12:49 ` Catalin Marinas 2020-07-22 13:40 ` 答复: " liwei (CM) 0 siblings, 1 reply; 13+ messages in thread From: Catalin Marinas @ 2020-07-22 12:49 UTC (permalink / raw) To: liwei (CM) Cc: Mike Rapoport, will, Xiaqing (A), Chenfeng (puck), butao, fengbaopeng, nsaenzjulienne, steve.capper, Song Bao Hua (Barry Song), linux-arm-kernel, linux-kernel, sujunfei, zhaojiapeng On Wed, Jul 22, 2020 at 08:41:17AM +0000, liwei (CM) wrote: > Mike Rapoport wrote: > > On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote: > > > For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP > > > do not free the reserved memory for the page map, this patch do it. > > > > Are there numbers showing how much memory is actually freed? > > > > The freeing of empty memmap would become rather complex with these > > changes, do the memory savings justify it? > > In the sparse memory model, the size of a section is 1 GB > (SECTION_SIZE_BITS 30) by default. Can we reduce SECTION_SIZE_BITS instead? Say 26? -- Catalin ^ permalink raw reply [flat|nested] 13+ messages in thread
* 答复: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-22 12:49 ` Catalin Marinas @ 2020-07-22 13:40 ` liwei (CM) 2020-07-23 11:29 ` Catalin Marinas 0 siblings, 1 reply; 13+ messages in thread From: liwei (CM) @ 2020-07-22 13:40 UTC (permalink / raw) To: Catalin Marinas Cc: Mike Rapoport, will, Xiaqing (A), Chenfeng (puck), butao, fengbaopeng, nsaenzjulienne, steve.capper, Song Bao Hua (Barry Song), linux-arm-kernel, linux-kernel, sujunfei, zhaojiapeng -----邮件原件----- 发件人: Catalin Marinas [mailto:catalin.marinas@arm.com] 发送时间: 2020年7月22日 20:49 收件人: liwei (CM) <liwei213@huawei.com> 抄送: Mike Rapoport <rppt@linux.ibm.com>; will@kernel.org; Xiaqing (A) <saberlily.xia@hisilicon.com>; Chenfeng (puck) <puck.chen@hisilicon.com>; butao <butao@hisilicon.com>; fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>; zhaojiapeng <zhaojiapeng@huawei.com> 主题: Re: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP On Wed, Jul 22, 2020 at 08:41:17AM +0000, liwei (CM) wrote: > Mike Rapoport wrote: > > On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote: > > > For the memory hole, sparse memory model that define > > > SPARSEMEM_VMEMMAP do not free the reserved memory for the page map, this patch do it. > > > > Are there numbers showing how much memory is actually freed? > > > > The freeing of empty memmap would become rather complex with these > > changes, do the memory savings justify it? > > In the sparse memory model, the size of a section is 1 GB > (SECTION_SIZE_BITS 30) by default. Can we reduce SECTION_SIZE_BITS instead? Say 26? Hi, Catalin Yes, you are right, reduce SECTION_SIZE_BITS to 26 can save almost the same memory as the patch. 1) However, it is not clear whether changing the section size has any other impact. 2) Just like the flat memory model and the sparse memory model that does not define VMEMMAP, both of them have their own ways to free unused memmap. I think we've given a similar way for sparse memory define VMEMMAP. 3) This explicit free unused memmap method does reduce unnecessary memory waste for users who do not notice the section size modification. Hope you will reconsider the purpose and significance of this patch, thanks. -- Catalin ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 答复: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-22 13:40 ` 答复: " liwei (CM) @ 2020-07-23 11:29 ` Catalin Marinas 2020-07-23 13:18 ` Mike Rapoport 0 siblings, 1 reply; 13+ messages in thread From: Catalin Marinas @ 2020-07-23 11:29 UTC (permalink / raw) To: liwei (CM) Cc: Mike Rapoport, will, Xiaqing (A), Chenfeng (puck), butao, fengbaopeng, nsaenzjulienne, steve.capper, Song Bao Hua (Barry Song), linux-arm-kernel, linux-kernel, sujunfei, zhaojiapeng On Wed, Jul 22, 2020 at 01:40:34PM +0000, liwei (CM) wrote: > Catalin Marinas wrote: > > On Wed, Jul 22, 2020 at 08:41:17AM +0000, liwei (CM) wrote: > > > Mike Rapoport wrote: > > > > On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote: > > > > > For the memory hole, sparse memory model that define > > > > > SPARSEMEM_VMEMMAP do not free the reserved memory for the page > > > > > map, this patch do it. > > > > > > > > Are there numbers showing how much memory is actually freed? > > > > > > > > The freeing of empty memmap would become rather complex with these > > > > changes, do the memory savings justify it? > > > > > > In the sparse memory model, the size of a section is 1 GB > > > (SECTION_SIZE_BITS 30) by default. > > > > Can we reduce SECTION_SIZE_BITS instead? Say 26? > > Yes, you are right, reduce SECTION_SIZE_BITS to 26 can save almost the > same memory as the patch. > > 1) However, it is not clear whether changing the section size has any > other impact. Well, we should analyse this. > 2) Just like the flat memory model and the sparse memory model that > does not define VMEMMAP, both of them have their own ways to free > unused memmap. I think we've given a similar way for sparse memory > define VMEMMAP. I think we did it for flatmem initially (on arm32) and added support for sparsemem later on, so free_unused_memmap() had to cope with sparse sections. On arm64 we introduced vmemmap support and didn't bother with the freeing at all because of the added complexity of the vmemmap page tables. I wonder whether we should just disallow flatmem and non-vmemmap sparsemem on arm64. Is there any value in keeping them around? > 3) This explicit free unused memmap method does reduce unnecessary > memory waste for users who do not notice the section size > modification. But if we changed SECTION_SIZE_BITS in the mainline kernel, then we wouldn't need additional code to free the unused memmap. -- Catalin ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 答复: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-23 11:29 ` Catalin Marinas @ 2020-07-23 13:18 ` Mike Rapoport 2020-07-24 3:40 ` 答复: " liwei (CM) 0 siblings, 1 reply; 13+ messages in thread From: Mike Rapoport @ 2020-07-23 13:18 UTC (permalink / raw) To: Catalin Marinas Cc: liwei (CM), will, Xiaqing (A), Chenfeng (puck), butao, fengbaopeng, nsaenzjulienne, steve.capper, Song Bao Hua (Barry Song), linux-arm-kernel, linux-kernel, sujunfei, zhaojiapeng On Thu, Jul 23, 2020 at 12:29:26PM +0100, Catalin Marinas wrote: > On Wed, Jul 22, 2020 at 01:40:34PM +0000, liwei (CM) wrote: > > Catalin Marinas wrote: > > > On Wed, Jul 22, 2020 at 08:41:17AM +0000, liwei (CM) wrote: > > > > Mike Rapoport wrote: > > > > > On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote: > > > > > > For the memory hole, sparse memory model that define > > > > > > SPARSEMEM_VMEMMAP do not free the reserved memory for the page > > > > > > map, this patch do it. > > > > > > > > > > Are there numbers showing how much memory is actually freed? > > > > > > > > > > The freeing of empty memmap would become rather complex with these > > > > > changes, do the memory savings justify it? > > > > > > > > In the sparse memory model, the size of a section is 1 GB > > > > (SECTION_SIZE_BITS 30) by default. > > > > > > Can we reduce SECTION_SIZE_BITS instead? Say 26? > > > > Yes, you are right, reduce SECTION_SIZE_BITS to 26 can save almost the > > same memory as the patch. > > > > 1) However, it is not clear whether changing the section size has any > > other impact. > > Well, we should analyse this. > > > 2) Just like the flat memory model and the sparse memory model that > > does not define VMEMMAP, both of them have their own ways to free > > unused memmap. I think we've given a similar way for sparse memory > > define VMEMMAP. > > I think we did it for flatmem initially (on arm32) and added support for > sparsemem later on, so free_unused_memmap() had to cope with sparse > sections. On arm64 we introduced vmemmap support and didn't bother with > the freeing at all because of the added complexity of the vmemmap page > tables. > > I wonder whether we should just disallow flatmem and non-vmemmap > sparsemem on arm64. Is there any value in keeping them around? FLATMEM is useful for UMA systems with a single memory bank, so probably it's worth keeping it for low end machines. Non-vmemmap sparsemem is essentially disable in arch/arm64/Kconfig, so for NUMA configurations SPARSEMEM_VMEMMAP is the only choice. > > 3) This explicit free unused memmap method does reduce unnecessary > > memory waste for users who do not notice the section size > > modification. > > But if we changed SECTION_SIZE_BITS in the mainline kernel, then we > wouldn't need additional code to free the unused memmap. Moreover if we reduce SECTION_SIZE_BITS, we can drop free_unused_memmap() and since the arm64 memory map for sparse will not differ from other arches we can drop custom pfn_valid() as well. > -- > Catalin -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 13+ messages in thread
* 答复: 答复: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-23 13:18 ` Mike Rapoport @ 2020-07-24 3:40 ` liwei (CM) 0 siblings, 0 replies; 13+ messages in thread From: liwei (CM) @ 2020-07-24 3:40 UTC (permalink / raw) To: Mike Rapoport, Catalin Marinas Cc: will, Xiaqing (A), Chenfeng (puck), butao, fengbaopeng, nsaenzjulienne, steve.capper, Song Bao Hua (Barry Song), linux-arm-kernel, linux-kernel, sujunfei, zhaojiapeng -----邮件原件----- 发件人: Mike Rapoport [mailto:rppt@linux.ibm.com] 发送时间: 2020年7月23日 21:19 收件人: Catalin Marinas <catalin.marinas@arm.com> 抄送: liwei (CM) <liwei213@huawei.com>; will@kernel.org; Xiaqing (A) <saberlily.xia@hisilicon.com>; Chenfeng (puck) <puck.chen@hisilicon.com>; butao <butao@hisilicon.com>; fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>; zhaojiapeng <zhaojiapeng@huawei.com> 主题: Re: 答复: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP On Thu, Jul 23, 2020 at 12:29:26PM +0100, Catalin Marinas wrote: > On Wed, Jul 22, 2020 at 01:40:34PM +0000, liwei (CM) wrote: > > Catalin Marinas wrote: > > > On Wed, Jul 22, 2020 at 08:41:17AM +0000, liwei (CM) wrote: > > > > Mike Rapoport wrote: > > > > > On Tue, Jul 21, 2020 at 03:32:03PM +0800, Wei Li wrote: > > > > > > For the memory hole, sparse memory model that define > > > > > > SPARSEMEM_VMEMMAP do not free the reserved memory for the > > > > > > page map, this patch do it. > > > > > > > > > > Are there numbers showing how much memory is actually freed? > > > > > > > > > > The freeing of empty memmap would become rather complex with > > > > > these changes, do the memory savings justify it? > > > > > > > > In the sparse memory model, the size of a section is 1 GB > > > > (SECTION_SIZE_BITS 30) by default. > > > > > > Can we reduce SECTION_SIZE_BITS instead? Say 26? > > > > Yes, you are right, reduce SECTION_SIZE_BITS to 26 can save almost > > the same memory as the patch. > > > > 1) However, it is not clear whether changing the section size has > > any other impact. > > Well, we should analyse this. > > > 2) Just like the flat memory model and the sparse memory model that > > does not define VMEMMAP, both of them have their own ways to free > > unused memmap. I think we've given a similar way for sparse memory > > define VMEMMAP. > > I think we did it for flatmem initially (on arm32) and added support > for sparsemem later on, so free_unused_memmap() had to cope with > sparse sections. On arm64 we introduced vmemmap support and didn't > bother with the freeing at all because of the added complexity of the > vmemmap page tables. > > I wonder whether we should just disallow flatmem and non-vmemmap > sparsemem on arm64. Is there any value in keeping them around? FLATMEM is useful for UMA systems with a single memory bank, so probably it's worth keeping it for low end machines. Non-vmemmap sparsemem is essentially disable in arch/arm64/Kconfig, so for NUMA configurations SPARSEMEM_VMEMMAP is the only choice. > > 3) This explicit free unused memmap method does reduce unnecessary > > memory waste for users who do not notice the section size > > modification. > > But if we changed SECTION_SIZE_BITS in the mainline kernel, then we > wouldn't need additional code to free the unused memmap. Moreover if we reduce SECTION_SIZE_BITS, we can drop free_unused_memmap() and since the arm64 memory map for sparse will not differ from other arches we can drop custom pfn_valid() as well. Hi, Mike & Catalin Let's think and discuss together about the impact of directly reducing the section size： 1) Currently, the memory of PC or Mobile devices are increasing. If the section size is reduced, the consumption of the section structure will also increase. 2) If the section size is too small, memory hotplug may be affected. Hotplug add or remove a memblock means that you need to online or offline many sections. In this case, software consumption may increase. Currently, the page map is wasted when the default section size is used. In some cases, the waste is serious. Please help to check whether the section size reduction has other impacts and whether it meets the long-term evolution. Thanks. > -- > Catalin -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-21 7:32 [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP Wei Li 2020-07-22 6:07 ` Mike Rapoport @ 2020-07-23 2:33 ` Anshuman Khandual 2020-07-23 3:28 ` 答复: " liwei (CM) 1 sibling, 1 reply; 13+ messages in thread From: Anshuman Khandual @ 2020-07-23 2:33 UTC (permalink / raw) To: Wei Li, catalin.marinas, will Cc: song.bao.hua, sujunfei2, saberlily.xia, linux-arm-kernel, steve.capper, puck.chen, linux-kernel, rppt, fengbaopeng2, nsaenzjulienne, butao On 07/21/2020 01:02 PM, Wei Li wrote: > For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP > do not free the reserved memory for the page map, this patch do it. > > Signed-off-by: Wei Li <liwei213@huawei.com> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > --- > arch/arm64/mm/init.c | 81 +++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 10 deletions(-) This patch does not compile on 5.8-rc6 with defconfig. ^ permalink raw reply [flat|nested] 13+ messages in thread
* 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-23 2:33 ` Anshuman Khandual @ 2020-07-23 3:28 ` liwei (CM) 0 siblings, 0 replies; 13+ messages in thread From: liwei (CM) @ 2020-07-23 3:28 UTC (permalink / raw) To: Anshuman Khandual, catalin.marinas, will Cc: Song Bao Hua (Barry Song), sujunfei, Xiaqing (A), linux-arm-kernel, steve.capper, Chenfeng (puck), linux-kernel, rppt, fengbaopeng, nsaenzjulienne, butao -----邮件原件----- 发件人: Anshuman Khandual [mailto:anshuman.khandual@arm.com] 发送时间: 2020年7月23日 10:33 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org 抄送: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; linux-arm-kernel@lists.infradead.org; steve.capper@arm.com; Chenfeng (puck) <puck.chen@hisilicon.com>; linux-kernel@vger.kernel.org; rppt@linux.ibm.com; fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; butao <butao@hisilicon.com> 主题: Re: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP On 07/21/2020 01:02 PM, Wei Li wrote: > For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP > do not free the reserved memory for the page map, this patch do it. > > Signed-off-by: Wei Li <liwei213@huawei.com> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > --- > arch/arm64/mm/init.c | 81 > +++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 10 deletions(-) This patch does not compile on 5.8-rc6 with defconfig. Hi, We're working on patch v2 as soon as possible. Thanks. ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <20200708015555.14946-1-liwei213@huawei.com>]
* RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP [not found] <20200708015555.14946-1-liwei213@huawei.com> @ 2020-07-08 7:18 ` Song Bao Hua (Barry Song) 2020-07-08 7:51 ` 答复: " liwei (CM) 0 siblings, 1 reply; 13+ messages in thread From: Song Bao Hua (Barry Song) @ 2020-07-08 7:18 UTC (permalink / raw) To: liwei (CM), catalin.marinas, will Cc: fengbaopeng, nsaenzjulienne, steve.capper, rppt, linux-arm-kernel, linux-kernel, sujunfei > -----Original Message----- > From: liwei (CM) > Sent: Wednesday, July 8, 2020 1:56 PM > To: catalin.marinas@arm.com; will@kernel.org > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com> > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory model > that define VMEMMAP > > For the memory hole, sparse memory model that define > SPARSEMEM_VMEMMAP do not free the reserved memory for the page map, > this patch do it. Hello Wei, Just curious if this patch breaks MEMORY_HOTPLUG? > > Signed-off-by: Wei Li <liwei213@huawei.com> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > --- > arch/arm64/mm/init.c | 81 > +++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index > 1e93cfc7c47a..d1b56b47d5ba 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -441,7 +441,48 @@ void __init bootmem_init(void) > memblock_dump_all(); > } > Thanks Barry ^ permalink raw reply [flat|nested] 13+ messages in thread
* 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-08 7:18 ` Song Bao Hua (Barry Song) @ 2020-07-08 7:51 ` liwei (CM) 2020-07-09 12:27 ` Song Bao Hua (Barry Song) 0 siblings, 1 reply; 13+ messages in thread From: liwei (CM) @ 2020-07-08 7:51 UTC (permalink / raw) To: Song Bao Hua (Barry Song), catalin.marinas, will Cc: fengbaopeng, nsaenzjulienne, steve.capper, rppt, linux-arm-kernel, linux-kernel, sujunfei, Xiaqing (A), Yaobaofeng (Yaobaofeng) Hi, baohua Thank you for your attention. In my understanding of the MEMORY_HOTPLUG this patch has no effect on it. The reason is that in sparse_add_one_section() the memory that memmap needs from Slab if kernel start completed，this memory has nothing to do with memblock alloc/ free memory in the process of kernel start. You may have a look vmemmap_alloc_block () this function. If I don't understand right welcome pointed out in a timely manner. Thanks! -----邮件原件----- 发件人: Song Bao Hua (Barry Song) 发送时间: 2020年7月8日 15:19 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com> 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP > -----Original Message----- > From: liwei (CM) > Sent: Wednesday, July 8, 2020 1:56 PM > To: catalin.marinas@arm.com; will@kernel.org > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com> > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory model > that define VMEMMAP > > For the memory hole, sparse memory model that define SPARSEMEM_VMEMMAP > do not free the reserved memory for the page map, this patch do it. Hello Wei, Just curious if this patch breaks MEMORY_HOTPLUG? > > Signed-off-by: Wei Li <liwei213@huawei.com> > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > --- > arch/arm64/mm/init.c | 81 > +++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index > 1e93cfc7c47a..d1b56b47d5ba 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -441,7 +441,48 @@ void __init bootmem_init(void) > memblock_dump_all(); > } > Thanks Barry ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-08 7:51 ` 答复: " liwei (CM) @ 2020-07-09 12:27 ` Song Bao Hua (Barry Song) 2020-07-21 1:56 ` 答复: " liwei (CM) 0 siblings, 1 reply; 13+ messages in thread From: Song Bao Hua (Barry Song) @ 2020-07-09 12:27 UTC (permalink / raw) To: liwei (CM), catalin.marinas, will Cc: fengbaopeng, nsaenzjulienne, steve.capper, rppt, linux-arm-kernel, linux-kernel, sujunfei, Xiaqing (A), Yaobaofeng (Yaobaofeng) > -----Original Message----- > From: liwei (CM) > Sent: Wednesday, July 8, 2020 7:52 PM > To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; > catalin.marinas@arm.com; will@kernel.org > Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > steve.capper@arm.com; rppt@linux.ibm.com; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei > <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; > Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com> > Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory > model that define VMEMMAP > > Hi, baohua > > Thank you for your attention. > > In my understanding of the MEMORY_HOTPLUG this patch has no effect on it. > The reason is that in sparse_add_one_section() the memory that memmap > needs from Slab if kernel start completed，this memory has nothing to do with > memblock alloc/ free memory in the process of kernel start. > > You may have a look vmemmap_alloc_block () this function. > > If I don't understand right welcome pointed out in a timely manner. At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory. If you confirm this won't happen, please ignore my noise. BTW, next time, bear in mind that top-post is not a good way to reply mail :-) > > Thanks! > > > -----邮件原件----- > 发件人: Song Bao Hua (Barry Song) > 发送时间: 2020年7月8日 15:19 > 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; > will@kernel.org > 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > steve.capper@arm.com; rppt@linux.ibm.com; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei > <sujunfei2@hisilicon.com> > 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory > model that define VMEMMAP > > > > > -----Original Message----- > > From: liwei (CM) > > Sent: Wednesday, July 8, 2020 1:56 PM > > To: catalin.marinas@arm.com; will@kernel.org > > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng > > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) > > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com> > > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory > model > > that define VMEMMAP > > > > For the memory hole, sparse memory model that define > SPARSEMEM_VMEMMAP > > do not free the reserved memory for the page map, this patch do it. > > Hello Wei, > Just curious if this patch breaks MEMORY_HOTPLUG? > > > > > Signed-off-by: Wei Li <liwei213@huawei.com> > > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > > --- > > arch/arm64/mm/init.c | 81 > > +++++++++++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 71 insertions(+), 10 deletions(-) > > > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index > > 1e93cfc7c47a..d1b56b47d5ba 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -441,7 +441,48 @@ void __init bootmem_init(void) > > memblock_dump_all(); > > } > > > > Thanks > Barry ^ permalink raw reply [flat|nested] 13+ messages in thread
* 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-09 12:27 ` Song Bao Hua (Barry Song) @ 2020-07-21 1:56 ` liwei (CM) 2020-07-21 6:35 ` Mike Rapoport 0 siblings, 1 reply; 13+ messages in thread From: liwei (CM) @ 2020-07-21 1:56 UTC (permalink / raw) To: Song Bao Hua (Barry Song), catalin.marinas, will Cc: fengbaopeng, nsaenzjulienne, steve.capper, rppt, linux-arm-kernel, linux-kernel, sujunfei, Xiaqing (A), Yaobaofeng (Yaobaofeng) Hi, all I'm sorry to bother you, but still very hope you can give comments or suggestions to this patch, thank you very much. -----邮件原件----- 发件人: Song Bao Hua (Barry Song) 发送时间: 2020年7月9日 20:27 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com> 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP > -----Original Message----- > From: liwei (CM) > Sent: Wednesday, July 8, 2020 7:52 PM > To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; > catalin.marinas@arm.com; will@kernel.org > Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > steve.capper@arm.com; rppt@linux.ibm.com; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) > <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) > <yaobaofeng@huawei.com> > Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory > model that define VMEMMAP > > Hi, baohua > > Thank you for your attention. > > In my understanding of the MEMORY_HOTPLUG this patch has no effect on it. > The reason is that in sparse_add_one_section() the memory that memmap > needs from Slab if kernel start completed，this memory has nothing to > do with memblock alloc/ free memory in the process of kernel start. > > You may have a look vmemmap_alloc_block () this function. > > If I don't understand right welcome pointed out in a timely manner. At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory. If you confirm this won't happen, please ignore my noise. BTW, next time, bear in mind that top-post is not a good way to reply mail :-) > > Thanks! > > > -----邮件原件----- > 发件人: Song Bao Hua (Barry Song) > 发送时间: 2020年7月8日 15:19 > 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; > will@kernel.org > 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > steve.capper@arm.com; rppt@linux.ibm.com; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > sujunfei <sujunfei2@hisilicon.com> > 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model > that define VMEMMAP > > > > > -----Original Message----- > > From: liwei (CM) > > Sent: Wednesday, July 8, 2020 1:56 PM > > To: catalin.marinas@arm.com; will@kernel.org > > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng > > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) > > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com> > > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory > model > > that define VMEMMAP > > > > For the memory hole, sparse memory model that define > SPARSEMEM_VMEMMAP > > do not free the reserved memory for the page map, this patch do it. > > Hello Wei, > Just curious if this patch breaks MEMORY_HOTPLUG? > > > > > Signed-off-by: Wei Li <liwei213@huawei.com> > > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > > --- > > arch/arm64/mm/init.c | 81 > > +++++++++++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 71 insertions(+), 10 deletions(-) > > > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index > > 1e93cfc7c47a..d1b56b47d5ba 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -441,7 +441,48 @@ void __init bootmem_init(void) > > memblock_dump_all(); > > } > > > > Thanks > Barry ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP 2020-07-21 1:56 ` 答复: " liwei (CM) @ 2020-07-21 6:35 ` Mike Rapoport 0 siblings, 0 replies; 13+ messages in thread From: Mike Rapoport @ 2020-07-21 6:35 UTC (permalink / raw) To: liwei (CM) Cc: Song Bao Hua (Barry Song), catalin.marinas, will, fengbaopeng, nsaenzjulienne, steve.capper, linux-arm-kernel, linux-kernel, sujunfei, Xiaqing (A), Yaobaofeng (Yaobaofeng) Hi, On Tue, Jul 21, 2020 at 01:56:33AM +0000, liwei (CM) wrote: > Hi, all > > I'm sorry to bother you, but still very hope you can give comments or suggestions to this patch, thank you very much. I cannot find your patch neither in Inbox nor in the public archives. Can you resend it please? > -----邮件原件----- > 发件人: Song Bao Hua (Barry Song) > 发送时间: 2020年7月9日 20:27 > 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; will@kernel.org > 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; steve.capper@arm.com; rppt@linux.ibm.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) <yaobaofeng@huawei.com> > 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP > > > > > -----Original Message----- > > From: liwei (CM) > > Sent: Wednesday, July 8, 2020 7:52 PM > > To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; > > catalin.marinas@arm.com; will@kernel.org > > Cc: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > > steve.capper@arm.com; rppt@linux.ibm.com; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > sujunfei <sujunfei2@hisilicon.com>; Xiaqing (A) > > <saberlily.xia@hisilicon.com>; Yaobaofeng (Yaobaofeng) > > <yaobaofeng@huawei.com> > > Subject: 答复: [PATCH] arm64: mm: free unused memmap for sparse memory > > model that define VMEMMAP > > > > Hi, baohua > > > > Thank you for your attention. > > > > In my understanding of the MEMORY_HOTPLUG this patch has no effect on it. > > The reason is that in sparse_add_one_section() the memory that memmap > > needs from Slab if kernel start completed，this memory has nothing to > > do with memblock alloc/ free memory in the process of kernel start. > > > > You may have a look vmemmap_alloc_block () this function. > > > > If I don't understand right welcome pointed out in a timely manner. > > At the first glance of this patch, I suspect that this bootmem may be used by hot-added memory. > If you confirm this won't happen, please ignore my noise. > > BTW, next time, bear in mind that top-post is not a good way to reply mail :-) > > > > > Thanks! > > > > > > -----邮件原件----- > > 发件人: Song Bao Hua (Barry Song) > > 发送时间: 2020年7月8日 15:19 > > 收件人: liwei (CM) <liwei213@huawei.com>; catalin.marinas@arm.com; > > will@kernel.org > > 抄送: fengbaopeng <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > > steve.capper@arm.com; rppt@linux.ibm.com; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > sujunfei <sujunfei2@hisilicon.com> > > 主题: RE: [PATCH] arm64: mm: free unused memmap for sparse memory model > > that define VMEMMAP > > > > > > > > > -----Original Message----- > > > From: liwei (CM) > > > Sent: Wednesday, July 8, 2020 1:56 PM > > > To: catalin.marinas@arm.com; will@kernel.org > > > Cc: liwei (CM) <liwei213@huawei.com>; fengbaopeng > > > <fengbaopeng2@hisilicon.com>; nsaenzjulienne@suse.de; > > > steve.capper@arm.com; rppt@linux.ibm.com; Song Bao Hua (Barry Song) > > > <song.bao.hua@hisilicon.com>; linux-arm-kernel@lists.infradead.org; > > > linux-kernel@vger.kernel.org; sujunfei <sujunfei2@hisilicon.com> > > > Subject: [PATCH] arm64: mm: free unused memmap for sparse memory > > model > > > that define VMEMMAP > > > > > > For the memory hole, sparse memory model that define > > SPARSEMEM_VMEMMAP > > > do not free the reserved memory for the page map, this patch do it. > > > > Hello Wei, > > Just curious if this patch breaks MEMORY_HOTPLUG? > > > > > > > > Signed-off-by: Wei Li <liwei213@huawei.com> > > > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > > > Signed-off-by: Xia Qing <saberlily.xia@hisilicon.com> > > > --- > > > arch/arm64/mm/init.c | 81 > > > +++++++++++++++++++++++++++++++++++++++++++++------- > > > 1 file changed, 71 insertions(+), 10 deletions(-) > > > > > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index > > > 1e93cfc7c47a..d1b56b47d5ba 100644 > > > --- a/arch/arm64/mm/init.c > > > +++ b/arch/arm64/mm/init.c > > > @@ -441,7 +441,48 @@ void __init bootmem_init(void) > > > memblock_dump_all(); > > > } > > > > > > > Thanks > > Barry > -- Sincerely yours, Mike. ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-07-24 3:40 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 7:32 [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP Wei Li
2020-07-22 6:07 ` Mike Rapoport
2020-07-22 8:41 ` 答复: " liwei (CM)
2020-07-22 12:49 ` Catalin Marinas
2020-07-22 13:40 ` 答复: " liwei (CM)
2020-07-23 11:29 ` Catalin Marinas
2020-07-23 13:18 ` Mike Rapoport
2020-07-24 3:40 ` 答复: " liwei (CM)
2020-07-23 2:33 ` Anshuman Khandual
2020-07-23 3:28 ` 答复: " liwei (CM)
[not found] <20200708015555.14946-1-liwei213@huawei.com>
2020-07-08 7:18 ` Song Bao Hua (Barry Song)
2020-07-08 7:51 ` 答复: " liwei (CM)
2020-07-09 12:27 ` Song Bao Hua (Barry Song)
2020-07-21 1:56 ` 答复: " liwei (CM)
2020-07-21 6:35 ` Mike Rapoport
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).