* [PATCH] fbcon: mark dummy functions 'inline'
@ 2017-08-02 9:38 ` Arnd Bergmann
2017-08-02 10:02 ` Daniel Vetter
2017-08-07 15:11 ` Bartlomiej Zolnierkiewicz
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-08-02 9:38 UTC (permalink / raw)
To: Daniel Vetter, Bartlomiej Zolnierkiewicz
Cc: Arnd Bergmann, Sean Paul, linux-kernel
The newly introduced fb_console_init/exit declarations have a
dummy alternative that is marked 'static' in the header but not
inline, leading to a warning whenever the header gets included:
In file included from drivers/video/fbdev/core/fbmem.c:35:0:
include/linux/fbcon.h:9:13: error: 'fb_console_exit' defined but not used [-Werror=unused-function]
This adds the intended 'inline'.
Fixes: 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/linux/fbcon.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h
index 0fac6305d51c..f68a7db14165 100644
--- a/include/linux/fbcon.h
+++ b/include/linux/fbcon.h
@@ -5,8 +5,8 @@
void __init fb_console_init(void);
void __exit fb_console_exit(void);
#else
-static void fb_console_init(void) {}
-static void fb_console_exit(void) {}
+static inline void fb_console_init(void) {}
+static inline void fb_console_exit(void) {}
#endif
#endif /* _LINUX_FBCON_H */
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fbcon: mark dummy functions 'inline'
2017-08-02 9:38 ` [PATCH] fbcon: mark dummy functions 'inline' Arnd Bergmann
@ 2017-08-02 10:02 ` Daniel Vetter
2017-08-07 15:11 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2017-08-02 10:02 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bartlomiej Zolnierkiewicz, Sean Paul, Linux Kernel Mailing List
On Wed, Aug 2, 2017 at 11:38 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly introduced fb_console_init/exit declarations have a
> dummy alternative that is marked 'static' in the header but not
> inline, leading to a warning whenever the header gets included:
>
> In file included from drivers/video/fbdev/core/fbmem.c:35:0:
> include/linux/fbcon.h:9:13: error: 'fb_console_exit' defined but not used [-Werror=unused-function]
>
> This adds the intended 'inline'.
>
> Fixes: 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> include/linux/fbcon.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h
> index 0fac6305d51c..f68a7db14165 100644
> --- a/include/linux/fbcon.h
> +++ b/include/linux/fbcon.h
> @@ -5,8 +5,8 @@
> void __init fb_console_init(void);
> void __exit fb_console_exit(void);
> #else
> -static void fb_console_init(void) {}
> -static void fb_console_exit(void) {}
> +static inline void fb_console_init(void) {}
> +static inline void fb_console_exit(void) {}
> #endif
>
> #endif /* _LINUX_FBCON_H */
> --
> 2.9.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fbcon: mark dummy functions 'inline'
2017-08-02 9:38 ` [PATCH] fbcon: mark dummy functions 'inline' Arnd Bergmann
2017-08-02 10:02 ` Daniel Vetter
@ 2017-08-07 15:11 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-07 15:11 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Daniel Vetter, Sean Paul, linux-kernel
On Wednesday, August 02, 2017 11:38:07 AM Arnd Bergmann wrote:
> The newly introduced fb_console_init/exit declarations have a
> dummy alternative that is marked 'static' in the header but not
> inline, leading to a warning whenever the header gets included:
>
> In file included from drivers/video/fbdev/core/fbmem.c:35:0:
> include/linux/fbcon.h:9:13: error: 'fb_console_exit' defined but not used [-Werror=unused-function]
>
> This adds the intended 'inline'.
>
> Fixes: 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-07 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170802093851epcas3p174be8da865110e7586d3f51da22fba51@epcas3p1.samsung.com>
2017-08-02 9:38 ` [PATCH] fbcon: mark dummy functions 'inline' Arnd Bergmann
2017-08-02 10:02 ` Daniel Vetter
2017-08-07 15:11 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).