From: wangxi <wangxi11@huawei.com>
To: Jason Gunthorpe <jgg@mellanox.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Doug Ledford <dledford@redhat.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lijun Ou <oulijun@huawei.com>
Subject: Re: linux-next: build failure after merge of the rdma tree
Date: Thu, 4 Jul 2019 12:10:57 +0800 [thread overview]
Message-ID: <1976b003-ed63-2638-b7d2-3d8847b960f8@huawei.com> (raw)
In-Reply-To: <df072872-d0c3-a030-2237-d275f1147106@huawei.com>
在 2019/7/4 12:07, wangxi 写道:
>
>
> 在 2019/7/4 10:04, Jason Gunthorpe 写道:
>> On Thu, Jul 04, 2019 at 12:02:35PM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> On Mon, 1 Jul 2019 14:14:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> After merging the rdma tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
>>>> see include/linux/module.h for more information
>>> .
>>> .
>>> .
>>>> ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
>>> .
>>> .
>>> .
>>>> ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
>>>>
>>>> Presumably caused by commit
>>>>
>>>> e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")
>>>>
>>>> I have used the rdma tree from next-20190628 for today.
>>>
>>> I am still getting these errors/warnings.
>>
>> I have not got a fixing patch from HNS team.
>>
>> At this late date I will revert the problematic HNS patch tomorrow.
>> There is indeed a mistake, I will append a patch as soon as possible.
>
> The patch sent before has a problem caused by the merge of the local code. The correct one
> should be as follows :
>
> diff --git a/drivers/infiniband/hw/hns/Makefile b/drivers/infiniband/hw/hns/Makefile
> index b956cf4..b06125f 100644
> --- a/drivers/infiniband/hw/hns/Makefile
> +++ b/drivers/infiniband/hw/hns/Makefile
> @@ -9,8 +9,8 @@ hns-roce-objs := hns_roce_main.o hns_roce_cmd.o hns_roce_pd.o \
> hns_roce_cq.o hns_roce_alloc.o hns_roce_db.o hns_roce_srq.o hns_roce_restrack.o
>
> ifdef CONFIG_INFINIBAND_HNS_HIP06
> -hns-roce-hw-v1-objs := hns_roce_hw_v1.o
> -obj-$(CONFIG_INFINIBAND_HNS) += hns-roce-hw-v1.o $(hns-roce-objs)
> +hns-roce-hw-v1-objs := hns_roce_hw_v1.o $(hns-roce-objs)
> +obj-$(CONFIG_INFINIBAND_HNS) += hns-roce-hw-v1.o
> endif
>
The old patch does have an error and I will append a new patch as soon as possible.
>> Jason
>> .
>>
next prev parent reply other threads:[~2019-07-04 4:11 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 4:14 linux-next: build failure after merge of the rdma tree Stephen Rothwell
2019-07-01 7:54 ` wangxi
2019-07-01 22:49 ` Jason Gunthorpe
2019-07-04 2:02 ` Stephen Rothwell
2019-07-04 2:04 ` Jason Gunthorpe
2019-07-04 2:10 ` oulijun
2019-07-04 4:07 ` wangxi
2019-07-04 4:10 ` wangxi [this message]
2019-07-04 6:31 ` oulijun
2019-07-05 13:15 ` Jason Gunthorpe
2019-07-05 14:59 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-02-26 2:51 Stephen Rothwell
2020-02-26 3:04 ` Devesh Sharma
2020-02-26 17:25 ` Jason Gunthorpe
2019-07-09 3:30 Stephen Rothwell
2019-07-09 7:04 ` Mark Zhang
2019-07-09 7:18 ` Leon Romanovsky
2019-07-09 12:43 ` Stephen Rothwell
2019-07-09 13:11 ` Leon Romanovsky
2019-07-09 12:46 ` Jason Gunthorpe
2019-07-10 1:04 ` Stephen Rothwell
2019-07-10 4:30 ` Stephen Rothwell
2019-07-16 23:28 ` Stephen Rothwell
2019-07-17 6:33 ` Masahiro Yamada
2019-07-17 7:45 ` Stephen Rothwell
2019-07-08 3:03 Stephen Rothwell
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08 2:57 Stephen Rothwell
2019-07-08 16:08 ` Jason Gunthorpe
2019-07-09 3:11 ` Stephen Rothwell
2019-07-25 18:32 ` Dennis Dalessandro
2018-12-04 0:47 Stephen Rothwell
2018-12-04 1:52 ` Jason Gunthorpe
2018-12-04 9:42 ` Leon Romanovsky
2018-12-07 2:41 ` Stephen Rothwell
2018-12-05 12:25 ` Guy Levi(SW)
2018-12-05 22:58 ` Stephen Rothwell
2018-12-10 0:43 ` Changbin Du
2018-12-10 15:52 ` Masahiro Yamada
2018-01-25 7:22 Stephen Rothwell
2018-01-25 8:50 ` Leon Romanovsky
2018-01-25 16:08 ` Doug Ledford
2017-07-31 2:07 Stephen Rothwell
2017-04-21 1:42 Stephen Rothwell
2017-04-21 1:58 ` Joe Perches
2017-04-21 2:21 ` Doug Ledford
2017-04-21 2:23 ` Stephen Rothwell
2017-04-21 2:21 ` Stephen Rothwell
2017-02-15 0:30 Stephen Rothwell
2017-02-15 1:05 ` Doug Ledford
2017-02-15 5:09 ` Selvin Xavier
2016-09-27 1:23 Stephen Rothwell
2016-09-27 5:04 ` Christoph Hellwig
2016-09-27 5:48 ` Stephen Rothwell
2016-09-27 13:39 ` Christoph Hellwig
2016-09-27 17:15 ` Doug Ledford
2016-09-28 1:43 ` Stephen Rothwell
2016-09-28 15:00 ` Doug Ledford
2016-09-28 15:23 ` Greg KH
2016-09-28 15:26 ` Doug Ledford
2016-09-28 21:45 ` Stephen Rothwell
2016-03-16 1:15 Stephen Rothwell
2016-03-16 6:49 ` Herbert Xu
2016-03-16 19:02 ` Doug Ledford
2016-03-16 20:41 ` Stephen Rothwell
2016-03-16 22:14 ` Ismail, Mustafa
2016-01-13 1:35 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976b003-ed63-2638-b7d2-3d8847b960f8@huawei.com \
--to=wangxi11@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).