From: Doug Ledford <dledford@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Chan <michael.chan@broadcom.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Eddie Wai <eddie.wai@broadcom.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: linux-next: build failure after merge of the rdma tree
Date: Tue, 14 Feb 2017 20:05:55 -0500 [thread overview]
Message-ID: <ad8c1dc5-9d96-b45f-fe89-115ea4d0174c@redhat.com> (raw)
In-Reply-To: <20170215113003.4c730d86@canb.auug.org.au>
[-- Attachment #1.1: Type: text/plain, Size: 3198 bytes --]
On 2/14/2017 7:30 PM, Stephen Rothwell wrote:
> Hi Doug,
>
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_free':
> drivers/infiniband/hw/bnxt_re/main.c:231:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
> req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
> ^
> drivers/infiniband/hw/bnxt_re/main.c:231:18: note: each undeclared identifier is reported only once for each function it appears in
> drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_alloc':
> drivers/infiniband/hw/bnxt_re/main.c:271:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
> req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
> ^
>
> Caused by commit
>
> 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
>
> interacting with commit
>
> bac9a7e0f5d6 ("bnxt_en: Update to firmware interface spec 1.7.0.")
>
> from the net-next tree.
>
> I added this merge fix patch:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 15 Feb 2017 11:23:25 +1100
> Subject: [PATCH] RDMA/bnxt_re: fix for "bnxt_en: Update to firmware interface spec 1.7.0."
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Thanks Stephen. I had been forewarned about this by Selvin and I
instructed him to send me a fixup patch that would resolve the issue. I
would apply it to my tree before merging with Linus. He just hadn't
time to send it yet. Your patch is sufficient as well, so I may just
pull it in. Thanks again.
> ---
> drivers/infiniband/hw/bnxt_re/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index 6b9f1178050f..bd452a92b386 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -228,7 +228,7 @@ static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, u16 fw_ring_id,
> }
>
> bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_FREE, -1, -1);
> - req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
> + req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
> req.ring_id = cpu_to_le16(fw_ring_id);
> bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
> sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
> @@ -268,7 +268,7 @@ static int bnxt_re_net_ring_alloc(struct bnxt_re_dev *rdev, dma_addr_t *dma_arr,
> /* Association of ring index with doorbell index and MSIX number */
> req.logical_id = cpu_to_le16(map_index);
> req.length = cpu_to_le32(ring_mask + 1);
> - req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
> + req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
> req.int_mode = RING_ALLOC_REQ_INT_MODE_MSIX;
> bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
> sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
>
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
next prev parent reply other threads:[~2017-02-15 1:06 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 0:30 linux-next: build failure after merge of the rdma tree Stephen Rothwell
2017-02-15 1:05 ` Doug Ledford [this message]
2017-02-15 5:09 ` Selvin Xavier
-- strict thread matches above, loose matches on Subject: below --
2020-02-26 2:51 Stephen Rothwell
2020-02-26 3:04 ` Devesh Sharma
2020-02-26 17:25 ` Jason Gunthorpe
2019-07-09 3:30 Stephen Rothwell
2019-07-09 7:04 ` Mark Zhang
2019-07-09 7:18 ` Leon Romanovsky
2019-07-09 12:43 ` Stephen Rothwell
2019-07-09 13:11 ` Leon Romanovsky
2019-07-09 12:46 ` Jason Gunthorpe
2019-07-10 1:04 ` Stephen Rothwell
2019-07-10 4:30 ` Stephen Rothwell
2019-07-16 23:28 ` Stephen Rothwell
2019-07-17 6:33 ` Masahiro Yamada
2019-07-17 7:45 ` Stephen Rothwell
2019-07-08 3:03 Stephen Rothwell
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08 2:57 Stephen Rothwell
2019-07-08 16:08 ` Jason Gunthorpe
2019-07-09 3:11 ` Stephen Rothwell
2019-07-25 18:32 ` Dennis Dalessandro
2019-07-01 4:14 Stephen Rothwell
2019-07-01 7:54 ` wangxi
2019-07-01 22:49 ` Jason Gunthorpe
2019-07-04 2:02 ` Stephen Rothwell
2019-07-04 2:04 ` Jason Gunthorpe
2019-07-04 2:10 ` oulijun
2019-07-04 4:07 ` wangxi
2019-07-04 4:10 ` wangxi
2019-07-04 6:31 ` oulijun
2019-07-05 13:15 ` Jason Gunthorpe
2019-07-05 14:59 ` Stephen Rothwell
2018-12-04 0:47 Stephen Rothwell
2018-12-04 1:52 ` Jason Gunthorpe
2018-12-04 9:42 ` Leon Romanovsky
2018-12-07 2:41 ` Stephen Rothwell
2018-12-05 12:25 ` Guy Levi(SW)
2018-12-05 22:58 ` Stephen Rothwell
2018-12-10 0:43 ` Changbin Du
2018-12-10 15:52 ` Masahiro Yamada
2018-01-25 7:22 Stephen Rothwell
2018-01-25 8:50 ` Leon Romanovsky
2018-01-25 16:08 ` Doug Ledford
2017-07-31 2:07 Stephen Rothwell
2017-04-21 1:42 Stephen Rothwell
2017-04-21 1:58 ` Joe Perches
2017-04-21 2:21 ` Doug Ledford
2017-04-21 2:23 ` Stephen Rothwell
2017-04-21 2:21 ` Stephen Rothwell
2016-09-27 1:23 Stephen Rothwell
2016-09-27 5:04 ` Christoph Hellwig
2016-09-27 5:48 ` Stephen Rothwell
2016-09-27 13:39 ` Christoph Hellwig
2016-09-27 17:15 ` Doug Ledford
2016-09-28 1:43 ` Stephen Rothwell
2016-09-28 15:00 ` Doug Ledford
2016-09-28 15:23 ` Greg KH
2016-09-28 15:26 ` Doug Ledford
2016-09-28 21:45 ` Stephen Rothwell
2016-03-16 1:15 Stephen Rothwell
2016-03-16 6:49 ` Herbert Xu
2016-03-16 19:02 ` Doug Ledford
2016-03-16 20:41 ` Stephen Rothwell
2016-03-16 22:14 ` Ismail, Mustafa
2016-01-13 1:35 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad8c1dc5-9d96-b45f-fe89-115ea4d0174c@redhat.com \
--to=dledford@redhat.com \
--cc=davem@davemloft.net \
--cc=devesh.sharma@broadcom.com \
--cc=eddie.wai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=sfr@canb.auug.org.au \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).