Re: [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver

From: "Nuno Sá" <noname.nuno@gmail.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	 "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"jdelvare@suse.com" <jdelvare@suse.com>,
	 "linux@roeck-us.net" <linux@roeck-us.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	 "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver
Date: Fri, 26 Jan 2024 08:51:39 +0100	[thread overview]
Message-ID: <1b42866bb6f05b7d68e9b8304e42359fccdf2bad.camel@gmail.com> (raw)
In-Reply-To: <147c92f9-b42b-4a51-a6f9-2d90bfe63aa0@alliedtelesis.co.nz>

On Fri, 2024-01-26 at 02:22 +0000, Chris Packham wrote:
> Hi All,
> 
> On 4/04/23 03:43, Ibrahim Tilki wrote:
> > changelog:
> > since v5:
> >    - dt-binding: add enum value "2" to aux-voltage-chargable
> >    - dt-binding: remove adi,trickle-diode-enable
> >    - dt-binding: change description of trickle-resistor-ohms
> >    - dt-binding: reorder as in example schema
> >    - parse "wakeup-source" when irq not requested
> >    - remove limitation on max31328 irq and clokout
> >    - remove error and warning messages during trickle charger setup
> > 
> > since v4:
> >    - dt-binding: remove interrupt names.
> >    - dt-binding: add description for "interrupts" property
> >    - dt-binding: replace deprecated property "trickle-diode-disable"
> >        by "aux-voltage-chargeable"
> >    - dt-binding: add new property "adi,trickle-diode-enable"
> >    - dt-binding: remove "wakeup-source"
> >    - use clear_bit instead of __clear_bit
> >    - use devm_of_clk_add_hw_provider instead of of_clk_add_provider
> >    - use chip_desc pointer as driver data instead of enum.
> > 
> > since v3:
> >    - add "break" to fix warning: unannotated fall-through
> >      Reported-by: kernel test robot <lkp@intel.com>
> > 
> > since v2:
> >    - dt-binding: update title and description
> >    - dt-binding: remove last example
> >    - drop watchdog support
> >    - support reading 12Hr format instead of forcing 24hr at probe time
> >    - use "tm_year % 100" instead of range check
> >    - refactor max313xx_init for readability
> > 
> > Ibrahim Tilki (2):
> >    drivers: rtc: add max313xx series rtc driver
> >    dt-bindings: rtc: add max313xx RTCs
> > 
> >   .../devicetree/bindings/rtc/adi,max313xx.yaml |  144 +++
> >   drivers/rtc/Kconfig                           |   11 +
> >   drivers/rtc/Makefile                          |    1 +
> >   drivers/rtc/rtc-max313xx.c                    | 1053 +++++++++++++++++
> >   4 files changed, 1209 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> >   create mode 100644 drivers/rtc/rtc-max313xx.c
> 
> What happened to this series in the end? It kind of went off my radar 
> and I forgot about it.
> 
> We've been carrying a version of these changes in our local tree for a 
> while (and using it quite happily I should add).
> 

Hi Chris,

Also not sure.... In the meantime Ibrahim left ADI so if this is not in shape to
be merged he won't be able to re-spin. If there's a need for a re-spin, please
let me know so I can see internally if there's someone who can continue this
work. I would do it myself if I had the HW.

- Nuno Sá