From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
a.zummo@towertech.it, jdelvare@suse.com, linux@roeck-us.net,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs
Date: Tue, 4 Apr 2023 09:44:46 +0200 [thread overview]
Message-ID: <2023040407444619bf5596@mail.local> (raw)
In-Reply-To: <996b49ab-5e2e-76bc-efb1-38c6384871f6@linaro.org>
On 04/04/2023 09:21:56+0200, Krzysztof Kozlowski wrote:
> On 04/04/2023 09:10, Alexandre Belloni wrote:
> >>
> >>> + RTC can be used as a clock source through its clock output pin when
> >>> + supplied.
> >>> + const: 0
> >>> +
> >>> + clocks:
> >>> + description: |
> >>
> >> Do not need '|'.
> >>
> >>> + RTC uses this clock for clock input when supplied. Clock has to provide
> >>> + one of these four frequencies: 1Hz, 50Hz, 60Hz or 32.768kHz.
> >>> + maxItems: 1
> >>> +
> >>> + aux-voltage-chargeable:
> >>> + enum: [0, 1, 2]
> >>> + description: |
> >>> + Enables trickle charger.
> >>> + 0: Charger is disabled (default)
> >>> + 1: Charger is enabled
> >>> + 2: Charger is enabled with a diode
> >>
> >> 2 is not an allowed value. I asked to drop this property. It is coming
> >> from rtc.yaml. I also do not understand "with a diode". So otherwise it
> >> is charging with, I don't know, FET?
> >
> > No, what is not explained here (and maybe not unsterstood by the
> > submitter) is that the RTC has an extra diode so,
>
> Value of 2 is still not allowed and if the patch was tested, it would be
> clearly visible. Unfortunately patch was not tested...
>
> > charging will always
> > enable a diode, select a resistor and then have or not an extra diode.
> > Figure2 of the MAX31329 datasheet is great.
>
> So the diode is in the max313xx? Then why enabling it is a property of
> DT? Either this should be inferred from compatible or is even a policy,
> not a DT property. Just because device has a register for something, is
> not an argument that "something" should be in DT.
Well, it depends on the battery that is installed on the board so it
makes sense to have it in DT.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-04-04 7:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 15:43 [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Ibrahim Tilki
2023-04-03 15:43 ` [PATCH v5 1/2] " Ibrahim Tilki
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-23 22:52 ` Chris Packham
2023-04-23 23:27 ` Chris Packham
2023-04-03 15:43 ` [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Ibrahim Tilki
2023-04-04 6:17 ` Krzysztof Kozlowski
2023-04-04 7:10 ` Alexandre Belloni
2023-04-04 7:21 ` Krzysztof Kozlowski
2023-04-04 7:44 ` Alexandre Belloni [this message]
2023-04-04 8:14 ` Krzysztof Kozlowski
2023-04-04 9:32 ` Tilki, Ibrahim
2023-04-04 9:56 ` Alexandre Belloni
2023-04-04 10:06 ` Krzysztof Kozlowski
2023-04-04 12:18 ` Alexandre Belloni
2023-04-04 9:26 ` Tilki, Ibrahim
2023-04-04 10:08 ` Krzysztof Kozlowski
2023-04-04 10:35 ` Tilki, Ibrahim
2023-04-04 12:26 ` Alexandre Belloni
2023-04-04 12:29 ` Alexandre Belloni
2023-04-04 13:02 ` Krzysztof Kozlowski
2023-04-04 14:50 ` Tilki, Ibrahim
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-04 15:40 ` Tilki, Ibrahim
2023-04-05 6:16 ` Krzysztof Kozlowski
2024-01-26 2:22 ` [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-01-26 7:51 ` Nuno Sá
2024-01-29 3:28 ` Chris Packham
2024-01-29 7:55 ` Nuno Sá
2024-02-02 0:28 ` Chris Packham
2024-02-02 6:56 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040407444619bf5596@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).