From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "Nuno Sá" <noname.nuno@gmail.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"antoniu.miclaus@analog.com" <antoniu.miclaus@analog.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver
Date: Fri, 2 Feb 2024 00:28:52 +0000 [thread overview]
Message-ID: <c69ab341-468a-4bca-96b7-793342c421a7@alliedtelesis.co.nz> (raw)
In-Reply-To: <84827fd6461c9650443608e33afe9eb011793656.camel@gmail.com>
On 29/01/24 20:55, Nuno Sá wrote:
> On Mon, 2024-01-29 at 03:28 +0000, Chris Packham wrote:
>> On 26/01/24 20:51, Nuno Sá wrote:
>>> On Fri, 2024-01-26 at 02:22 +0000, Chris Packham wrote:
>>>> Hi All,
>>>>
>>>> On 4/04/23 03:43, Ibrahim Tilki wrote:
>>>>> changelog:
>>>>> since v5:
>>>>> - dt-binding: add enum value "2" to aux-voltage-chargable
>>>>> - dt-binding: remove adi,trickle-diode-enable
>>>>> - dt-binding: change description of trickle-resistor-ohms
>>>>> - dt-binding: reorder as in example schema
>>>>> - parse "wakeup-source" when irq not requested
>>>>> - remove limitation on max31328 irq and clokout
>>>>> - remove error and warning messages during trickle charger setup
>>>>>
>>>>> since v4:
>>>>> - dt-binding: remove interrupt names.
>>>>> - dt-binding: add description for "interrupts" property
>>>>> - dt-binding: replace deprecated property "trickle-diode-disable"
>>>>> by "aux-voltage-chargeable"
>>>>> - dt-binding: add new property "adi,trickle-diode-enable"
>>>>> - dt-binding: remove "wakeup-source"
>>>>> - use clear_bit instead of __clear_bit
>>>>> - use devm_of_clk_add_hw_provider instead of of_clk_add_provider
>>>>> - use chip_desc pointer as driver data instead of enum.
>>>>>
>>>>> since v3:
>>>>> - add "break" to fix warning: unannotated fall-through
>>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>>
>>>>> since v2:
>>>>> - dt-binding: update title and description
>>>>> - dt-binding: remove last example
>>>>> - drop watchdog support
>>>>> - support reading 12Hr format instead of forcing 24hr at probe time
>>>>> - use "tm_year % 100" instead of range check
>>>>> - refactor max313xx_init for readability
>>>>>
>>>>> Ibrahim Tilki (2):
>>>>> drivers: rtc: add max313xx series rtc driver
>>>>> dt-bindings: rtc: add max313xx RTCs
>>>>>
>>>>> .../devicetree/bindings/rtc/adi,max313xx.yaml | 144 +++
>>>>> drivers/rtc/Kconfig | 11 +
>>>>> drivers/rtc/Makefile | 1 +
>>>>> drivers/rtc/rtc-max313xx.c | 1053
>>>>> +++++++++++++++++
>>>>> 4 files changed, 1209 insertions(+)
>>>>> create mode 100644
>>>>> Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
>>>>> create mode 100644 drivers/rtc/rtc-max313xx.c
>>>> What happened to this series in the end? It kind of went off my radar
>>>> and I forgot about it.
>>>>
>>>> We've been carrying a version of these changes in our local tree for a
>>>> while (and using it quite happily I should add).
>>>>
>>> Hi Chris,
>>>
>>> Also not sure.... In the meantime Ibrahim left ADI so if this is not in
>>> shape to
>>> be merged he won't be able to re-spin. If there's a need for a re-spin,
>>> please
>>> let me know so I can see internally if there's someone who can continue this
>>> work. I would do it myself if I had the HW.
>> I've got a board with a max31331 so I can test that. I don't have any of
>> the interrupts hooked up so I won't be able to test that. Looks like
>> there was some outstanding discussion around the trickle-charge
>> devicetree properties so I'd need to figure out what was wanted there.
>> I'll try to pick up the last series from the mailing list and go from there.
I see that in the meantime Antoniu has landed a max31335 driver. Does
anyone know off-hand how close the max31335 is to the other max313xx
variants? Should I leave them separate or attempt to integrate the two.
next prev parent reply other threads:[~2024-02-02 0:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 15:43 [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Ibrahim Tilki
2023-04-03 15:43 ` [PATCH v5 1/2] " Ibrahim Tilki
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-23 22:52 ` Chris Packham
2023-04-23 23:27 ` Chris Packham
2023-04-03 15:43 ` [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Ibrahim Tilki
2023-04-04 6:17 ` Krzysztof Kozlowski
2023-04-04 7:10 ` Alexandre Belloni
2023-04-04 7:21 ` Krzysztof Kozlowski
2023-04-04 7:44 ` Alexandre Belloni
2023-04-04 8:14 ` Krzysztof Kozlowski
2023-04-04 9:32 ` Tilki, Ibrahim
2023-04-04 9:56 ` Alexandre Belloni
2023-04-04 10:06 ` Krzysztof Kozlowski
2023-04-04 12:18 ` Alexandre Belloni
2023-04-04 9:26 ` Tilki, Ibrahim
2023-04-04 10:08 ` Krzysztof Kozlowski
2023-04-04 10:35 ` Tilki, Ibrahim
2023-04-04 12:26 ` Alexandre Belloni
2023-04-04 12:29 ` Alexandre Belloni
2023-04-04 13:02 ` Krzysztof Kozlowski
2023-04-04 14:50 ` Tilki, Ibrahim
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-04 15:40 ` Tilki, Ibrahim
2023-04-05 6:16 ` Krzysztof Kozlowski
2024-01-26 2:22 ` [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-01-26 7:51 ` Nuno Sá
2024-01-29 3:28 ` Chris Packham
2024-01-29 7:55 ` Nuno Sá
2024-02-02 0:28 ` Chris Packham [this message]
2024-02-02 6:56 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c69ab341-468a-4bca-96b7-793342c421a7@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=noname.nuno@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).