From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
a.zummo@towertech.it, jdelvare@suse.com, linux@roeck-us.net,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs
Date: Tue, 4 Apr 2023 09:10:04 +0200 [thread overview]
Message-ID: <202304040710049c9cc01a@mail.local> (raw)
In-Reply-To: <dd6f0842-519f-1bc9-f7f5-459863dc3dcd@linaro.org>
On 04/04/2023 08:17:40+0200, Krzysztof Kozlowski wrote:
> On 03/04/2023 17:43, Ibrahim Tilki wrote:
> > Devicetree binding documentation for Analog Devices MAX313XX RTCs
> >
> > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> > ---
> > .../devicetree/bindings/rtc/adi,max313xx.yaml | 144 ++++++++++++++++++
> > 1 file changed, 144 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > new file mode 100644
> > index 000000000..0c17a395e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > @@ -0,0 +1,144 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2022 Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices MAX313XX series I2C RTCs
> > +
> > +maintainers:
> > + - Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> > +
> > +description: Analog Devices MAX313XX series I2C RTCs.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,max31328
> > + - adi,max31329
> > + - adi,max31331
> > + - adi,max31334
> > + - adi,max31341
> > + - adi,max31342
> > + - adi,max31343
> > +
> > + reg:
> > + description: I2C address of the RTC
> > + items:
> > + - enum: [0x68, 0x69]
> > +
> > + interrupts:
> > + description: |
>
> Do not need '|'.
>
> > + Alarm1 interrupt line of the RTC. Some of the RTCs have two interrupt
> > + lines and alarm1 interrupt muxing depends on the clockin/clockout
> > + configuration.
> > + maxItems: 1
> > +
> > + "#clock-cells":
> > + description: |
>
> Do not need '|'.
>
> > + RTC can be used as a clock source through its clock output pin when
> > + supplied.
> > + const: 0
> > +
> > + clocks:
> > + description: |
>
> Do not need '|'.
>
> > + RTC uses this clock for clock input when supplied. Clock has to provide
> > + one of these four frequencies: 1Hz, 50Hz, 60Hz or 32.768kHz.
> > + maxItems: 1
> > +
> > + aux-voltage-chargeable:
> > + enum: [0, 1, 2]
> > + description: |
> > + Enables trickle charger.
> > + 0: Charger is disabled (default)
> > + 1: Charger is enabled
> > + 2: Charger is enabled with a diode
>
> 2 is not an allowed value. I asked to drop this property. It is coming
> from rtc.yaml. I also do not understand "with a diode". So otherwise it
> is charging with, I don't know, FET?
No, what is not explained here (and maybe not unsterstood by the
submitter) is that the RTC has an extra diode so, charging will always
enable a diode, select a resistor and then have or not an extra diode.
Figure2 of the MAX31329 datasheet is great.
>
> > +
> > + trickle-resistor-ohms:
> > + description: Selected resistor for trickle charger.
> > + enum: [3000, 6000, 11000]
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> Best regards,
> Krzysztof
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-04-04 7:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 15:43 [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Ibrahim Tilki
2023-04-03 15:43 ` [PATCH v5 1/2] " Ibrahim Tilki
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-23 22:52 ` Chris Packham
2023-04-23 23:27 ` Chris Packham
2023-04-03 15:43 ` [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Ibrahim Tilki
2023-04-04 6:17 ` Krzysztof Kozlowski
2023-04-04 7:10 ` Alexandre Belloni [this message]
2023-04-04 7:21 ` Krzysztof Kozlowski
2023-04-04 7:44 ` Alexandre Belloni
2023-04-04 8:14 ` Krzysztof Kozlowski
2023-04-04 9:32 ` Tilki, Ibrahim
2023-04-04 9:56 ` Alexandre Belloni
2023-04-04 10:06 ` Krzysztof Kozlowski
2023-04-04 12:18 ` Alexandre Belloni
2023-04-04 9:26 ` Tilki, Ibrahim
2023-04-04 10:08 ` Krzysztof Kozlowski
2023-04-04 10:35 ` Tilki, Ibrahim
2023-04-04 12:26 ` Alexandre Belloni
2023-04-04 12:29 ` Alexandre Belloni
2023-04-04 13:02 ` Krzysztof Kozlowski
2023-04-04 14:50 ` Tilki, Ibrahim
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-04 15:40 ` Tilki, Ibrahim
2023-04-05 6:16 ` Krzysztof Kozlowski
2024-01-26 2:22 ` [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-01-26 7:51 ` Nuno Sá
2024-01-29 3:28 ` Chris Packham
2024-01-29 7:55 ` Nuno Sá
2024-02-02 0:28 ` Chris Packham
2024-02-02 6:56 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304040710049c9cc01a@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).