Re: [PATCH] kill two scsi ioctls

Re: [PATCH] kill two scsi ioctls

[Andries.Brouwer]

    On Thu, Apr 10, 2003 at 06:33:26PM +0200, Andries.Brouwer@cwi.nl wrote:

    > The definition for SCSI_IOCTL_BENCHMARK_COMMAND was added in 1.1.2.
    > The definition for SCSI_IOCTL_SYNC was added in 1.1.38.
    > Neither of them has ever been used.

    Can't you at least add a comment about what was there ? It's quite
    annoying to come across :

    #define FOO 1
    #define BAR 2
    #define BAZ 5

    and have no idea why

It happens all the time. Hundreds of cases.

I prefer a short and clean actual kernel source, and long
historical explanations somewhere else, for example in
Documentation/ioctl_list.

(Michael Elizabeth Chastain made ioctl_list.2 a man page,
but nobody keeps it up-to-date. The current version is from
1.3.27. I am updating it and expect to submit it for the
Documentation directory. Maybe more people will update it there.)

Andries

Re: [PATCH] kill two scsi ioctls

[John Levon]

On Thu, Apr 10, 2003 at 07:29:11PM +0200, Andries.Brouwer@cwi.nl wrote:

> It happens all the time. Hundreds of cases.

That's obviously no excuse.

> historical explanations somewhere else, for example in
> Documentation/ioctl_list.

Fine by me.

regards
john

Re: [PATCH] kill two scsi ioctls

[John Levon]

On Thu, Apr 10, 2003 at 06:33:26PM +0200, Andries.Brouwer@cwi.nl wrote:

> The definition for SCSI_IOCTL_BENCHMARK_COMMAND was added in 1.1.2.
> The definition for SCSI_IOCTL_SYNC was added in 1.1.38.
> Neither of them has ever been used.

Can't you at least add a comment about what was there ? It's quite
annoying to come across :

#define FOO 1
#define BAR 2
#define BAZ 5

and have no idea why

regards
john

[PATCH] kill two scsi ioctls

[Andries.Brouwer]

The definition for SCSI_IOCTL_BENCHMARK_COMMAND was added in 1.1.2.
The definition for SCSI_IOCTL_SYNC was added in 1.1.38.
Neither of them has ever been used.

diff -u --recursive --new-file -X /linux/dontdiff a/include/scsi/scsi_ioctl.h b/include/scsi/scsi_ioctl.h
--- a/include/scsi/scsi_ioctl.h	Fri Nov 22 22:40:13 2002
+++ b/include/scsi/scsi_ioctl.h	Thu Apr 10 18:23:31 2003
@@ -3,8 +3,6 @@
 
 #define SCSI_IOCTL_SEND_COMMAND 1
 #define SCSI_IOCTL_TEST_UNIT_READY 2
-#define SCSI_IOCTL_BENCHMARK_COMMAND 3
-#define SCSI_IOCTL_SYNC 4			/* Request synchronous parameters */
 #define SCSI_IOCTL_START_UNIT 5
 #define SCSI_IOCTL_STOP_UNIT 6
 /* The door lock/unlock constants are compatible with Sun constants for