Re: [patch] 2.6.0-test5: serio config broken?

From: Tom Rini <trini@kernel.crashing.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Eyal Lebedinsky <eyal@eyal.emu.id.au>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	pavel@suse.cz
Subject: Re: [patch] 2.6.0-test5: serio config broken?
Date: Wed, 10 Sep 2003 11:59:02 -0700	[thread overview]
Message-ID: <20030910185902.GE4559@ip68-0-152-218.tc.ph.cox.net> (raw)
In-Reply-To: <20030910170610.GH27368@fs.tum.de>

On Wed, Sep 10, 2003 at 07:06:11PM +0200, Adrian Bunk wrote:
> On Wed, Sep 10, 2003 at 08:55:42AM -0700, Tom Rini wrote:
> >...
> > > --- linux-2.6.0-test4-mm5-modular-no-smp/drivers/input/keyboard/Kconfig.old	2003-09-04 19:03:45.000000000 +0200
> > > +++ linux-2.6.0-test4-mm5-modular-no-smp/drivers/input/keyboard/Kconfig	2003-09-04 19:04:49.000000000 +0200
> > > @@ -13,7 +13,8 @@
> > >  
> > >  config KEYBOARD_ATKBD
> > >  	tristate "AT keyboard support" if EMBEDDED || !X86 
> > > -	default y
> > > +	default y if INPUT=y && INPUT_KEYBOARD=y && SERIO=y
> > > +	default m
> > >  	depends on INPUT && INPUT_KEYBOARD && SERIO
> > >  	help
> > >  	  Say Y here if you want to use a standard AT or PS/2 keyboard. Usually
> > > --- linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig.old	2003-09-10 12:52:22.000000000 +0200
> > > +++ linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig	2003-09-10 12:52:47.000000000 +0200
> > > @@ -20,7 +20,8 @@
> > >  
> > >  config SERIO_I8042
> > >  	tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
> > > -	default y
> > > +	default y if SERIO=y
> > > +	default m
> > >  	depends on SERIO
> > >  	---help---
> > >  	  i8042 is the chip over which the standard AT keyboard and PS/2
> > 
> > A slightly better fix is for SERIO to default to Y on X86 and to
> > 'select SERIO_I8042 if X86'.  Then have INPUT_KEYBOARD similarly select
> > KEYBOARD_ATKBD.
> >...
> 
> That wouldn't be needed. AFAIK there are _no_ problems if SERIO=y, the 
> select you suggest is already implemented the other way round.

The problem is that SERIO==y means that SERIO_I8042 must be Y, as you
ran into.  If you have SERIO only asked on EMBEDDED || !X86, and on
similar conditions you then select SERIO_I8042, it just works.

> If SERIO is always y if !EMBEDDED || X86 my patch wouldn't be needed.

Correct.  I was suggesting that you do:
tristate "Serial i/o support (needed for keyboard and mouse)" if
!EMBEDDED || !X86  (or so)
select SERIO_I8042 if X86 && !EMBEDDED

and then remove the conditions on SERIO_I8042, which puts all of the
auto-select-this magic in one spot.

-- 
Tom Rini
http://gate.crashing.org/~trini/