From: walt <wa1ter@myrealbox.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: Linux 2.6.0-test5
Date: Mon, 08 Sep 2003 17:48:29 -0700 [thread overview]
Message-ID: <3F5D235D.7020604@myrealbox.com> (raw)
In-Reply-To: <3F5D0B09.1040802@pobox.com>
Jeff Garzik wrote:
> Note that people seeing "ifconfig down ... ifconfig up" problems need to
> apply this patch. (to 2.4.23-pre, too)
>
> Jeff
>
>
>
> ------------------------------------------------------------------------
>
> diff -Nru a/net/core/dev.c b/net/core/dev.c
> --- a/net/core/dev.c Mon Sep 8 18:14:36 2003
> +++ b/net/core/dev.c Mon Sep 8 18:14:36 2003
> @@ -851,7 +851,11 @@
> * engine, but this requires more changes in devices. */
>
> smp_mb__after_clear_bit(); /* Commit netif_running(). */
> - netif_poll_disable(dev);
> + while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
> + /* No hurry. */
> + current->state = TASK_INTERRUPTIBLE;
> + schedule_timeout(1);
> + }
>
> /*
> * Call the device specific close. This cannot fail.
I wrote recently:
> Okay! I'm at least back where I started. This patch doen't fix the
> ifconfig down/up problem, but it does reverse the disastrous effects
> of the last tg3 updates in both 2.6 and 2.4...
When I wrote that I didn't realize you were referring to a different
thread about ifonfig up/down instead of my long-standing bug.
My reference to the 'disastrous effects' does refer to the problem
described in the 'ifconfig up/down' thread elsewhere in the lkml
today. Sorry for the confusion. That problem seems to be fixed
by this patch. I'll keep hoping for a fix for my other tg3 bug.
next prev parent reply other threads:[~2003-09-09 0:48 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-08 20:32 Linux 2.6.0-test5 Linus Torvalds
2003-09-08 23:04 ` [PATCH] " Jeff Garzik
2003-09-09 0:32 ` walt
2003-09-09 0:48 ` walt [this message]
2003-09-09 10:35 ` Mikael Pettersson
2003-09-09 0:04 ` Linux 2.6.0-test5 (compile stats) John Cherry
2003-09-09 0:13 ` John Cherry
2003-09-09 3:44 ` Jeff Garzik
[not found] ` <1063119969.1512.1.camel@cherrypit.pdx.osdl.net>
[not found] ` <20030909155118.GA18763@gtf.org>
2003-09-16 23:44 ` John Cherry
2003-09-09 11:38 ` [2.6 patch] fix nfs4xdr.c compile warning Adrian Bunk
2003-09-12 2:40 ` Neil Brown
2003-09-12 11:11 ` Adrian Bunk
2003-09-09 11:40 ` Linux 2.6.0-test5: serio config broken? Eyal Lebedinsky
2003-09-10 11:02 ` [patch] " Adrian Bunk
2003-09-10 13:23 ` Sytse Wielinga
2003-09-10 14:01 ` Russell King
2003-09-10 14:17 ` Adrian Bunk
2003-09-10 15:55 ` Tom Rini
2003-09-10 17:06 ` Adrian Bunk
2003-09-10 18:59 ` Tom Rini
2003-09-10 19:10 ` Adrian Bunk
2003-09-10 19:31 ` Tom Rini
2003-09-10 19:55 ` Adrian Bunk
2003-09-10 21:04 ` Tom Rini
2003-09-10 21:51 ` Adrian Bunk
2003-09-10 22:05 ` Tom Rini
2003-09-10 22:17 ` Adrian Bunk
2003-09-10 22:29 ` Tom Rini
2003-09-11 8:38 ` Roman Zippel
2003-09-11 23:04 ` Tom Rini
2003-09-12 11:09 ` Adrian Bunk
2003-09-12 14:52 ` Tom Rini
2003-09-12 15:04 ` Adrian Bunk
2003-09-12 15:09 ` Tom Rini
2003-09-12 16:57 ` Roman Zippel
2003-09-09 11:47 ` Linux 2.6.0-test5: ufs build fails Eyal Lebedinsky
2003-09-09 11:50 ` Linux 2.6.0-test5: ps2esdi (CONFIG_BLK_DEV_PS2) " Eyal Lebedinsky
2003-09-09 12:06 ` Linux 2.6.0-test5: CONFIG_COSA " Eyal Lebedinsky
2003-09-09 22:48 ` [PATCH] fix build of cosa Stephen Hemminger
2003-09-11 19:26 ` Jeff Garzik
2003-09-09 12:12 ` Linux 2.6.0-test5: CONFIG_PCMCIA_WL3501 build fails Eyal Lebedinsky
2003-09-09 12:28 ` Russell King
2003-09-09 17:13 ` Linus Torvalds
2003-09-09 17:19 ` Arnaldo Carvalho de Melo
2003-09-09 23:38 ` Eyal Lebedinsky
2003-09-09 12:27 ` Linux 2.6.0-test5: CONFIG_ATM_BR2684 " Eyal Lebedinsky
2003-09-09 16:18 ` Mitchell Blank Jr
2003-09-09 19:19 ` [2.6 patch] ATM Ambassador no longer BROKEN_ON_SMP Adrian Bunk
2003-09-10 16:57 ` 2.6.0-test5: ISDN kcapi.c no longer compiles Adrian Bunk
2003-09-14 17:40 ` Karsten Keil
2003-09-15 6:57 ` Karsten Keil
2003-09-15 15:52 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F5D235D.7020604@myrealbox.com \
--to=wa1ter@myrealbox.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).