From: Adrian Bunk <bunk@fs.tum.de>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Eyal Lebedinsky <eyal@eyal.emu.id.au>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
pavel@suse.cz
Subject: Re: [patch] 2.6.0-test5: serio config broken?
Date: Wed, 10 Sep 2003 23:51:37 +0200 [thread overview]
Message-ID: <20030910215136.GP27368@fs.tum.de> (raw)
In-Reply-To: <20030910210443.GG4559@ip68-0-152-218.tc.ph.cox.net>
On Wed, Sep 10, 2003 at 02:04:43PM -0700, Tom Rini wrote:
> On Wed, Sep 10, 2003 at 09:55:44PM +0200, Adrian Bunk wrote:
> > On Wed, Sep 10, 2003 at 12:31:58PM -0700, Tom Rini wrote:
> > >...
> > > ===== drivers/input/keyboard/Kconfig 1.6 vs edited =====
> > > --- 1.6/drivers/input/keyboard/Kconfig Wed Jul 16 10:39:32 2003
> > > +++ edited/drivers/input/keyboard/Kconfig Fri Sep 5 14:45:36 2003
> > > @@ -2,8 +2,9 @@
> > > # Input core configuration
> > > #
> > > config INPUT_KEYBOARD
> > > - bool "Keyboards" if EMBEDDED || !X86
> > > + bool "Keyboards"
> > > default y
> > > + select KEYBOARD_ATKBD if STANDARD && X86
> > > depends on INPUT
> > > help
> > > Say Y here, and a list of supported keyboards will be displayed.
> > > @@ -12,7 +13,7 @@
> > > If unsure, say Y.
> > >
> > > config KEYBOARD_ATKBD
> > > - tristate "AT keyboard support" if EMBEDDED || !X86
> > > + tristate "AT keyboard support"
> > > default y
> > > depends on INPUT && INPUT_KEYBOARD && SERIO
> > > help
> > > ===== drivers/input/serio/Kconfig 1.9 vs edited =====
> > > --- 1.9/drivers/input/serio/Kconfig Wed Jul 16 10:39:32 2003
> > > +++ edited/drivers/input/serio/Kconfig Fri Sep 5 14:45:36 2003
> > > @@ -2,7 +2,8 @@
> > > # Input core configuration
> > > #
> > > config SERIO
> > > - tristate "Serial i/o support (needed for keyboard and mouse)"
> > > + tristate "Serial i/o support (needed for keyboard and mouse)" if !(STANDARD && X86)
> > > + select SERIO_I8042 if STANDARD && X86
> > > default y
> > > ---help---
> > > Say Yes here if you have any input device that uses serial I/O to
> >
> > This works but seems fragile since everyone touching the dependencies
> > must know that the tristate dependencies of SERIO must always match the
> > select dependencies in INPUT_KEYBOARD.
>
> How so? SERIO only selects SERIO_* bits, and INPUT only selects INPUT*
> (and, imho, keyboard is input :)) bits.
>...
Let's say you remove the X86 dependency in the select in INPUT_KEYBOARD.
If you select SERIO=m on !X86 (with EMBEDDED/STANDARD enabled) this will
select KEYBOARD_ATKBD=y...
> Tom Rini
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-09-10 21:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-08 20:32 Linux 2.6.0-test5 Linus Torvalds
2003-09-08 23:04 ` [PATCH] " Jeff Garzik
2003-09-09 0:32 ` walt
2003-09-09 0:48 ` walt
2003-09-09 10:35 ` Mikael Pettersson
2003-09-09 0:04 ` Linux 2.6.0-test5 (compile stats) John Cherry
2003-09-09 0:13 ` John Cherry
2003-09-09 3:44 ` Jeff Garzik
[not found] ` <1063119969.1512.1.camel@cherrypit.pdx.osdl.net>
[not found] ` <20030909155118.GA18763@gtf.org>
2003-09-16 23:44 ` John Cherry
2003-09-09 11:38 ` [2.6 patch] fix nfs4xdr.c compile warning Adrian Bunk
2003-09-12 2:40 ` Neil Brown
2003-09-12 11:11 ` Adrian Bunk
2003-09-09 11:40 ` Linux 2.6.0-test5: serio config broken? Eyal Lebedinsky
2003-09-10 11:02 ` [patch] " Adrian Bunk
2003-09-10 13:23 ` Sytse Wielinga
2003-09-10 14:01 ` Russell King
2003-09-10 14:17 ` Adrian Bunk
2003-09-10 15:55 ` Tom Rini
2003-09-10 17:06 ` Adrian Bunk
2003-09-10 18:59 ` Tom Rini
2003-09-10 19:10 ` Adrian Bunk
2003-09-10 19:31 ` Tom Rini
2003-09-10 19:55 ` Adrian Bunk
2003-09-10 21:04 ` Tom Rini
2003-09-10 21:51 ` Adrian Bunk [this message]
2003-09-10 22:05 ` Tom Rini
2003-09-10 22:17 ` Adrian Bunk
2003-09-10 22:29 ` Tom Rini
2003-09-11 8:38 ` Roman Zippel
2003-09-11 23:04 ` Tom Rini
2003-09-12 11:09 ` Adrian Bunk
2003-09-12 14:52 ` Tom Rini
2003-09-12 15:04 ` Adrian Bunk
2003-09-12 15:09 ` Tom Rini
2003-09-12 16:57 ` Roman Zippel
2003-09-09 11:47 ` Linux 2.6.0-test5: ufs build fails Eyal Lebedinsky
2003-09-09 11:50 ` Linux 2.6.0-test5: ps2esdi (CONFIG_BLK_DEV_PS2) " Eyal Lebedinsky
2003-09-09 12:06 ` Linux 2.6.0-test5: CONFIG_COSA " Eyal Lebedinsky
2003-09-09 22:48 ` [PATCH] fix build of cosa Stephen Hemminger
2003-09-11 19:26 ` Jeff Garzik
2003-09-09 12:12 ` Linux 2.6.0-test5: CONFIG_PCMCIA_WL3501 build fails Eyal Lebedinsky
2003-09-09 12:28 ` Russell King
2003-09-09 17:13 ` Linus Torvalds
2003-09-09 17:19 ` Arnaldo Carvalho de Melo
2003-09-09 23:38 ` Eyal Lebedinsky
2003-09-09 12:27 ` Linux 2.6.0-test5: CONFIG_ATM_BR2684 " Eyal Lebedinsky
2003-09-09 16:18 ` Mitchell Blank Jr
2003-09-09 19:19 ` [2.6 patch] ATM Ambassador no longer BROKEN_ON_SMP Adrian Bunk
2003-09-10 16:57 ` 2.6.0-test5: ISDN kcapi.c no longer compiles Adrian Bunk
2003-09-14 17:40 ` Karsten Keil
2003-09-15 6:57 ` Karsten Keil
2003-09-15 15:52 ` Adrian Bunk
2003-09-13 8:22 [patch] 2.6.0-test5: serio config broken? Norman Diamond
2003-09-15 14:49 ` Tom Rini
2003-09-15 21:06 ` Roman Zippel
2003-09-15 21:20 ` Tom Rini
2003-09-15 22:40 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030910215136.GP27368@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=eyal@eyal.emu.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).