blackfin compile error

blackfin compile error

[Adrian Bunk]

It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:

<--  snip  -->

...
  CC      arch/blackfin/mach-bf537/boards/stamp.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info')
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info')
make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: blackfin compile error

[Bryan Wu]

On Dec 2, 2007 8:42 AM, Adrian Bunk <bunk@kernel.org> wrote:
> It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:
>
> <--  snip  -->
>
> ...
>   CC      arch/blackfin/mach-bf537/boards/stamp.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer

Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI
header file which is in -mm tree.

David, could you please submit the Blackfin SPI update to mainline?

> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info')
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info')
> make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1
>
> <--  snip  -->
>
> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: blackfin compile error

[David Brownell]

On Saturday 01 December 2007, Bryan Wu wrote:
> On Dec 2, 2007 8:42 AM, Adrian Bunk <bunk@kernel.org> wrote:
> > It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:
> >
> > <--  snip  -->
> >
> > ...
> >   CC      arch/blackfin/mach-bf537/boards/stamp.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer
> 
> Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI
> header file which is in -mm tree.
> 
> David, could you please submit the Blackfin SPI update to mainline?

So far as I know they're all ready for Andrew to get them to Linus...


> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info')
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info')
> > make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1
> >
> > <--  snip  -->
> >
> > cu
> > Adrian
> >
> > --
> 

Re: blackfin compile error

[Andrew Morton]

On Sat, 1 Dec 2007 22:59:05 -0800 David Brownell <david-b@pacbell.net> wrote:

> On Saturday 01 December 2007, Bryan Wu wrote:
> > On Dec 2, 2007 8:42 AM, Adrian Bunk <bunk@kernel.org> wrote:
> > > It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:
> > >
> > > <--  snip  -->
> > >
> > > ...
> > >   CC      arch/blackfin/mach-bf537/boards/stamp.o
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer
> > 
> > Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI
> > header file which is in -mm tree.
> > 
> > David, could you please submit the Blackfin SPI update to mainline?
> 
> So far as I know they're all ready for Andrew to get them to Linus...
> 

I have all these:

spi-at25-driver-is-for-eeprom-not-flash.patch
spi-use-mutex-not-semaphore.patch
spi-simplify-spi_sync-calling-convention.patch
spi-use-simplified-spi_sync-calling-convention.patch
#
spi-initial-bf54x-spi-support.patch
spi-bfin-spi-uses-portmux-calls.patch
spi-spi_bfin-cleanups-error-handling.patch
spi-spi_bfin-handles-spi_transfercs_change.patch
spi-spi_bfin-dont-bypass-spi-framework.patch
spi-spi_bfin-uses-platform-device-resources.patch
spi-spi_bfin-uses-portmux-for-additional-busses.patch
spi-spi_bfin-rearrange-portmux-calls.patch
spi-spi_bfin-change-handling-of-communication-parameters.patch
spi-spi_bfin-relocate-spin-waits.patch
spi-spi_bfin-handle-multiple-spi_masters.patch
spi-spi_bfin-bugfix-for-816-bit-word-sizes.patch
spi-spi_bfin-update-handling-of-delay-after-deselect.patch
spi-spi_bfin-resequence-dma-start-stop.patch
#
blackfin-spi-driver-use-cpu_relax-to-replace-continue-in-while-busywait.patch
blackfin-spi-driver-use-void-__iomem-for-regs_base.patch
blackfin-spi-driver-move-hard-coded-pin_req-to-board-file.patch
blackfin-spi-driver-reconfigure-speed_hz-and-bits_per_word-in-each-spi-transfer.patch
atmel_spi-throughput-improvement.patch
atmel_spi-chain-dma-transfers.patch
atmel_spi-fix-dmachain-oops-with-debug-enabled.patch

queued for 2.6.25.  If some of them need to be bumped up to 2.6.24: which
ones and why?

Re: blackfin compile error

[David Brownell]

On Saturday 01 December 2007, Andrew Morton wrote:
> I have all these:
> 
> spi-at25-driver-is-for-eeprom-not-flash.patch

I'd be tempted to merge that since it's documentation-only,
and I like to see such stuff merged ASAP.  But otherwise
it's non-essential.

> spi-use-mutex-not-semaphore.patch

Non-essential.

> spi-simplify-spi_sync-calling-convention.patch
> spi-use-simplified-spi_sync-calling-convention.patch

The first one fixes some minor bugs, so would be good to merge.

The second does minor associated cleanup ... non-essential.

> #
> spi-initial-bf54x-spi-support.patch
> spi-bfin-spi-uses-portmux-calls.patch
> spi-spi_bfin-cleanups-error-handling.patch
> spi-spi_bfin-handles-spi_transfercs_change.patch
> spi-spi_bfin-dont-bypass-spi-framework.patch
> spi-spi_bfin-uses-platform-device-resources.patch
> spi-spi_bfin-uses-portmux-for-additional-busses.patch
> spi-spi_bfin-rearrange-portmux-calls.patch
> spi-spi_bfin-change-handling-of-communication-parameters.patch
> spi-spi_bfin-relocate-spin-waits.patch
> spi-spi_bfin-handle-multiple-spi_masters.patch
> spi-spi_bfin-bugfix-for-816-bit-word-sizes.patch
> spi-spi_bfin-update-handling-of-delay-after-deselect.patch
> spi-spi_bfin-resequence-dma-start-stop.patch
> #
> blackfin-spi-driver-use-cpu_relax-to-replace-continue-in-while-busywait.patch
> blackfin-spi-driver-use-void-__iomem-for-regs_base.patch
> blackfin-spi-driver-move-hard-coded-pin_req-to-board-file.patch
> blackfin-spi-driver-reconfigure-speed_hz-and-bits_per_word-in-each-spi-transfer.patch

The fix to the compile error is in the next-to-last of these.
Bryan says they're highly interdependent, and they also
include quite a number of bugfixes (some "critical") that
have been used in Analog's treee for many months now.

That makes sense to me, since they've been bouncing around
for quite a while now.  I'd be OK with merging all of them;
if something breaks, it'd be no worse than the current state
(and would only affect Blackfin).


> atmel_spi-throughput-improvement.patch
> atmel_spi-chain-dma-transfers.patch
> atmel_spi-fix-dmachain-oops-with-debug-enabled.patch

Those can wait; they're performance updates.

 
> queued for 2.6.25.  If some of them need to be bumped up to 2.6.24: which
> ones and why?

I'd say all those Blackfin patches should go, and the one
calling convention patch, are appropriate as bugfixes.
And the doc patch, unless there's a reason to hold it back.

- Dave

Re: blackfin compile error

[Mike Frysinger]

On Feb 8, 2008 1:53 PM, Bryan Wu <cooloney.lkml@gmail.com> wrote:
> On Feb 8, 2008 1:25 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> > looks like only MMU code currently uses the function, but to keep
> > things nice, we may want something like:
> > static inline int is_swap_pte(pte_t pte)
> > {
> > #ifdef CONFIG_MMU
> >     return !pte_none(pte) && !pte_present(pte) && !pte_file(pte);
> > #else
> >     return 0;
> > #endif
> > }
> >
> > the header is also lacking an #include <asm/pgtable.h> at the top ...
>
> Did you submit a patch to mainline? It should be merged to fix this
> compiling error.

posted
-mike

Re: blackfin compile error

[Bryan Wu]

On Feb 8, 2008 1:25 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
>
> On Feb 6, 2008 2:12 PM, Robin Getz <rgetz@blackfin.uclinux.org> wrote:
> > On Wed 6 Feb 2008 11:23, Matt Mackall pondered:
> > > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> > > > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
> > > >
> > > > <--  snip  -->
> > > >
> > > > ...
> > > >   CC      mm/vmscan.o
> > > > In file included from
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> > > > make[2]: *** [mm/vmscan.o] Error 1
> > >
> > > This suggests that no one's tried to compile -mm on Blackfin since
> > > before September, I think.
> >
> > Or any other nommu arch's either, since looking at the include files, FRV
> > (when configured as noMMU) and m68knommu does not include it either...
> >
> > > Is there somewhere more appropriate to move it? I can't find one.
> > > Failing that, we can wrap it in CONFIG_MMU, I suppose.
> >
> > Or just add to the the following:
> >
> > ./include/asm-blackfin
> > ./include/asm-frv/ (only when configured as !MMU)
> > ./include/asm-h8300
> > ./include/asm-m68knommu
> > ./include/asm-v850
> >
> > Others seem to have it in include/asm-xxxxx/pgtable.h as #define, inline
> > function, or extern.
>
> looks like only MMU code currently uses the function, but to keep
> things nice, we may want something like:
> static inline int is_swap_pte(pte_t pte)
> {
> #ifdef CONFIG_MMU
>     return !pte_none(pte) && !pte_present(pte) && !pte_file(pte);
> #else
>     return 0;
> #endif
> }
>
> the header is also lacking an #include <asm/pgtable.h> at the top ...
> -mike
>

Did you submit a patch to mainline? It should be merged to fix this
compiling error.

Thanks a lot
-Bryan

Re: blackfin compile error

[Mike Frysinger]

On Feb 6, 2008 2:12 PM, Robin Getz <rgetz@blackfin.uclinux.org> wrote:
> On Wed 6 Feb 2008 11:23, Matt Mackall pondered:
> > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> > > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
> > >
> > > <--  snip  -->
> > >
> > > ...
> > >   CC      mm/vmscan.o
> > > In file included from
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> > > make[2]: *** [mm/vmscan.o] Error 1
> >
> > This suggests that no one's tried to compile -mm on Blackfin since
> > before September, I think.
>
> Or any other nommu arch's either, since looking at the include files, FRV
> (when configured as noMMU) and m68knommu does not include it either...
>
> > Is there somewhere more appropriate to move it? I can't find one.
> > Failing that, we can wrap it in CONFIG_MMU, I suppose.
>
> Or just add to the the following:
>
> ./include/asm-blackfin
> ./include/asm-frv/ (only when configured as !MMU)
> ./include/asm-h8300
> ./include/asm-m68knommu
> ./include/asm-v850
>
> Others seem to have it in include/asm-xxxxx/pgtable.h as #define, inline
> function, or extern.

looks like only MMU code currently uses the function, but to keep
things nice, we may want something like:
static inline int is_swap_pte(pte_t pte)
{
#ifdef CONFIG_MMU
    return !pte_none(pte) && !pte_present(pte) && !pte_file(pte);
#else
    return 0;
#endif
}

the header is also lacking an #include <asm/pgtable.h> at the top ...
-mike

Re: blackfin compile error

[Robin Getz]

On Wed 6 Feb 2008 14:37, Andrew Morton pondered:
> On Wed, 6 Feb 2008 14:12:50 -0500
> Robin Getz <rgetz@blackfin.uclinux.org> wrote:
> 
> > On Wed 6 Feb 2008 11:23, Matt Mackall pondered:
> > > 
> > > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> > > > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
> > > > 
> > > > <--  snip  -->
> > > > 
> > > > ...
> > > >   CC      mm/vmscan.o
> > > > In file included from 
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> > > > make[2]: *** [mm/vmscan.o] Error 1
> > > 
> > > This suggests that no one's tried to compile -mm on Blackfin since
> > > before September, I think.
> > 
> > Or any other nommu arch's either, since looking at the include files,
> > FRV (when configured as noMMU) and m68knommu does not include it either...
> 
> sh is the only nommu arch which I test-compile for.
> 
> The world would be a better place if arch maintainers (or their helpers)
> were to build and test -mm once a month or so.

OK - now that we have that fixed (Mike/Bryan will do this on the mm tree and
at least fix up compile issues as soon as we notice) - how do we want to fix
this specific issue?

Add the missing entries into include/asm-xxxxx/pgtable.h or wrap the callers
in ifdefs?

-Robin

-Robin

Re: blackfin compile error

[Mike Frysinger]

On Feb 7, 2008 2:37 PM, Bryan Wu <cooloney.lkml@gmail.com> wrote:
> On Feb 8, 2008 12:03 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> > On Feb 7, 2008 2:26 AM, Bryan Wu <cooloney.lkml@gmail.com> wrote:
> > > On Feb 7, 2008 3:37 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > > The world would be a better place if arch maintainers (or their helpers)
> > > > were to build and test -mm once a month or so.
> > >
> > > I will be here for Blackfin. Actually, we got some patches in -mm, it
> > > is necessary to built and test -mm on Blackfin.
> >
> > ive setup one of our internal machines to auto build all the Blackfin
> > defconfigs found in mainline git and the mm tree
>
> Thanks a lot, it makes life easier.
>
> > just need to find a way to publish/notify people upon failure ...
>
> Maybe Grace can help to setup some cruisecontrol auto test machine
> with email notification.

i'm thinking i'll post the linux-2.6.git/blackfin-2.6.git/linux-mm
tree results to the Blackfin kernel list
-mike

Re: blackfin compile error

[Bryan Wu]

On Feb 8, 2008 12:03 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Feb 7, 2008 2:26 AM, Bryan Wu <cooloney.lkml@gmail.com> wrote:
> > On Feb 7, 2008 3:37 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > The world would be a better place if arch maintainers (or their helpers)
> > > were to build and test -mm once a month or so.
> >
> > I will be here for Blackfin. Actually, we got some patches in -mm, it
> > is necessary to built and test -mm on Blackfin.
>
> ive setup one of our internal machines to auto build all the Blackfin
> defconfigs found in mainline git and the mm tree
>

Thanks a lot, it makes life easier.

> just need to find a way to publish/notify people upon failure ...

Maybe Grace can help to setup some cruisecontrol auto test machine
with email notification.

-Bryan

Re: blackfin compile error

[Mike Frysinger]

On Feb 7, 2008 2:26 AM, Bryan Wu <cooloney.lkml@gmail.com> wrote:
> On Feb 7, 2008 3:37 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> > The world would be a better place if arch maintainers (or their helpers)
> > were to build and test -mm once a month or so.
>
> I will be here for Blackfin. Actually, we got some patches in -mm, it
> is necessary to built and test -mm on Blackfin.

ive setup one of our internal machines to auto build all the Blackfin
defconfigs found in mainline git and the mm tree

just need to find a way to publish/notify people upon failure ...
-mike

Re: blackfin compile error

[Bryan Wu]

On Feb 7, 2008 3:37 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 6 Feb 2008 14:12:50 -0500
> Robin Getz <rgetz@blackfin.uclinux.org> wrote:
>
> > On Wed 6 Feb 2008 11:23, Matt Mackall pondered:
> > >
> > > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> > > > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
> > > >
> > > > <--  snip  -->
> > > >
> > > > ...
> > > >   CC      mm/vmscan.o
> > > > In file included from
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> > > > make[2]: *** [mm/vmscan.o] Error 1
> > >
> > > This suggests that no one's tried to compile -mm on Blackfin since
> > > before September, I think.
> >
> > Or any other nommu arch's either, since looking at the include files, FRV
> > (when configured as noMMU) and m68knommu does not include it either...
>
> sh is the only nommu arch which I test-compile for.
>
> The world would be a better place if arch maintainers (or their helpers)
> were to build and test -mm once a month or so.
>

I will be here for Blackfin. Actually, we got some patches in -mm, it
is necessary to built and test -mm on Blackfin.

Thanks
-Bryan

Re: blackfin compile error

[Andrew Morton]

On Wed, 6 Feb 2008 14:12:50 -0500
Robin Getz <rgetz@blackfin.uclinux.org> wrote:

> On Wed 6 Feb 2008 11:23, Matt Mackall pondered:
> > 
> > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> > > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
> > > 
> > > <--  snip  -->
> > > 
> > > ...
> > >   CC      mm/vmscan.o
> > > In file included from 
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> > > make[2]: *** [mm/vmscan.o] Error 1
> > 
> > This suggests that no one's tried to compile -mm on Blackfin since
> > before September, I think.
> 
> Or any other nommu arch's either, since looking at the include files, FRV
> (when configured as noMMU) and m68knommu does not include it either...

sh is the only nommu arch which I test-compile for.

The world would be a better place if arch maintainers (or their helpers)
were to build and test -mm once a month or so.

Re: blackfin compile error

[Robin Getz]

On Wed 6 Feb 2008 11:23, Matt Mackall pondered:
> 
> On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      mm/vmscan.o
> > In file included from 
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> > make[2]: *** [mm/vmscan.o] Error 1
> 
> This suggests that no one's tried to compile -mm on Blackfin since
> before September, I think.

Or any other nommu arch's either, since looking at the include files, FRV
(when configured as noMMU) and m68knommu does not include it either...

> Is there somewhere more appropriate to move it? I can't find one.
> Failing that, we can wrap it in CONFIG_MMU, I suppose.

Or just add to the the following:

./include/asm-blackfin
./include/asm-frv/ (only when configured as !MMU)
./include/asm-h8300
./include/asm-m68knommu
./include/asm-v850

Others seem to have it in include/asm-xxxxx/pgtable.h as #define, inline 
function, or extern.

> Signed-off-by: Matt Mackall <mpm@selenic.com>
> 
> diff -r 50a6e531a9f2 include/linux/swapops.h
> --- a/include/linux/swapops.h	Mon Feb 04 20:23:02 2008 -0600
> +++ b/include/linux/swapops.h	Wed Feb 06 10:21:32 2008 -0600
> @@ -42,11 +42,13 @@
>  	return entry.val & SWP_OFFSET_MASK(entry);
>  }
>  
> +#ifdef CONFIG_MMU
>  /* check whether a pte points to a swap entry */
>  static inline int is_swap_pte(pte_t pte)
>  {
>  	return !pte_none(pte) && !pte_present(pte) && !pte_file(pte);
>  }
> +#endif
>  
>  /*
>   * Convert the arch-dependent pte representation of a swp_entry_t into
> an
> 

Re: blackfin compile error

[Matt Mackall]

On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote:
> Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:
> 
> <--  snip  -->
> 
> ...
>   CC      mm/vmscan.o
> In file included from 
> /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
> /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
> make[2]: *** [mm/vmscan.o] Error 1

This suggests that no one's tried to compile -mm on Blackfin since
before September, I think.

Is there somewhere more appropriate to move it? I can't find one.
Failing that, we can wrap it in CONFIG_MMU, I suppose.

Signed-off-by: Matt Mackall <mpm@selenic.com>

diff -r 50a6e531a9f2 include/linux/swapops.h
--- a/include/linux/swapops.h	Mon Feb 04 20:23:02 2008 -0600
+++ b/include/linux/swapops.h	Wed Feb 06 10:21:32 2008 -0600
@@ -42,11 +42,13 @@
 	return entry.val & SWP_OFFSET_MASK(entry);
 }
 
+#ifdef CONFIG_MMU
 /* check whether a pte points to a swap entry */
 static inline int is_swap_pte(pte_t pte)
 {
 	return !pte_none(pte) && !pte_present(pte) && !pte_file(pte);
 }
+#endif
 
 /*
  * Convert the arch-dependent pte representation of a swp_entry_t into an

-- 
Mathematics is the supreme nostalgia of our time.

blackfin compile error

[Adrian Bunk]

Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin:

<--  snip  -->

...
  CC      mm/vmscan.o
In file included from 
/home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44:
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte':
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none'
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present'
make[2]: *** [mm/vmscan.o] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed