From: Arnd Bergmann <arnd@arndb.de>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Oren Laadan <orenl@cs.columbia.edu>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [RFC][PATCH 2/4] checkpoint/restart: x86 support
Date: Fri, 8 Aug 2008 14:09:29 +0200 [thread overview]
Message-ID: <200808081409.30591.arnd@arndb.de> (raw)
In-Reply-To: <20080807224035.E56663BF@kernel>
> diff -puN /dev/null include/asm-x86/ckpt.h
> --- /dev/null 2007-04-11 11:48:27.000000000 -0700
> +++ linux-2.6.git-dave/include/asm-x86/ckpt.h 2008-08-04 13:29:59.000000000 -0700
> @@ -0,0 +1,46 @@
> +
> +struct cr_hdr_cpu {
> + __u64 bx;
> + __u64 cx;
> + __u64 dx;
> + __u64 si;
> + __u64 di;
> + __u64 bp;
> + __u64 ax;
> + __u64 ds;
> + __u64 es;
> + __u64 orig_ax;
> + __u64 ip;
> + __u64 cs;
> + __u64 flags;
> + __u64 sp;
> + __u64 ss;
> + __u64 fs;
> + __u64 gs;
> +
> + __u64 debugreg0;
> + __u64 debugreg1;
> + __u64 debugreg2;
> + __u64 debugreg3;
> + __u64 debugreg6;
> + __u64 debugreg7;
> +
> + __u8 uses_debug;
> +
> + __u8 used_math;
> + __u8 has_fxsr;
> + union thread_xstate xstate; /* i387 */
> +};
It seems weird that you use __u64 members for the registers, but don't
include r8..r15 in the list. As a consequence, this structure does not
seem well suited for either x86-32 or x86-64.
I would suggest either using struct pt_regs by reference, or defining
it so that you can use the same structure for both 32 and 64 bit x86.
Arnd <><
next prev parent reply other threads:[~2008-08-08 12:10 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 22:40 [RFC][PATCH 0/4] kernel-based checkpoint restart Dave Hansen
2008-08-07 22:40 ` [RFC][PATCH 1/4] checkpoint-restart: general infrastructure Dave Hansen
2008-08-08 9:46 ` Arnd Bergmann
2008-08-08 18:50 ` Dave Hansen
2008-08-08 20:59 ` Oren Laadan
2008-08-08 22:17 ` Dave Hansen
2008-08-08 23:27 ` Oren Laadan
2008-08-08 22:23 ` Arnd Bergmann
2008-08-14 8:09 ` [Devel] " Pavel Emelyanov
2008-08-14 15:16 ` Dave Hansen
2008-08-08 22:13 ` Arnd Bergmann
2008-08-08 22:26 ` Dave Hansen
2008-08-08 22:39 ` Arnd Bergmann
2008-08-09 0:43 ` Dave Hansen
2008-08-09 6:37 ` Arnd Bergmann
2008-08-09 13:39 ` Dave Hansen
2008-08-11 15:07 ` Serge E. Hallyn
2008-08-11 15:25 ` Arnd Bergmann
2008-08-14 5:53 ` Pavel Machek
2008-08-14 15:12 ` Dave Hansen
2008-08-20 21:40 ` Oren Laadan
2008-08-11 15:22 ` Serge E. Hallyn
2008-08-11 16:53 ` Arnd Bergmann
2008-08-11 17:11 ` Dave Hansen
2008-08-11 19:48 ` checkpoint/restart ABI Dave Hansen
2008-08-11 21:47 ` Arnd Bergmann
2008-08-11 23:14 ` Jonathan Corbet
2008-08-11 23:23 ` Dave Hansen
2008-08-21 5:56 ` Oren Laadan
2008-08-21 8:43 ` Arnd Bergmann
2008-08-21 15:43 ` Oren Laadan
2008-08-11 21:54 ` Oren Laadan
2008-08-11 23:38 ` Jeremy Fitzhardinge
2008-08-11 23:54 ` Peter Chubb
2008-08-12 14:49 ` Serge E. Hallyn
2008-08-28 23:40 ` Eric W. Biederman
2008-08-12 15:11 ` Dave Hansen
2008-08-12 14:58 ` Dave Hansen
2008-08-12 16:32 ` Jeremy Fitzhardinge
2008-08-12 16:46 ` Dave Hansen
2008-08-12 17:04 ` Jeremy Fitzhardinge
2008-08-20 21:52 ` Oren Laadan
2008-08-20 21:54 ` Oren Laadan
2008-08-20 22:11 ` Dave Hansen
2008-08-11 18:03 ` [RFC][PATCH 1/4] checkpoint-restart: general infrastructure Jonathan Corbet
2008-08-11 18:38 ` Dave Hansen
2008-08-12 3:44 ` Oren Laadan
2008-08-18 9:26 ` [Devel] " Pavel Emelyanov
2008-08-20 19:10 ` Dave Hansen
2008-08-07 22:40 ` [RFC][PATCH 2/4] checkpoint/restart: x86 support Dave Hansen
2008-08-08 12:09 ` Arnd Bergmann [this message]
2008-08-08 20:28 ` Oren Laadan
2008-08-08 22:29 ` Arnd Bergmann
2008-08-08 23:04 ` Oren Laadan
2008-08-09 0:38 ` Dave Hansen
2008-08-09 1:20 ` Oren Laadan
2008-08-09 2:20 ` Dave Hansen
2008-08-09 2:35 ` Oren Laadan
2008-08-10 14:55 ` Jeremy Fitzhardinge
2008-08-11 15:36 ` Dave Hansen
2008-08-11 16:07 ` Jeremy Fitzhardinge
2008-08-09 6:43 ` Arnd Bergmann
2008-08-07 22:40 ` [RFC][PATCH 3/4] checkpoint/restart: memory management Dave Hansen
2008-08-08 12:12 ` Arnd Bergmann
2008-08-07 22:40 ` [RFC][PATCH 4/4] introduce sys_checkpoint and sys_restore Dave Hansen
2008-08-08 12:15 ` Arnd Bergmann
2008-08-08 20:33 ` Oren Laadan
2008-08-08 9:25 ` [RFC][PATCH 0/4] kernel-based checkpoint restart Arnd Bergmann
2008-08-08 18:06 ` Dave Hansen
2008-08-08 18:18 ` Arnd Bergmann
2008-08-08 19:44 ` Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808081409.30591.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orenl@cs.columbia.edu \
--cc=serue@us.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).