From: Greg KH <gregkh@suse.de>
To: Tilman Schmidt <tilman@imap.cc>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
isdn4linux@listserv.isdn4linux.de
Subject: Re: Can we remove pci_find_device() yet?
Date: Mon, 11 Jan 2010 12:01:36 -0800 [thread overview]
Message-ID: <20100111200136.GA29955@suse.de> (raw)
In-Reply-To: <4B4B802A.2010709@imap.cc>
On Mon, Jan 11, 2010 at 08:46:50PM +0100, Tilman Schmidt wrote:
> Am 08.01.2010 05:46 schrieb Greg KH:
> > On Fri, Jan 08, 2010 at 11:22:36AM +1100, Stephen Rothwell wrote:
> >>
> >> This interface has been deprecated since November 2006, so can something
> >> be done about the last users (I think only some ISDN drivers)?
>
> That would be the HiSax I4L drivers.
>
> > Ick, the "new" isdn drivers are still not merged that replace those
> > older ones? I thought that happened a while ago.
>
> mISDN, which is the designated successor to HiSax, has indeed been
> merged in 2008.
>
> Trouble is, mISDN's userspace interface is completely different from I4L.
> Removing HiSax would therefore break userspace compatibility for current
> users of HiSax supported devices. In order to switch to mISDN they'll
> have to replace all of their ISDN4Linux applications with equivalent
> mISDN ones, and I'm not even sure there is a replacement for everything.
>
> Just an idea - as a stopgap measure, couldn't pci_find_device() be made
> a private function of the HiSax drivers? That way, the remainder of the
> kernel won't be polluted by it anymore, and the PCI_LEGACY config option
> can be dropped. Something like this quick and dirty hack:
Close, but if you do this, please name the function
hisax_find_pci_device() or something, and change the drivers to use it
instead. Also put a big fat warning in the function that calling this
is unsafe for any PCI hotplug type machine.
thanks,
greg k-h
next prev parent reply other threads:[~2010-01-11 20:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 0:22 Can we remove pci_find_device() yet? Stephen Rothwell
2010-01-08 4:46 ` Greg KH
2010-01-11 19:46 ` Tilman Schmidt
2010-01-11 20:01 ` Greg KH [this message]
2010-01-12 0:21 ` Stephen Rothwell
2010-01-12 0:46 ` Greg KH
2010-01-12 16:42 ` Tilman Schmidt
2010-01-12 17:39 ` Greg KH
2010-01-13 9:02 ` Tilman Schmidt
2010-01-12 20:34 ` Krzysztof Halasa
2010-01-12 20:53 ` Ben Hutchings
2010-01-12 21:18 ` Greg KH
2010-01-13 15:09 ` Krzysztof Halasa
2010-01-13 14:23 ` [PATCH] pci: push deprecated pci_find_device() function to last user Tilman Schmidt
2010-01-14 4:33 ` David Miller
2010-01-14 4:43 ` Greg KH
2010-01-14 8:12 ` David Miller
2010-01-14 16:28 ` Jesse Barnes
2010-01-14 22:18 ` [PATCH/REPOST] " Tilman Schmidt
2010-01-15 18:08 ` Jesse Barnes
2010-01-16 11:17 ` Stephen Rothwell
2010-01-18 16:24 ` [PATCH/v2] " Tilman Schmidt
2010-01-14 10:18 ` Can we remove pci_find_device() yet? Andi Kleen
2010-01-14 11:02 ` Alan Cox
2010-01-14 11:03 ` Andi Kleen
2010-01-14 12:39 ` Tilman Schmidt
2010-01-20 15:11 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111200136.GA29955@suse.de \
--to=gregkh@suse.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).