From: Andi Kleen <andi@firstfloor.org>
To: Greg KH <gregkh@suse.de>
Cc: Tilman Schmidt <tilman@imap.cc>,
Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
isdn4linux@listserv.isdn4linux.de
Subject: Re: Can we remove pci_find_device() yet?
Date: Thu, 14 Jan 2010 11:18:12 +0100 [thread overview]
Message-ID: <877hrlf0rf.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100111200136.GA29955@suse.de> (Greg KH's message of "Mon, 11 Jan 2010 12:01:36 -0800")
Greg KH <gregkh@suse.de> writes:
>
> Close, but if you do this, please name the function
> hisax_find_pci_device() or something, and change the drivers to use it
> instead. Also put a big fat warning in the function that calling this
> is unsafe for any PCI hotplug type machine.
It would be better to enforce this constraint at runtime.
e.g. set some global variable that forbids device removal
and warn in the kernel log. In theory this could be also
done per device, but I guess that would be more effort.
Of course it cannot prevent the user from really removing
a device, but at least the pci_dev could stay around.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-14 10:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 0:22 Can we remove pci_find_device() yet? Stephen Rothwell
2010-01-08 4:46 ` Greg KH
2010-01-11 19:46 ` Tilman Schmidt
2010-01-11 20:01 ` Greg KH
2010-01-12 0:21 ` Stephen Rothwell
2010-01-12 0:46 ` Greg KH
2010-01-12 16:42 ` Tilman Schmidt
2010-01-12 17:39 ` Greg KH
2010-01-13 9:02 ` Tilman Schmidt
2010-01-12 20:34 ` Krzysztof Halasa
2010-01-12 20:53 ` Ben Hutchings
2010-01-12 21:18 ` Greg KH
2010-01-13 15:09 ` Krzysztof Halasa
2010-01-13 14:23 ` [PATCH] pci: push deprecated pci_find_device() function to last user Tilman Schmidt
2010-01-14 4:33 ` David Miller
2010-01-14 4:43 ` Greg KH
2010-01-14 8:12 ` David Miller
2010-01-14 16:28 ` Jesse Barnes
2010-01-14 22:18 ` [PATCH/REPOST] " Tilman Schmidt
2010-01-15 18:08 ` Jesse Barnes
2010-01-16 11:17 ` Stephen Rothwell
2010-01-18 16:24 ` [PATCH/v2] " Tilman Schmidt
2010-01-14 10:18 ` Andi Kleen [this message]
2010-01-14 11:02 ` Can we remove pci_find_device() yet? Alan Cox
2010-01-14 11:03 ` Andi Kleen
2010-01-14 12:39 ` Tilman Schmidt
2010-01-20 15:11 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hrlf0rf.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).