linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Krzysztof Halasa <khc@pm.waw.pl>, Tilman Schmidt <tilman@imap.cc>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
	isdn4linux@listserv.isdn4linux.de
Subject: Re: Can we remove pci_find_device() yet?
Date: Tue, 12 Jan 2010 13:18:01 -0800	[thread overview]
Message-ID: <20100112211801.GA27999@suse.de> (raw)
In-Reply-To: <1263329605.3011.8.camel@achroite.uk.solarflarecom.com>

On Tue, Jan 12, 2010 at 08:53:25PM +0000, Ben Hutchings wrote:
> > How do I do that properly, in terms of PCI API?
> 
> One of our older controllers had a similar design error in that the two
> functions would sometimes have to be reset together.  The way we look
> for the second function is:
> 
> 	dev = pci_dev_get(dev1);
> 	while ((dev = pci_get_device(vendor_id, device_id, dev))) {
> 		if (dev->bus == dev1->bus &&
> 		    dev->devfn == dev1->devfn + 1) {
> 			dev2 = dev;
> 			break;
> 		}
> 	}
> 
> I assume this is 'properly' since no-one has told me otherwise.

As of right now, yes, this is the "correct" way to do this.

I need to dig up the "let multiple drivers bind to a single device"
patch set to make this not necessary in the future.

thanks,

greg k-h

  reply	other threads:[~2010-01-12 21:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08  0:22 Can we remove pci_find_device() yet? Stephen Rothwell
2010-01-08  4:46 ` Greg KH
2010-01-11 19:46   ` Tilman Schmidt
2010-01-11 20:01     ` Greg KH
2010-01-12  0:21       ` Stephen Rothwell
2010-01-12  0:46         ` Greg KH
2010-01-12 16:42       ` Tilman Schmidt
2010-01-12 17:39         ` Greg KH
2010-01-13  9:02           ` Tilman Schmidt
2010-01-12 20:34       ` Krzysztof Halasa
2010-01-12 20:53         ` Ben Hutchings
2010-01-12 21:18           ` Greg KH [this message]
2010-01-13 15:09             ` Krzysztof Halasa
2010-01-13 14:23       ` [PATCH] pci: push deprecated pci_find_device() function to last user Tilman Schmidt
2010-01-14  4:33         ` David Miller
2010-01-14  4:43           ` Greg KH
2010-01-14  8:12             ` David Miller
2010-01-14 16:28               ` Jesse Barnes
2010-01-14 22:18                 ` [PATCH/REPOST] " Tilman Schmidt
2010-01-15 18:08                   ` Jesse Barnes
2010-01-16 11:17                     ` Stephen Rothwell
2010-01-18 16:24                 ` [PATCH/v2] " Tilman Schmidt
2010-01-14 10:18       ` Can we remove pci_find_device() yet? Andi Kleen
2010-01-14 11:02         ` Alan Cox
2010-01-14 11:03           ` Andi Kleen
2010-01-14 12:39             ` Tilman Schmidt
2010-01-20 15:11           ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100112211801.GA27999@suse.de \
    --to=gregkh@suse.de \
    --cc=bhutchings@solarflare.com \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=isdn@linux-pingi.de \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).