From: Tilman Schmidt <tilman@imap.cc>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <gregkh@suse.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
isdn4linux@listserv.isdn4linux.de
Subject: Re: Can we remove pci_find_device() yet?
Date: Thu, 14 Jan 2010 13:39:15 +0100 [thread overview]
Message-ID: <4B4F1073.5060903@imap.cc> (raw)
In-Reply-To: <20100114110354.GJ12241@basil.fritz.box>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am 2010-01-14 12:03 schrieb Andi Kleen:
> On Thu, Jan 14, 2010 at 11:02:14AM +0000, Alan Cox wrote:
[It would be better to enforce this constraint at runtime.]
>> There is a simpler way to do that, which is to just leak a reference in
>> the hisax_find_pci_device hack. The pci_dev won't be going anywhere then.
>
> You just have to do it once, otherwise it'll fail after 4 billion times.
I guess we could live with that. pci_find_device() or its successor, the
hisax_find_pci_device() hack, is only called during device setup, once
for most drivers and at the very most 24 times for hfc_pci. Someone
would have to rmmod/insmod a HiSax module more than a hundred million
times to accumulate four billion calls.
- --
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAktPEHMACgkQQ3+did9BuFuQ/gCgkhu6RJIwrpIDAJMWbO1mZgOd
BKwAnAh6kX5F/+dFPIrK/XLovEAv/R7O
=fflE
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-01-14 12:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 0:22 Can we remove pci_find_device() yet? Stephen Rothwell
2010-01-08 4:46 ` Greg KH
2010-01-11 19:46 ` Tilman Schmidt
2010-01-11 20:01 ` Greg KH
2010-01-12 0:21 ` Stephen Rothwell
2010-01-12 0:46 ` Greg KH
2010-01-12 16:42 ` Tilman Schmidt
2010-01-12 17:39 ` Greg KH
2010-01-13 9:02 ` Tilman Schmidt
2010-01-12 20:34 ` Krzysztof Halasa
2010-01-12 20:53 ` Ben Hutchings
2010-01-12 21:18 ` Greg KH
2010-01-13 15:09 ` Krzysztof Halasa
2010-01-13 14:23 ` [PATCH] pci: push deprecated pci_find_device() function to last user Tilman Schmidt
2010-01-14 4:33 ` David Miller
2010-01-14 4:43 ` Greg KH
2010-01-14 8:12 ` David Miller
2010-01-14 16:28 ` Jesse Barnes
2010-01-14 22:18 ` [PATCH/REPOST] " Tilman Schmidt
2010-01-15 18:08 ` Jesse Barnes
2010-01-16 11:17 ` Stephen Rothwell
2010-01-18 16:24 ` [PATCH/v2] " Tilman Schmidt
2010-01-14 10:18 ` Can we remove pci_find_device() yet? Andi Kleen
2010-01-14 11:02 ` Alan Cox
2010-01-14 11:03 ` Andi Kleen
2010-01-14 12:39 ` Tilman Schmidt [this message]
2010-01-20 15:11 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4F1073.5060903@imap.cc \
--to=tilman@imap.cc \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).