* [RESUBMIT PATCH v7 1/9] mfd: Add support for Skyworks SKY81452 driver
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 2/9] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
` (8 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
Changes v7:
Modified licensing text to GPLv2
Changes v6:
Added new line character at the end of line of dev_err()
Changes v5:
Move sky81452-backlight.h to include/linux/platform_data
Changes v4:
Removed MODULE_VERSION()
Modified license to GPLv2
Changes v3:
Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight'
Assigned mfd_cell.of_compatible for binding device node
Modified error messages
Changes v2:
Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452
Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452
Added message for exception or errors
drivers/mfd/Kconfig | 12 +++++
drivers/mfd/Makefile | 1 +
drivers/mfd/sky81452.c | 108 +++++++++++++++++++++++++++++++++++++++++++
include/linux/mfd/sky81452.h | 31 +++++++++++++
4 files changed, 152 insertions(+)
create mode 100644 drivers/mfd/sky81452.c
create mode 100644 include/linux/mfd/sky81452.h
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 1456ea7..a54244c 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -693,6 +693,18 @@ config MFD_SM501_GPIO
lines on the SM501. The platform data is used to supply the
base number for the first GPIO line to register.
+config MFD_SKY81452
+ tristate "Skyworks Solutions SKY81452"
+ select MFD_CORE
+ select REGMAP_I2C
+ depends on I2C
+ help
+ This is the core driver for the Skyworks SKY81452 backlight and
+ voltage regulator device.
+
+ This driver can also be built as a module. If so, the module
+ will be called sky81452.
+
config MFD_SMSC
bool "SMSC ECE1099 series chips"
depends on I2C=y
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 8bd54b1..d9683ea 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -174,6 +174,7 @@ obj-$(CONFIG_MFD_STW481X) += stw481x.o
obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o
obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o
obj-$(CONFIG_MFD_HI6421_PMIC) += hi6421-pmic-core.o
+obj-$(CONFIG_MFD_SKY81452) += sky81452.o
intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o
obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o
diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c
new file mode 100644
index 0000000..b0c9b04
--- /dev/null
+++ b/drivers/mfd/sky81452.c
@@ -0,0 +1,108 @@
+/*
+ * sky81452.c SKY81452 MFD driver
+ *
+ * Copyright 2014 Skyworks Solutions Inc.
+ * Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/err.h>
+#include <linux/slab.h>
+#include <linux/i2c.h>
+#include <linux/regmap.h>
+#include <linux/mfd/core.h>
+#include <linux/mfd/sky81452.h>
+
+static const struct regmap_config sky81452_config = {
+ .reg_bits = 8,
+ .val_bits = 8,
+};
+
+static int sky81452_probe(struct i2c_client *client,
+ const struct i2c_device_id *id)
+{
+ struct device *dev = &client->dev;
+ const struct sky81452_platform_data *pdata = dev_get_platdata(dev);
+ struct mfd_cell cells[2];
+ struct regmap *regmap;
+ int ret;
+
+ if (!pdata) {
+ pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
+ if (!pdata)
+ return -ENOMEM;
+ }
+
+ regmap = devm_regmap_init_i2c(client, &sky81452_config);
+ if (IS_ERR(regmap)) {
+ dev_err(dev, "failed to initialize.err=%ld\n", PTR_ERR(regmap));
+ return PTR_ERR(regmap);
+ }
+
+ i2c_set_clientdata(client, regmap);
+
+ memset(cells, 0, sizeof(cells));
+ cells[0].name = "sky81452-backlight";
+ cells[0].of_compatible = "skyworks,sky81452-backlight";
+ cells[0].platform_data = pdata->bl_pdata;
+ cells[0].pdata_size = sizeof(*pdata->bl_pdata);
+ cells[1].name = "sky81452-regulator";
+ cells[1].platform_data = pdata->regulator_init_data;
+ cells[1].pdata_size = sizeof(*pdata->regulator_init_data);
+
+ ret = mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), NULL, 0, NULL);
+ if (ret)
+ dev_err(dev, "failed to add child devices. err=%d\n", ret);
+
+ return ret;
+}
+
+static int sky81452_remove(struct i2c_client *client)
+{
+ mfd_remove_devices(&client->dev);
+ return 0;
+}
+
+static const struct i2c_device_id sky81452_ids[] = {
+ { "sky81452" },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, sky81452_ids);
+
+#ifdef CONFIG_OF
+static const struct of_device_id sky81452_of_match[] = {
+ { .compatible = "skyworks,sky81452", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, sky81452_of_match);
+#endif
+
+static struct i2c_driver sky81452_driver = {
+ .driver = {
+ .name = "sky81452",
+ .of_match_table = of_match_ptr(sky81452_of_match),
+ },
+ .probe = sky81452_probe,
+ .remove = sky81452_remove,
+ .id_table = sky81452_ids,
+};
+
+module_i2c_driver(sky81452_driver);
+
+MODULE_DESCRIPTION("Skyworks SKY81452 MFD driver");
+MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
+MODULE_LICENSE("GPL v2");
diff --git a/include/linux/mfd/sky81452.h b/include/linux/mfd/sky81452.h
new file mode 100644
index 0000000..b0925fa
--- /dev/null
+++ b/include/linux/mfd/sky81452.h
@@ -0,0 +1,31 @@
+/*
+ * sky81452.h SKY81452 MFD driver
+ *
+ * Copyright 2014 Skyworks Solutions Inc.
+ * Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef _SKY81452_H
+#define _SKY81452_H
+
+#include <linux/platform_data/sky81452-backlight.h>
+#include <linux/regulator/machine.h>
+
+struct sky81452_platform_data {
+ struct sky81452_bl_platform_data *bl_pdata;
+ struct regulator_init_data *regulator_init_data;
+};
+
+#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [RESUBMIT PATCH v7 2/9] backlight: Add support Skyworks SKY81452 backlight driver
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 1/9] mfd: Add support for Skyworks SKY81452 driver gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 3/9] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
` (7 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Modified licensing text to GPLv2
Changes v6:
Added new line character at the end of line of dev_err()
Changes v5:
Move sky81452-backlight.h to include/linux/platform_data
Changes v4:
Reordering header files for readability
Removed calling to backlight_device_unregister()
Removed MODULE_VERSION()
Modified license to GPLv2
Changes v3:
Modified DBG messages
Changes v2:
Added 'compatible' attribute in the driver
Added message for exception or errors
drivers/video/backlight/Kconfig | 10 +
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/sky81452-backlight.c | 343 +++++++++++++++++++++++
include/linux/platform_data/sky81452-backlight.h | 46 +++
4 files changed, 400 insertions(+)
create mode 100644 drivers/video/backlight/sky81452-backlight.c
create mode 100644 include/linux/platform_data/sky81452-backlight.h
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 8d03924..2586fdd 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -409,6 +409,16 @@ config BACKLIGHT_PANDORA
If you have a Pandora console, say Y to enable the
backlight driver.
+config BACKLIGHT_SKY81452
+ tristate "Backlight driver for SKY81452"
+ depends on BACKLIGHT_CLASS_DEVICE && MFD_SKY81452
+ help
+ If you have a Skyworks SKY81452, say Y to enable the
+ backlight driver.
+
+ To compile this driver as a module, choose M here: the module will
+ be called sky81452-backlight
+
config BACKLIGHT_TPS65217
tristate "TPS65217 Backlight"
depends on BACKLIGHT_CLASS_DEVICE && MFD_TPS65217
diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile
index fcd50b73..d67073f 100644
--- a/drivers/video/backlight/Makefile
+++ b/drivers/video/backlight/Makefile
@@ -50,6 +50,7 @@ obj-$(CONFIG_BACKLIGHT_PANDORA) += pandora_bl.o
obj-$(CONFIG_BACKLIGHT_PCF50633) += pcf50633-backlight.o
obj-$(CONFIG_BACKLIGHT_PWM) += pwm_bl.o
obj-$(CONFIG_BACKLIGHT_SAHARA) += kb3886_bl.o
+obj-$(CONFIG_BACKLIGHT_SKY81452) += sky81452-backlight.o
obj-$(CONFIG_BACKLIGHT_TOSA) += tosa_bl.o
obj-$(CONFIG_BACKLIGHT_TPS65217) += tps65217_bl.o
obj-$(CONFIG_BACKLIGHT_WM831X) += wm831x_bl.o
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
new file mode 100644
index 0000000..9c1139e
--- /dev/null
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -0,0 +1,343 @@
+/*
+ * sky81452-backlight.c SKY81452 backlight driver
+ *
+ * Copyright 2014 Skyworks Solutions Inc.
+ * Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/backlight.h>
+#include <linux/err.h>
+#include <linux/gpio.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_gpio.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/platform_data/sky81452-backlight.h>
+#include <linux/slab.h>
+
+/* registers */
+#define SKY81452_REG0 0x00
+#define SKY81452_REG1 0x01
+#define SKY81452_REG2 0x02
+#define SKY81452_REG4 0x04
+#define SKY81452_REG5 0x05
+
+/* bit mask */
+#define SKY81452_CS 0xFF
+#define SKY81452_EN 0x3F
+#define SKY81452_IGPW 0x20
+#define SKY81452_PWMMD 0x10
+#define SKY81452_PHASE 0x08
+#define SKY81452_ILIM 0x04
+#define SKY81452_VSHRT 0x03
+#define SKY81452_OCP 0x80
+#define SKY81452_OTMP 0x40
+#define SKY81452_SHRT 0x3F
+#define SKY81452_OPN 0x3F
+
+#define SKY81452_DEFAULT_NAME "lcd-backlight"
+#define SKY81452_MAX_BRIGHTNESS (SKY81452_CS + 1)
+
+#define CTZ(b) __builtin_ctz(b)
+
+static int sky81452_bl_update_status(struct backlight_device *bd)
+{
+ const struct sky81452_bl_platform_data *pdata =
+ dev_get_platdata(bd->dev.parent);
+ const unsigned int brightness = (unsigned int)bd->props.brightness;
+ struct regmap *regmap = bl_get_data(bd);
+ int ret;
+
+ if (brightness > 0) {
+ ret = regmap_write(regmap, SKY81452_REG0, brightness - 1);
+ if (IS_ERR_VALUE(ret))
+ return ret;
+
+ return regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN,
+ pdata->enable << CTZ(SKY81452_EN));
+ }
+
+ return regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN, 0);
+}
+
+static int sky81452_bl_get_brightness(struct backlight_device *bd)
+{
+ return bd->props.brightness;
+}
+
+static const struct backlight_ops sky81452_bl_ops = {
+ .update_status = sky81452_bl_update_status,
+ .get_brightness = sky81452_bl_get_brightness,
+};
+
+static ssize_t sky81452_bl_store_enable(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ struct regmap *regmap = bl_get_data(to_backlight_device(dev));
+ unsigned long value;
+ int ret;
+
+ ret = kstrtoul(buf, 16, &value);
+ if (IS_ERR_VALUE(ret))
+ return ret;
+
+ ret = regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN,
+ value << CTZ(SKY81452_EN));
+ if (IS_ERR_VALUE(ret))
+ return ret;
+
+ return count;
+}
+
+static ssize_t sky81452_bl_show_open_short(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct regmap *regmap = bl_get_data(to_backlight_device(dev));
+ unsigned int reg, value = 0;
+ char tmp[3];
+ int i, ret;
+
+ reg = !strcmp(attr->attr.name, "open") ? SKY81452_REG5 : SKY81452_REG4;
+ ret = regmap_read(regmap, reg, &value);
+ if (IS_ERR_VALUE(ret))
+ return ret;
+
+ if (value & SKY81452_SHRT) {
+ *buf = 0;
+ for (i = 0; i < 6; i++) {
+ if (value & 0x01) {
+ sprintf(tmp, "%d ", i + 1);
+ strcat(buf, tmp);
+ }
+ value >>= 1;
+ }
+ strcat(buf, "\n");
+ } else {
+ strcpy(buf, "none\n");
+ }
+
+ return strlen(buf);
+}
+
+static ssize_t sky81452_bl_show_fault(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct regmap *regmap = bl_get_data(to_backlight_device(dev));
+ unsigned int value = 0;
+ int ret;
+
+ ret = regmap_read(regmap, SKY81452_REG4, &value);
+ if (IS_ERR_VALUE(ret))
+ return ret;
+
+ *buf = 0;
+
+ if (value & SKY81452_OCP)
+ strcat(buf, "over-current ");
+
+ if (value & SKY81452_OTMP)
+ strcat(buf, "over-temperature");
+
+ strcat(buf, "\n");
+ return strlen(buf);
+}
+
+static DEVICE_ATTR(enable, S_IWGRP | S_IWUSR, NULL, sky81452_bl_store_enable);
+static DEVICE_ATTR(open, S_IRUGO, sky81452_bl_show_open_short, NULL);
+static DEVICE_ATTR(short, S_IRUGO, sky81452_bl_show_open_short, NULL);
+static DEVICE_ATTR(fault, S_IRUGO, sky81452_bl_show_fault, NULL);
+
+static struct attribute *sky81452_bl_attribute[] = {
+ &dev_attr_enable.attr,
+ &dev_attr_open.attr,
+ &dev_attr_short.attr,
+ &dev_attr_fault.attr,
+ NULL
+};
+
+static const struct attribute_group sky81452_bl_attr_group = {
+ .attrs = sky81452_bl_attribute,
+};
+
+#ifdef CONFIG_OF
+static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
+ struct device *dev)
+{
+ struct device_node *np = of_node_get(dev->of_node);
+ struct sky81452_bl_platform_data *pdata;
+ int ret;
+
+ if (!np) {
+ dev_err(dev, "backlight node not found.\n");
+ return ERR_PTR(-ENODATA);
+ }
+
+ pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
+ if (!pdata) {
+ of_node_put(np);
+ return ERR_PTR(-ENOMEM);
+ }
+
+ of_property_read_string(np, "name", &pdata->name);
+ pdata->ignore_pwm = of_property_read_bool(np, "ignore-pwm");
+ pdata->dpwm_mode = of_property_read_bool(np, "dpwm-mode");
+ pdata->phase_shift = of_property_read_bool(np, "phase-shift");
+
+ pdata->gpio_enable = of_get_named_gpio(np, "gpio-enable", 0);
+ if (IS_ERR_VALUE(pdata->gpio_enable))
+ pdata->gpio_enable = -1;
+
+ ret = of_property_read_u32(np, "enable", &pdata->enable);
+ if (IS_ERR_VALUE(ret))
+ pdata->enable = SKY81452_EN >> CTZ(SKY81452_EN);
+
+ ret = of_property_read_u32(np, "short-detection-threshold",
+ &pdata->short_detection_threshold);
+ if (IS_ERR_VALUE(ret))
+ pdata->short_detection_threshold = 7;
+
+ ret = of_property_read_u32(np, "boost-current-limit",
+ &pdata->boost_current_limit);
+ if (IS_ERR_VALUE(ret))
+ pdata->boost_current_limit = 2750;
+
+ of_node_put(np);
+ return pdata;
+}
+#else
+static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
+ struct device *dev)
+{
+ return ERR_PTR(-EINVAL);
+}
+#endif
+
+static int sky81452_bl_init_device(struct regmap *regmap,
+ struct sky81452_bl_platform_data *pdata)
+{
+ unsigned int value;
+
+ value = pdata->ignore_pwm ? SKY81452_IGPW : 0;
+ value |= pdata->dpwm_mode ? SKY81452_PWMMD : 0;
+ value |= pdata->phase_shift ? 0 : SKY81452_PHASE;
+
+ if (pdata->boost_current_limit == 2300)
+ value |= SKY81452_ILIM;
+ else if (pdata->boost_current_limit != 2720)
+ return -EINVAL;
+
+ if (pdata->short_detection_threshold < 4 ||
+ pdata->short_detection_threshold > 7)
+ return -EINVAL;
+ value |= (7 - pdata->short_detection_threshold) << CTZ(SKY81452_VSHRT);
+
+ return regmap_write(regmap, SKY81452_REG2, value);
+}
+
+static int sky81452_bl_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct regmap *regmap = dev_get_drvdata(dev->parent);
+ struct sky81452_bl_platform_data *pdata = dev_get_platdata(dev);
+ struct backlight_device *bd;
+ struct backlight_properties props;
+ const char *name;
+ int ret;
+
+ if (!pdata) {
+ pdata = sky81452_bl_parse_dt(dev);
+ if (IS_ERR(pdata))
+ return PTR_ERR(pdata);
+ }
+
+ if (pdata->gpio_enable >= 0) {
+ ret = devm_gpio_request_one(dev, pdata->gpio_enable,
+ GPIOF_OUT_INIT_HIGH, "sky81452-en");
+ if (IS_ERR_VALUE(ret)) {
+ dev_err(dev, "failed to request GPIO. err=%d\n", ret);
+ return ret;
+ }
+ }
+
+ ret = sky81452_bl_init_device(regmap, pdata);
+ if (IS_ERR_VALUE(ret)) {
+ dev_err(dev, "failed to initialize. err=%d\n", ret);
+ return ret;
+ }
+
+ memset(&props, 0, sizeof(props));
+ props.max_brightness = SKY81452_MAX_BRIGHTNESS,
+ name = pdata->name ? pdata->name : SKY81452_DEFAULT_NAME;
+ bd = devm_backlight_device_register(dev, name, dev, regmap,
+ &sky81452_bl_ops, &props);
+ if (IS_ERR(bd)) {
+ dev_err(dev, "failed to register. err=%ld\n", PTR_ERR(bd));
+ return PTR_ERR(bd);
+ }
+
+ platform_set_drvdata(pdev, bd);
+
+ ret = sysfs_create_group(&bd->dev.kobj, &sky81452_bl_attr_group);
+ if (IS_ERR_VALUE(ret)) {
+ dev_err(dev, "failed to create attribute. err=%d\n", ret);
+ return ret;
+ }
+
+ return ret;
+}
+
+static int sky81452_bl_remove(struct platform_device *pdev)
+{
+ const struct sky81452_bl_platform_data *pdata =
+ dev_get_platdata(&pdev->dev);
+ struct backlight_device *bd = platform_get_drvdata(pdev);
+
+ sysfs_remove_group(&bd->dev.kobj, &sky81452_bl_attr_group);
+
+ bd->props.power = FB_BLANK_UNBLANK;
+ bd->props.brightness = 0;
+ backlight_update_status(bd);
+
+ if (pdata->gpio_enable >= 0)
+ gpio_set_value_cansleep(pdata->gpio_enable, 0);
+
+ return 0;
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id sky81452_bl_of_match[] = {
+ { .compatible = "skyworks,sky81452-backlight", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, sky81452_bl_of_match);
+#endif
+
+static struct platform_driver sky81452_bl_driver = {
+ .driver = {
+ .name = "sky81452-backlight",
+ .of_match_table = of_match_ptr(sky81452_bl_of_match),
+ },
+ .probe = sky81452_bl_probe,
+ .remove = sky81452_bl_remove,
+};
+
+module_platform_driver(sky81452_bl_driver);
+
+MODULE_DESCRIPTION("Skyworks SKY81452 backlight driver");
+MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
+MODULE_LICENSE("GPL v2");
diff --git a/include/linux/platform_data/sky81452-backlight.h b/include/linux/platform_data/sky81452-backlight.h
new file mode 100644
index 0000000..1231e9b
--- /dev/null
+++ b/include/linux/platform_data/sky81452-backlight.h
@@ -0,0 +1,46 @@
+/*
+ * sky81452.h SKY81452 backlight driver
+ *
+ * Copyright 2014 Skyworks Solutions Inc.
+ * Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef _SKY81452_BACKLIGHT_H
+#define _SKY81452_BACKLIGHT_H
+
+/**
+ * struct sky81452_platform_data
+ * @name: backlight driver name.
+ If it is not defined, default name is lcd-backlight.
+ * @gpio_enable:GPIO number which control EN pin
+ * @enable: Enable mask for current sink channel 1, 2, 3, 4, 5 and 6.
+ * @ignore_pwm: true if DPWMI should be ignored.
+ * @dpwm_mode: true is DPWM dimming mode, otherwise Analog dimming mode.
+ * @phase_shift:true is phase shift mode.
+ * @short_detecion_threshold: It should be one of 4, 5, 6 and 7V.
+ * @boost_current_limit: It should be one of 2300, 2750mA.
+ */
+struct sky81452_bl_platform_data {
+ const char *name;
+ int gpio_enable;
+ unsigned int enable;
+ bool ignore_pwm;
+ bool dpwm_mode;
+ bool phase_shift;
+ unsigned int short_detection_threshold;
+ unsigned int boost_current_limit;
+};
+
+#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [RESUBMIT PATCH v7 3/9] devicetree: mfd: Add new SKY81452 mfd binding
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 1/9] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 2/9] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
` (6 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Nothing
Changes v6:
Nothing
Changes v5:
Changed DT for regulator : 'lout' node should be defined under 'regulator'
Removed compatible string from sky81452-regulator driver
Changes v4:
Nothing
Changes v3:
Nothing
Changes v2:
Added reg attribute for I2C slave address
Documentation/devicetree/bindings/mfd/sky81452.txt | 33 ++++++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt
diff --git a/Documentation/devicetree/bindings/mfd/sky81452.txt b/Documentation/devicetree/bindings/mfd/sky81452.txt
new file mode 100644
index 0000000..4b82a73
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/sky81452.txt
@@ -0,0 +1,33 @@
+SKY81452 bindings
+
+Required properties:
+- compatible : Must be "skyworks,sky81452"
+- reg : I2C slave address
+
+Required child nodes:
+- backlight : container node for backlight following the binding
+ in video/backlight/sky81452-backlight.txt
+- regulator : container node for regulators following the binding
+ in regulator/sky81452-regulator.txt
+
+Example:
+
+ sky81452@2c {
+ compatible = "skyworks,sky81452";
+ reg = <0x2c>;
+
+ backlight {
+ compatible = "skyworks,sky81452-backlight";
+ name = "pwm-backlight";
+ enable = <0x3F>;
+ ignore-pwm;
+ };
+
+ regulator {
+ lout {
+ regulator-name = "sky81452-lout";
+ regulator-min-microvolt = <4500000>;
+ regulator-max-microvolt = <8000000>;
+ };
+ };
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
` (2 preceding siblings ...)
2014-11-17 8:33 ` [RESUBMIT PATCH v7 3/9] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 12:23 ` Lee Jones
2014-11-17 8:33 ` [RESUBMIT PATCH v7 5/9] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
` (5 subsequent siblings)
9 siblings, 1 reply; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Nothing
Changes v6:
Nothing
Changes v5:
Nothing
Changes v4:
Nothing
Changes v3:
Nothing
Changes v2:
Added reg attribute for I2C slave address
.../video/backlight/sky81452-backlight.txt | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
new file mode 100644
index 0000000..2c2d947
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
@@ -0,0 +1,24 @@
+SKY81452-backlight bindings
+
+Required properties:
+- compatible : Must be "skyworks,sky81452-backlight"
+
+Optional properties:
+- name : Name of backlight device. Default is 'lcd-backlight'.
+- gpio-enable : GPIO to use to EN pin.
+- enable : Enable mask for current sink channel 1 to 6.
+- ignore-pwm : Ignore both PWM input
+- dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming mode
+- phase-shift : Enable phase shift mode
+- ovp-level : Over-voltage protection level. Should be between 14 or 28V.
+- short-detection-threshold : It should be one of 4, 5, 6 and 7V.
+- boost-current-limit : It should be one of 800, 1100 and 1500mA.
+
+Example:
+
+ backlight {
+ compatible = "skyworks,sky81452-backlight";
+ name = "pwm-backlight";
+ enable = <0x3F>;
+ ignore-pwm;
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding
2014-11-17 8:33 ` [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
@ 2014-11-17 12:23 ` Lee Jones
2014-11-25 1:47 ` Gyungoh Yoo
0 siblings, 1 reply; 19+ messages in thread
From: Lee Jones @ 2014-11-17 12:23 UTC (permalink / raw)
To: gyungoh
Cc: sameo, jg1.han, cooloney, broonie, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
On Mon, 17 Nov 2014, gyungoh@gmail.com wrote:
> From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
>
> Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> ---
> Changes v7:
> Nothing
>
> Changes v6:
> Nothing
>
> Changes v5:
> Nothing
>
> Changes v4:
> Nothing
>
> Changes v3:
> Nothing
>
> Changes v2:
> Added reg attribute for I2C slave address
>
> .../video/backlight/sky81452-backlight.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
>
> diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> new file mode 100644
> index 0000000..2c2d947
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> @@ -0,0 +1,24 @@
> +SKY81452-backlight bindings
> +
> +Required properties:
> +- compatible : Must be "skyworks,sky81452-backlight"
> +
> +Optional properties:
> +- name : Name of backlight device. Default is 'lcd-backlight'.
> +- gpio-enable : GPIO to use to EN pin.
> +- enable : Enable mask for current sink channel 1 to 6.
> +- ignore-pwm : Ignore both PWM input
> +- dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming mode
> +- phase-shift : Enable phase shift mode
> +- ovp-level : Over-voltage protection level. Should be between 14 or 28V.
> +- short-detection-threshold : It should be one of 4, 5, 6 and 7V.
> +- boost-current-limit : It should be one of 800, 1100 and 1500mA.
These are going to need some serious reviewing from the DT guys. Each
property should either have a vendor prefix or be made generic and
placed in the generic DT documentation for the subsystem. The name
'enable' is far to generic we don't tend to put masks in DT. There
is already a generic property for GPIO enable pins.
> +Example:
> +
> + backlight {
> + compatible = "skyworks,sky81452-backlight";
> + name = "pwm-backlight";
> + enable = <0x3F>;
Lower case.
> + ignore-pwm;
You should probably demonstrate more of your properties here.
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding
2014-11-17 12:23 ` Lee Jones
@ 2014-11-25 1:47 ` Gyungoh Yoo
0 siblings, 0 replies; 19+ messages in thread
From: Gyungoh Yoo @ 2014-11-25 1:47 UTC (permalink / raw)
To: Lee Jones
Cc: sameo, jg1.han, cooloney, broonie, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
On Mon, Nov 17, 2014 at 12:23:33PM +0000, Lee Jones wrote:
> On Mon, 17 Nov 2014, gyungoh@gmail.com wrote:
>
> > From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> >
> > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> > ---
> > Changes v7:
> > Nothing
> >
> > Changes v6:
> > Nothing
> >
> > Changes v5:
> > Nothing
> >
> > Changes v4:
> > Nothing
> >
> > Changes v3:
> > Nothing
> >
> > Changes v2:
> > Added reg attribute for I2C slave address
> >
> > .../video/backlight/sky81452-backlight.txt | 24 ++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> >
> > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > new file mode 100644
> > index 0000000..2c2d947
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > @@ -0,0 +1,24 @@
> > +SKY81452-backlight bindings
> > +
> > +Required properties:
> > +- compatible : Must be "skyworks,sky81452-backlight"
> > +
> > +Optional properties:
> > +- name : Name of backlight device. Default is 'lcd-backlight'.
> > +- gpio-enable : GPIO to use to EN pin.
> > +- enable : Enable mask for current sink channel 1 to 6.
> > +- ignore-pwm : Ignore both PWM input
> > +- dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming mode
> > +- phase-shift : Enable phase shift mode
> > +- ovp-level : Over-voltage protection level. Should be between 14 or 28V.
> > +- short-detection-threshold : It should be one of 4, 5, 6 and 7V.
> > +- boost-current-limit : It should be one of 800, 1100 and 1500mA.
>
> These are going to need some serious reviewing from the DT guys. Each
> property should either have a vendor prefix or be made generic and
> placed in the generic DT documentation for the subsystem. The name
> 'enable' is far to generic we don't tend to put masks in DT. There
> is already a generic property for GPIO enable pins.
I see. I will rename the properties with the vendor prefix
and modify the name for GPIO enable pin to use 'gpios'
>
> > +Example:
> > +
> > + backlight {
> > + compatible = "skyworks,sky81452-backlight";
> > + name = "pwm-backlight";
> > + enable = <0x3F>;
>
> Lower case.
>
> > + ignore-pwm;
>
> You should probably demonstrate more of your properties here.
I will make up the example.
Thank you for your comments.
>
> > + };
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 19+ messages in thread
* [RESUBMIT PATCH v7 5/9] devicetree: Add vendor prefix for Skyworks Solutions, Inc.
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
` (3 preceding siblings ...)
2014-11-17 8:33 ` [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 6/9] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
` (4 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Nothing
Changes v6:
Nothing
Changes v5:
Nothing
Changes v4:
Nothing
Changes v3:
Nothing
Changes v2:
Added vendor prefix for Skyworks Solutions, Inc.
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 723999d..03e7730 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -137,6 +137,7 @@ sii Seiko Instruments, Inc.
silergy Silergy Corp.
sirf SiRF Technology, Inc.
sitronix Sitronix Technology Corporation
+skyworks Skyworks Solutions, Inc.
smsc Standard Microsystems Corporation
snps Synopsys, Inc.
solidrun SolidRun
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [RESUBMIT PATCH v7 6/9] devicetree: i2c: Add SKY81452 to the Trivial Devices list
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
` (4 preceding siblings ...)
2014-11-17 8:33 ` [RESUBMIT PATCH v7 5/9] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure gyungoh
` (3 subsequent siblings)
9 siblings, 0 replies; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Nothing
Changes v6:
Nothing
Changes v5:
Nothing
Changes v4:
Nothing
Changes v3:
Nothing
Changes v2:
Add SKY81452 to the Trivial Devices list
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index fbde415..122fa1e 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -77,6 +77,7 @@ ramtron,24c64 i2c serial eeprom (24cxx)
ricoh,rs5c372a I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
samsung,24ad0xd1 S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
sii,s35390a 2-wire CMOS real-time clock
+skyworks,sky81452 Skyworks SKY81452: Six-Channel White LED Driver with Touch Panel Bias Supply
st-micro,24c256 i2c serial eeprom (24cxx)
stm,m41t00 Serial Access TIMEKEEPER
stm,m41t62 Serial real-time clock (RTC) with alarm
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
` (5 preceding siblings ...)
2014-11-17 8:33 ` [RESUBMIT PATCH v7 6/9] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 14:18 ` Mark Brown
2014-11-17 8:33 ` [RESUBMIT PATCH v7 8/9] devicetree: " gyungoh
` (2 subsequent siblings)
9 siblings, 1 reply; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Modified licensing text to GPLv2
Splitted Kconfig renaming from DT patch
Changes v6:
Added new line character at the end of line of dev_err()
Changes v5:
Changed DT for regulator : 'lout' node should be defined under 'regulator'
Removed compatible string
Modified to return EINVAL when of_node is NULL
Changes v4:
Removed MODULE_VERSION()
Modified license to GPLv2
Changes v3:
Modified to return ENODATA when of_node is NULL
Modified the messages in error cases
Changes v2:
Added 'compatible' attribute in the driver
Added message for exception or errors.
drivers/regulator/sky81452-regulator.c | 34 +++++++++++++++++++++-------------
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/regulator/sky81452-regulator.c b/drivers/regulator/sky81452-regulator.c
index 97aff0c..36fa045 100644
--- a/drivers/regulator/sky81452-regulator.c
+++ b/drivers/regulator/sky81452-regulator.c
@@ -5,9 +5,8 @@
* Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
*
* This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation; either version 2, or (at your option) any
- * later version.
+ * under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -65,21 +64,29 @@ static const struct regulator_desc sky81452_reg = {
};
#ifdef CONFIG_OF
+static struct of_regulator_match sky81452_match = {
+ .name = "lout"
+};
+
static struct regulator_init_data *sky81452_reg_parse_dt(struct device *dev)
{
- struct regulator_init_data *init_data;
struct device_node *np;
+ int ret;
np = of_get_child_by_name(dev->parent->of_node, "regulator");
- if (unlikely(!np)) {
- dev_err(dev, "regulator node not found");
- return NULL;
+ if (!np) {
+ dev_err(dev, "regulator node not found.\n");
+ return ERR_PTR(-EINVAL);
}
- init_data = of_get_regulator_init_data(dev, np);
-
+ ret = of_regulator_match(dev, np, &sky81452_match, 1);
of_node_put(np);
- return init_data;
+ if (IS_ERR_VALUE(ret)) {
+ dev_err(dev, "Error parsing init data. err=%d\n", ret);
+ return ERR_PTR(ret);
+ }
+
+ return &sky81452_match.init_data;
}
#else
static struct regulator_init_data *sky81452_reg_parse_dt(struct device *dev)
@@ -107,8 +114,10 @@ static int sky81452_reg_probe(struct platform_device *pdev)
config.regmap = dev_get_drvdata(dev->parent);
rdev = devm_regulator_register(dev, &sky81452_reg, &config);
- if (IS_ERR(rdev))
+ if (IS_ERR(rdev)) {
+ dev_err(dev, "failed to register. err=%ld\n", PTR_ERR(rdev));
return PTR_ERR(rdev);
+ }
platform_set_drvdata(pdev, rdev);
@@ -126,5 +135,4 @@ module_platform_driver(sky81452_reg_driver);
MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver");
MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
-MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
+MODULE_LICENSE("GPL v2");
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure
2014-11-17 8:33 ` [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure gyungoh
@ 2014-11-17 14:18 ` Mark Brown
2014-11-18 8:04 ` Gyungoh Yoo
0 siblings, 1 reply; 19+ messages in thread
From: Mark Brown @ 2014-11-17 14:18 UTC (permalink / raw)
To: gyungoh
Cc: sameo, lee.jones, jg1.han, cooloney, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
On Mon, Nov 17, 2014 at 05:33:08PM +0900, gyungoh@gmail.com wrote:
> np = of_get_child_by_name(dev->parent->of_node, "regulator");
> + ret = of_regulator_match(dev, np, &sky81452_match, 1);
Don't open code this, use regulators_node and of_match as previously
advised.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure
2014-11-17 14:18 ` Mark Brown
@ 2014-11-18 8:04 ` Gyungoh Yoo
2014-11-18 11:20 ` Mark Brown
0 siblings, 1 reply; 19+ messages in thread
From: Gyungoh Yoo @ 2014-11-18 8:04 UTC (permalink / raw)
To: Mark Brown
Cc: sameo, lee.jones, jg1.han, cooloney, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
On Mon, Nov 17, 2014 at 02:18:36PM +0000, Mark Brown wrote:
> On Mon, Nov 17, 2014 at 05:33:08PM +0900, gyungoh@gmail.com wrote:
>
> > np = of_get_child_by_name(dev->parent->of_node, "regulator");
>
> > + ret = of_regulator_match(dev, np, &sky81452_match, 1);
>
> Don't open code this, use regulators_node and of_match as previously
> advised.
I think I had a misunderstanding.
But I have no idea about regulators_node and of_match.
Could you let me know more about them?
Thanks.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure
2014-11-18 8:04 ` Gyungoh Yoo
@ 2014-11-18 11:20 ` Mark Brown
2014-11-19 7:39 ` Gyungoh Yoo
0 siblings, 1 reply; 19+ messages in thread
From: Mark Brown @ 2014-11-18 11:20 UTC (permalink / raw)
To: Gyungoh Yoo
Cc: sameo, lee.jones, jg1.han, cooloney, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Tue, Nov 18, 2014 at 05:04:51PM +0900, Gyungoh Yoo wrote:
> On Mon, Nov 17, 2014 at 02:18:36PM +0000, Mark Brown wrote:
> > Don't open code this, use regulators_node and of_match as previously
> > advised.
> I think I had a misunderstanding.
> But I have no idea about regulators_node and of_match.
> Could you let me know more about them?
They are fields in regulator_desc, there are documentation and examples
in current mainline - take a look at that and ask questions if it is
unclear.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure
2014-11-18 11:20 ` Mark Brown
@ 2014-11-19 7:39 ` Gyungoh Yoo
2014-11-19 10:14 ` Mark Brown
0 siblings, 1 reply; 19+ messages in thread
From: Gyungoh Yoo @ 2014-11-19 7:39 UTC (permalink / raw)
To: Mark Brown
Cc: sameo, lee.jones, jg1.han, cooloney, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
On Tue, Nov 18, 2014 at 11:20:56AM +0000, Mark Brown wrote:
> On Tue, Nov 18, 2014 at 05:04:51PM +0900, Gyungoh Yoo wrote:
> > On Mon, Nov 17, 2014 at 02:18:36PM +0000, Mark Brown wrote:
>
> > > Don't open code this, use regulators_node and of_match as previously
> > > advised.
>
> > I think I had a misunderstanding.
> > But I have no idea about regulators_node and of_match.
> > Could you let me know more about them?
>
> They are fields in regulator_desc, there are documentation and examples
> in current mainline - take a look at that and ask questions if it is
> unclear.
Okay. Thank you.
If of_match and regulators_node are assigned, don't I need to
call of_regulator_match()? Does regulator_register() call it internally?
So can I write code like below?
static const struct regulator_desc sky81452_reg = {
.name = "LOUT",
.of_match = of_match_ptr("lout"),
.regulators_node = of_match_ptr("regulator"),
.ops = &sky81452_reg_ops,
...
};
static int sky81452_reg_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
const struct regulator_init_data *init_data = dev_get_platdata(dev);
struct regulator_config config = { };
struct regulator_dev *rdev;
config.dev = dev->parent;
config.init_data = init_data;
config.of_node = dev->of_node;
config.regmap = dev_get_drvdata(dev->parent);
rdev = devm_regulator_register(dev, &sky81452_reg, &config);
if (IS_ERR(rdev)) {
dev_err(dev, "failed to register. err=%ld\n", PTR_ERR(rdev));
return PTR_ERR(rdev);
}
platform_set_drvdata(pdev, rdev);
return 0;
}
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure
2014-11-19 7:39 ` Gyungoh Yoo
@ 2014-11-19 10:14 ` Mark Brown
0 siblings, 0 replies; 19+ messages in thread
From: Mark Brown @ 2014-11-19 10:14 UTC (permalink / raw)
To: Gyungoh Yoo
Cc: sameo, lee.jones, jg1.han, cooloney, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On Wed, Nov 19, 2014 at 04:39:54PM +0900, Gyungoh Yoo wrote:
> If of_match and regulators_node are assigned, don't I need to
> call of_regulator_match()? Does regulator_register() call it internally?
> So can I write code like below?
>
> static const struct regulator_desc sky81452_reg = {
> .name = "LOUT",
> .of_match = of_match_ptr("lout"),
> .regulators_node = of_match_ptr("regulator"),
> .ops = &sky81452_reg_ops,
> ...
> };
> config.regmap = dev_get_drvdata(dev->parent);
>
> rdev = devm_regulator_register(dev, &sky81452_reg, &config);
Yes, exactly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* [RESUBMIT PATCH v7 8/9] devicetree: regulator: sky81452: Modify Device Tree structure
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
` (6 preceding siblings ...)
2014-11-17 8:33 ` [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 9/9] regulator: sky81452: Modify dependent Kconfig symbol gyungoh
2014-11-17 13:37 ` [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers Mark Brown
9 siblings, 0 replies; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Nothing
Changes v6:
Nothing
Changes v5:
Changed DT for regulator : 'lout' node should be defined under 'regulator'
Removed compatible string from sky81452-regulator driver
Changes v4:
Nothing
Changes v3:
Nothing
Changes v2:
Added 'compatible' attribute in the driver
.../devicetree/bindings/regulator/sky81452-regulator.txt | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/sky81452-regulator.txt b/Documentation/devicetree/bindings/regulator/sky81452-regulator.txt
index 882455e..f9acbc1 100644
--- a/Documentation/devicetree/bindings/regulator/sky81452-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/sky81452-regulator.txt
@@ -1,6 +1,7 @@
SKY81452 voltage regulator
Required properties:
+- regulator node named lout.
- any required generic properties defined in regulator.txt
Optional properties:
@@ -9,8 +10,9 @@ Optional properties:
Example:
regulator {
- /* generic regulator properties */
- regulator-name = "touch_en";
- regulator-min-microvolt = <4500000>;
- regulator-max-microvolt = <8000000>;
+ lout {
+ regulator-name = "sky81452-lout";
+ regulator-min-microvolt = <4500000>;
+ regulator-max-microvolt = <8000000>;
+ };
};
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [RESUBMIT PATCH v7 9/9] regulator: sky81452: Modify dependent Kconfig symbol
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
` (7 preceding siblings ...)
2014-11-17 8:33 ` [RESUBMIT PATCH v7 8/9] devicetree: " gyungoh
@ 2014-11-17 8:33 ` gyungoh
2014-11-17 14:19 ` Mark Brown
2014-11-17 13:37 ` [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers Mark Brown
9 siblings, 1 reply; 19+ messages in thread
From: gyungoh @ 2014-11-17 8:33 UTC (permalink / raw)
To: sameo, lee.jones, jg1.han, cooloney, broonie, lgirdwood
Cc: jack.yoo, linux-kernel, devicetree, grant.likely, robh+dt,
mark.rutland, ijc+devicetree, galak, pawel.moll, heiko, jason,
shawn.guo, treding, florian.vaussard, trivial, linux, andrew,
jic23
From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
---
Changes v7:
Splitted Kconfig renaming from DT patch
drivers/regulator/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 55d7b7b..fe84bd4 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -547,7 +547,7 @@ config REGULATOR_S5M8767
config REGULATOR_SKY81452
tristate "Skyworks Solutions SKY81452 voltage regulator"
- depends on SKY81452
+ depends on MFD_SKY81452
help
This driver supports Skyworks SKY81452 voltage output regulator
via I2C bus. SKY81452 has one voltage linear regulator can be
--
1.9.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [RESUBMIT PATCH v7 9/9] regulator: sky81452: Modify dependent Kconfig symbol
2014-11-17 8:33 ` [RESUBMIT PATCH v7 9/9] regulator: sky81452: Modify dependent Kconfig symbol gyungoh
@ 2014-11-17 14:19 ` Mark Brown
0 siblings, 0 replies; 19+ messages in thread
From: Mark Brown @ 2014-11-17 14:19 UTC (permalink / raw)
To: gyungoh
Cc: sameo, lee.jones, jg1.han, cooloney, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
[-- Attachment #1: Type: text/plain, Size: 132 bytes --]
On Mon, Nov 17, 2014 at 05:33:10PM +0900, gyungoh@gmail.com wrote:
> From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
` (8 preceding siblings ...)
2014-11-17 8:33 ` [RESUBMIT PATCH v7 9/9] regulator: sky81452: Modify dependent Kconfig symbol gyungoh
@ 2014-11-17 13:37 ` Mark Brown
9 siblings, 0 replies; 19+ messages in thread
From: Mark Brown @ 2014-11-17 13:37 UTC (permalink / raw)
To: gyungoh
Cc: sameo, lee.jones, jg1.han, cooloney, lgirdwood, jack.yoo,
linux-kernel, devicetree, grant.likely, robh+dt, mark.rutland,
ijc+devicetree, galak, pawel.moll, heiko, jason, shawn.guo,
treding, florian.vaussard, trivial, linux, andrew, jic23
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Mon, Nov 17, 2014 at 05:33:01PM +0900, gyungoh@gmail.com wrote:
> From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
>
> This patch set includes regulator and backlight driver for SKY81452.
> Also it includes documents for device tree and module.
> The initial version of sky81452-regulator was applied. Fo this, incremental
> patches are included.
Don't include things like RESUBMIT which just point out the obvious in
your subject lines since it obscures useful content. What I'm seeing in
my inbox is things like:
307 N T 11/17 gyungoh@gmail.c (3.1K) ├─>[RESUBMIT PATCH v7 7/9] regulator: s
which don't give any indication if there's something important to be
looked at.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread