[PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable

[PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable

[Cass May]

Clean up Makefile by removing unnecessary definition of DG_NAME.

Signed-off-by: Cass May <cass@cassm.net>
---
Having done some build tests, it seems that DG_NAME is not needed, 
but DG_PART is referenced in dgnc_mgmt.c. I have removed the former, 
and moved the latter into the appropriate header. 

 drivers/staging/dgnc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
index b69f7b6..84cc98d 100644
--- a/drivers/staging/dgnc/Makefile
+++ b/drivers/staging/dgnc/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
+EXTRA_CFLAGS += -DDG_PART=\"40002369_F\"
 
 obj-$(CONFIG_DGNC) += dgnc.o
 
-- 
2.1.4

[PATCH 2/2] dgnc: Move DG_PART definition from Makefile to dgnc_driver.h

[Cass May]

Avoid deprecated usage of EXTRA_CFLAGS by moving definition of DG_PART into dgnc_driver.h

Signed-off-by: Cass May <cass@cassm.net>
---
 drivers/staging/dgnc/Makefile      | 2 --
 drivers/staging/dgnc/dgnc_driver.h | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
index 84cc98d..995c874 100644
--- a/drivers/staging/dgnc/Makefile
+++ b/drivers/staging/dgnc/Makefile
@@ -1,5 +1,3 @@
-EXTRA_CFLAGS += -DDG_PART=\"40002369_F\"
-
 obj-$(CONFIG_DGNC) += dgnc.o
 
 dgnc-objs :=   dgnc_cls.o dgnc_driver.o\
diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
index a8157eb..dd715eb 100644
--- a/drivers/staging/dgnc/dgnc_driver.h
+++ b/drivers/staging/dgnc/dgnc_driver.h
@@ -46,6 +46,7 @@
 #define	PROCSTR		"dgnc"			/* /proc entries	 */
 #define	DEVSTR		"/dev/dg/dgnc"		/* /dev entries		 */
 #define	DRVSTR		"dgnc"			/* Driver name string	 */
+#define	DG_PART		"40002369_F"		/* RPM part number	 */
 
 #define TRC_TO_CONSOLE 1
 
-- 
2.1.4

Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable

[Dan Carpenter]

On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote:
> Clean up Makefile by removing unnecessary definition of DG_NAME.
> 
> Signed-off-by: Cass May <cass@cassm.net>
> ---
> Having done some build tests, it seems that DG_NAME is not needed, 
> but DG_PART is referenced in dgnc_mgmt.c. I have removed the former, 
> and moved the latter into the appropriate header. 

Thanks!

Don't resend; this patch is great.  But next time just fold both patches
together into one patch.  It's all part of the same fix really so it
falls into the "one thing per patch" rule.

regards,
dan carpenter

Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable

[Cass May]

On Mon, 2015-02-16 at 12:12 +0300, Dan Carpenter wrote:
> On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote:
> > Clean up Makefile by removing unnecessary definition of DG_NAME.
> > 
> > Signed-off-by: Cass May <cass@cassm.net>
> > ---
> > Having done some build tests, it seems that DG_NAME is not needed, 
> > but DG_PART is referenced in dgnc_mgmt.c. I have removed the former, 
> > and moved the latter into the appropriate header. 
> 
> Thanks!
> 
> Don't resend; this patch is great.  But next time just fold both patches
> together into one patch.  It's all part of the same fix really so it
> falls into the "one thing per patch" rule.
> 
> regards,
> dan carpenter

Shall do! Thank you for the guidance. 

-cass