From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Aleksa Sarai <cyphar@cyphar.com>,
lizefan@huawei.com, mingo@redhat.com, richard@nod.at,
fweisbec@gmail.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v10 1/4] cgroups: use bitmask to filter for_each_subsys
Date: Wed, 22 Apr 2015 17:42:12 +0200 [thread overview]
Message-ID: <20150422154212.GE3007@worktop.Skamania.guest> (raw)
In-Reply-To: <20150422152551.GA10738@htj.duckdns.org>
On Wed, Apr 22, 2015 at 11:25:51AM -0400, Tejun Heo wrote:
> Hello, Aleksa.
>
> On Sun, Apr 19, 2015 at 10:22:31PM +1000, Aleksa Sarai wrote:
> > -static int need_forkexit_callback __read_mostly;
> > +static int need_fork_callback __read_mostly;
> > +static int need_exit_callback __read_mostly;
>
> These are bitmasks now, right? Let's make them unsigned int.
If, as per the below you want to use the bitmap ops; it needs be
unsigned long.
> > static struct cftype cgroup_dfl_base_files[];
> > +#define for_each_subsys_which(ss_mask, ss, ssid) \
> > + for_each_subsys((ss), (ssid)) \
> > + if ((ss_mask) & (1 << (ssid)))
>
> Maybe using for_each_set_bit() is better?
>
> #define for_each_subsys_which(ss_mask, ss, ssid) \
> for_each_set_bit(ssid, &(ss_mask), CGROUP_SUBSYS_COUNT) \
> if ((ss) = group_subsys[ssid] && false) \
> ; \
> else
Clever that ;-)
next prev parent reply other threads:[~2015-04-22 15:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 12:22 [PATCH v10 0/4] cgroups: add pids subsystem Aleksa Sarai
2015-04-19 12:22 ` [PATCH v10 1/4] cgroups: use bitmask to filter for_each_subsys Aleksa Sarai
2015-04-22 15:25 ` Tejun Heo
2015-04-22 15:42 ` Peter Zijlstra [this message]
2015-04-22 16:02 ` Tejun Heo
2015-04-26 16:05 ` Aleksa Sarai
2015-04-26 16:09 ` Tejun Heo
2015-05-13 5:44 ` Aleksa Sarai
2015-05-13 13:50 ` Tejun Heo
2015-04-22 15:30 ` Tejun Heo
2015-04-19 12:22 ` [PATCH v10 2/4] cgroups: replace explicit ss_mask checking with for_each_subsys_which Aleksa Sarai
2015-04-22 15:31 ` Tejun Heo
2015-04-19 12:22 ` [PATCH v10 3/4] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-04-22 15:54 ` Tejun Heo
2015-04-24 13:59 ` Aleksa Sarai
2015-04-24 15:48 ` Tejun Heo
2015-05-14 10:57 ` Aleksa Sarai
2015-05-14 15:08 ` Tejun Heo
2015-04-19 12:22 ` [PATCH v10 4/4] cgroups: implement the PIDs subsystem Aleksa Sarai
2015-04-22 16:29 ` Tejun Heo
2015-04-23 0:43 ` Aleksa Sarai
2015-04-24 15:36 ` Tejun Heo
2015-05-13 17:04 ` Aleksa Sarai
2015-05-13 17:29 ` Tejun Heo
2015-05-13 17:44 ` Aleksa Sarai
2015-05-13 17:47 ` Tejun Heo
2015-05-16 3:59 ` Aleksa Sarai
2015-05-18 1:24 ` Tejun Heo
2015-04-24 14:24 ` Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422154212.GE3007@worktop.Skamania.guest \
--to=peterz@infradead.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).