From: Aleksa Sarai <cyphar@cyphar.com>
To: Tejun Heo <tj@kernel.org>
Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org,
richard@nod.at, "Frédéric Weisbecker" <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v10 4/4] cgroups: implement the PIDs subsystem
Date: Sat, 25 Apr 2015 00:24:08 +1000 [thread overview]
Message-ID: <CAOviyahq6kr8Q-sXHHmwrZmFrPfj-kJ8QjUYNceRZAG1ZfLv_A@mail.gmail.com> (raw)
In-Reply-To: <20150422162954.GF10738@htj.duckdns.org>
Also,
>> +struct pids_cgroup {
>> + struct cgroup_subsys_state css;
>> +
>> + /*
>> + * Use 64-bit types so that we can safely represent "max" as
>> + * (PID_MAX_LIMIT + 1).
> ^^^^^^^^^^^^^^^^^
> ...
>> +static struct cgroup_subsys_state *
>> +pids_css_alloc(struct cgroup_subsys_state *parent)
>> +{
>> + struct pids_cgroup *pids;
>> +
>> + pids = kzalloc(sizeof(struct pids_cgroup), GFP_KERNEL);
>> + if (!pids)
>> + return ERR_PTR(-ENOMEM);
>> +
>> + pids->limit = PIDS_MAX;
> ^^^^^^^^^
%PIDS_MAX = (%PID_MAX_LIMIT + 1). I can clarify this in the comments
if you want.
--
Aleksa Sarai (cyphar)
www.cyphar.com
next prev parent reply other threads:[~2015-04-24 14:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 12:22 [PATCH v10 0/4] cgroups: add pids subsystem Aleksa Sarai
2015-04-19 12:22 ` [PATCH v10 1/4] cgroups: use bitmask to filter for_each_subsys Aleksa Sarai
2015-04-22 15:25 ` Tejun Heo
2015-04-22 15:42 ` Peter Zijlstra
2015-04-22 16:02 ` Tejun Heo
2015-04-26 16:05 ` Aleksa Sarai
2015-04-26 16:09 ` Tejun Heo
2015-05-13 5:44 ` Aleksa Sarai
2015-05-13 13:50 ` Tejun Heo
2015-04-22 15:30 ` Tejun Heo
2015-04-19 12:22 ` [PATCH v10 2/4] cgroups: replace explicit ss_mask checking with for_each_subsys_which Aleksa Sarai
2015-04-22 15:31 ` Tejun Heo
2015-04-19 12:22 ` [PATCH v10 3/4] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-04-22 15:54 ` Tejun Heo
2015-04-24 13:59 ` Aleksa Sarai
2015-04-24 15:48 ` Tejun Heo
2015-05-14 10:57 ` Aleksa Sarai
2015-05-14 15:08 ` Tejun Heo
2015-04-19 12:22 ` [PATCH v10 4/4] cgroups: implement the PIDs subsystem Aleksa Sarai
2015-04-22 16:29 ` Tejun Heo
2015-04-23 0:43 ` Aleksa Sarai
2015-04-24 15:36 ` Tejun Heo
2015-05-13 17:04 ` Aleksa Sarai
2015-05-13 17:29 ` Tejun Heo
2015-05-13 17:44 ` Aleksa Sarai
2015-05-13 17:47 ` Tejun Heo
2015-05-16 3:59 ` Aleksa Sarai
2015-05-18 1:24 ` Tejun Heo
2015-04-24 14:24 ` Aleksa Sarai [this message]
2015-04-24 14:07 Aleksa Sarai
2015-04-24 15:26 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOviyahq6kr8Q-sXHHmwrZmFrPfj-kJ8QjUYNceRZAG1ZfLv_A@mail.gmail.com \
--to=cyphar@cyphar.com \
--cc=cgroups@vger.kernel.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).