linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com,
	cw00.choi@samsung.com, myungjoo.ham@samsung.com,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	ckeepax@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver
Date: Tue, 5 May 2015 14:31:29 +0100	[thread overview]
Message-ID: <20150505133129.GA26101@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150505105327.GZ22845@sirena.org.uk>

> 
> > > > +static const char * const wm8998_inmux_texts[] = {
> > > > +	"A",
> > > > +	"B",
> 
> > > Those are some fun input names...
> 
> > ... that's what the mux positions are called and it seems nice to have consistent
> > naming for all similar muxes across channels and across future codecs. Like for
> > example to switch both muxes of a stereo input you set them both to the same
> > position name (both "A" or both "B") is clearer, and quicker to spot in a dump
> > of ALSA control settings, than having the two muxes set to different enumeration
> > strings that actually mean the same mux position.
> 
> Equally when setting the muxes settings called A and B that's not really
> telling people what they do.

We can't really tell people what the selection does because that depends on
the external hardware. The A setting might be a headset mic, or a line in,
or a builtin mic...

All we can do is say what the selection is called generically by the codec.
So take the IN1L signal, on the codec it has two inputs "A" and "B". The
IN1L Mux control has two settings "A" and "B". That seems clear.

  reply	other threads:[~2015-05-05 13:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 15:15 [PATCH v3 0/8] Add support for Wolfson WM8998 and WM1814 codecs Richard Fitzgerald
2015-05-01 15:15 ` [PATCH v3 1/8] mfd: arizona: Split INx_MODE into two fields Richard Fitzgerald
2015-05-13 12:28   ` Lee Jones
2015-05-01 15:15 ` [PATCH v3 2/8] ASoC: arizona: add defines for single-input gain control Richard Fitzgerald
2015-05-01 15:15 ` [PATCH v3 3/8] mfd: arizona: Add support for WM8998 and WM1814 Richard Fitzgerald
2015-05-02  9:58   ` Paul Bolle
2015-05-04  9:11     ` Richard Fitzgerald
2015-05-04 10:44       ` Paul Bolle
2015-05-07  8:52   ` Lee Jones
2015-05-08  9:11     ` Richard Fitzgerald
2015-05-01 15:15 ` [PATCH v3 4/8] gpio: arizona: add " Richard Fitzgerald
2015-05-01 15:15 ` [PATCH v3 5/8] regulator: " Richard Fitzgerald
2015-05-01 15:15 ` [PATCH v3 6/8] extcon: arizona: Add " Richard Fitzgerald
2015-05-01 15:15 ` [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver Richard Fitzgerald
2015-05-04 11:39   ` Mark Brown
2015-05-05  9:24     ` Richard Fitzgerald
2015-05-05 10:53       ` Mark Brown
2015-05-05 13:31         ` Richard Fitzgerald [this message]
2015-05-05 21:59           ` Mark Brown
2015-05-06  9:24             ` Richard Fitzgerald
2015-05-06 11:48               ` Mark Brown
2015-05-06 12:21                 ` Richard Fitzgerald
2015-05-06 12:34                   ` Mark Brown
2015-05-01 15:15 ` [PATCH v3 8/8] Documentation: Add WM8998/WM1814 device tree bindings Richard Fitzgerald
2015-05-13 12:29   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150505133129.GA26101@opensource.wolfsonmicro.com \
    --to=rf@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).