Re: [PATCH v3 7/8] ASoC: wm8998: Initial WM8998 codec driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

On Tue, May 05, 2015 at 02:31:29PM +0100, Richard Fitzgerald wrote:

> We can't really tell people what the selection does because that depends on
> the external hardware. The A setting might be a headset mic, or a line in,
> or a builtin mic...

> All we can do is say what the selection is called generically by the codec.
> So take the IN1L signal, on the codec it has two inputs "A" and "B". The
> IN1L Mux control has two settings "A" and "B". That seems clear.

So you're saying that you've got a mux on a single physical input which
has two inputs?  Are you sure that this is actually a mux and not some
sort of mode setting that should be in platform data or DT - what do
these settinngs actually correspond to?  The routes in the driver look
like there's two physical pins for each one of IN1L/R which the device
can switch between for some reason which does correspond to a mux but
that'd more normally be named IN1AL or similar.

Though if the left and right side need to be set to the same thing
(which IIRC a previous version had code to check for and you did mention
in your mail) all the time then why are there two separate muxes anyway?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]