* [PATCH] staging: rtl8192u: Patch to modify if, else conditions
@ 2015-05-19 16:55 Dhere, Chaitanya (C.)
2015-05-31 1:38 ` gregkh
0 siblings, 1 reply; 4+ messages in thread
From: Dhere, Chaitanya (C.) @ 2015-05-19 16:55 UTC (permalink / raw)
To: gregkh, cristina.opriceana, hamohammed.sa, gdonald,
mahfouz.saif.elyazal, benoit.taine, paul.gortmaker
Cc: devel, linux-kernel
In this patch:
1. the if condition is modified to remove
the unnecessary equality check.
2. The else if condition is replaced by an else condition
since the variable checked in the if statement is a bool
making the else if unnecessary.
3. Fixed indentation problem on line 1369.
These changes were detected with help of coccinelle tool.
Signed-off-by: Chaitanya Dhere <cvijaydh@visteon.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d2e8b12..41f74ab 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -1364,12 +1364,11 @@ static void ieee80211_associate_complete_wq(struct work_struct *work)
ieee->LinkDetectInfo.NumRecvDataInPeriod= 1;
}
ieee->link_change(ieee->dev);
- if(ieee->is_silent_reset == 0){
+ if (!ieee->is_silent_reset) {
printk("============>normal associate\n");
- notify_wx_assoc_event(ieee);
+ notify_wx_assoc_event(ieee);
}
- else if(ieee->is_silent_reset == 1)
- {
+ else {
printk("==================>silent reset associate\n");
ieee->is_silent_reset = false;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions
2015-05-19 16:55 [PATCH] staging: rtl8192u: Patch to modify if, else conditions Dhere, Chaitanya (C.)
@ 2015-05-31 1:38 ` gregkh
2015-06-01 5:40 ` Dhere, Chaitanya (C.)
2015-06-02 5:13 ` Dhere, Chaitanya (C.)
0 siblings, 2 replies; 4+ messages in thread
From: gregkh @ 2015-05-31 1:38 UTC (permalink / raw)
To: Dhere, Chaitanya (C.)
Cc: cristina.opriceana, hamohammed.sa, gdonald, mahfouz.saif.elyazal,
benoit.taine, paul.gortmaker, devel, linux-kernel
On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> In this patch:
> 1. the if condition is modified to remove
> the unnecessary equality check.
> 2. The else if condition is replaced by an else condition
> since the variable checked in the if statement is a bool
> making the else if unnecessary.
> 3. Fixed indentation problem on line 1369.
> These changes were detected with help of coccinelle tool.
3 different things means you need to send 3 different patches. Please
only do one logical thing per patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions
2015-05-31 1:38 ` gregkh
@ 2015-06-01 5:40 ` Dhere, Chaitanya (C.)
2015-06-02 5:13 ` Dhere, Chaitanya (C.)
1 sibling, 0 replies; 4+ messages in thread
From: Dhere, Chaitanya (C.) @ 2015-06-01 5:40 UTC (permalink / raw)
To: gregkh
Cc: cristina.opriceana, hamohammed.sa, gdonald, mahfouz.saif.elyazal,
benoit.taine, paul.gortmaker, devel, linux-kernel
On Sun, May 31, 2015 at 10:38:18AM +0900, gregkh@linuxfoundation.org wrote:
> On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> > In this patch:
> > 1. the if condition is modified to remove
> > the unnecessary equality check.
> > 2. The else if condition is replaced by an else condition
> > since the variable checked in the if statement is a bool
> > making the else if unnecessary.
> > 3. Fixed indentation problem on line 1369.
> > These changes were detected with help of coccinelle tool.
>
> 3 different things means you need to send 3 different patches. Please
> only do one logical thing per patch.
>
> thanks,
>
> greg k-h
Ok Greg I will send a V2 of my patch split into 3 patches
Thanks,
Chaitanya Dhere
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions
2015-05-31 1:38 ` gregkh
2015-06-01 5:40 ` Dhere, Chaitanya (C.)
@ 2015-06-02 5:13 ` Dhere, Chaitanya (C.)
1 sibling, 0 replies; 4+ messages in thread
From: Dhere, Chaitanya (C.) @ 2015-06-02 5:13 UTC (permalink / raw)
To: sudipm.mukherjee
Cc: cristina.opriceana, hamohammed.sa, gdonald, mahfouz.saif.elyazal,
benoit.taine, paul.gortmaker, gregkh, devel, linux-kernel
On Sun, May 31, 2015 at 10:38:18AM +0900, gregkh@linuxfoundation.org wrote:
> On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> > In this patch:
> > 1. the if condition is modified to remove
> > the unnecessary equality check.
> > 2. The else if condition is replaced by an else condition
> > since the variable checked in the if statement is a bool
> > making the else if unnecessary.
> > 3. Fixed indentation problem on line 1369.
> > These changes were detected with help of coccinelle tool.
>
> 3 different things means you need to send 3 different patches. Please
> only do one logical thing per patch.
>
> thanks,
>
> greg k-h
Hello,
I will make the correction in subject and resend the patch
Thanks,
chaitanya
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-02 5:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-19 16:55 [PATCH] staging: rtl8192u: Patch to modify if, else conditions Dhere, Chaitanya (C.)
2015-05-31 1:38 ` gregkh
2015-06-01 5:40 ` Dhere, Chaitanya (C.)
2015-06-02 5:13 ` Dhere, Chaitanya (C.)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).