From: Jonathan McDowell <noodles@earth.li>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Mihai Donțu" <mihai.dontu@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Audio crackles with 4.1-rc1
Date: Sun, 14 Jun 2015 13:24:20 +0100 [thread overview]
Message-ID: <20150614122420.GT28070@earth.li> (raw)
In-Reply-To: <s5hk2v9hv5v.wl-tiwai@suse.de>
On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote:
> At Fri, 12 Jun 2015 12:09:55 +0200,
> Takashi Iwai wrote:
> > At Fri, 12 Jun 2015 12:45:23 +0300,
> > Mihai Donțu wrote:
> > > Nice shot! It appears to work. :-) No clicks, no static.
> >
> > Good to hear!
> >
> > > I had to apply it by hand over 4.1-rc7, because the first two arrays
> > > look different in both it and -master. Anyway, I will play with it some
> > > more today see if anything else is broken.
> >
> > While we are at it: could you try to enable codec->power_save_node in
> > patch_alc269() (while keeping the new patch)?
> >
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5671,8 +5671,7 @@ static int patch_alc269(struct hda_codec *codec)
> >
> > spec = codec->spec;
> > spec->gen.shared_mic_vref_pin = 0x18;
> > - if (codec->core.vendor_id != 0x10ec0292)
> > - codec->power_save_node = 1;
> > + codec->power_save_node = 1;
> >
> > #ifdef CONFIG_PM
> > codec->patch_ops.suspend = alc269_suspend;
>
> For your convenience, below is the combined patch for 4.1.
>
> Jonathan, could you also try this patch and see whether you still get
> the noise?
Applying the combined patch to 4.1-rc7 I'm not getting any noise on the
transition from suspended to active.
J.
--
101 things you can't have too | .''`. Debian GNU/Linux Developer
much of : 47 - More coffee. | : :' : Happy to accept PGP signed
| `. `' or encrypted mail - RSA
| `- key on the keyservers.
next prev parent reply other threads:[~2015-06-14 12:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 11:21 Audio crackles with 4.1-rc1 Jonathan McDowell
2015-04-28 12:00 ` Takashi Iwai
2015-04-28 12:35 ` Jonathan McDowell
2015-04-28 13:05 ` Takashi Iwai
2015-04-28 14:43 ` Takashi Iwai
2015-04-29 11:28 ` Jonathan McDowell
2015-04-29 11:54 ` Takashi Iwai
2015-04-30 15:01 ` Jonathan McDowell
2015-04-30 17:06 ` Takashi Iwai
2015-05-02 15:05 ` Jonathan McDowell
2015-05-19 6:15 ` Takashi Iwai
2015-05-19 16:19 ` Jonathan McDowell
2015-05-19 17:09 ` Takashi Iwai
2015-05-19 21:53 ` Jonathan McDowell
2015-05-20 5:01 ` Takashi Iwai
2015-05-20 20:02 ` Jonathan McDowell
2015-06-10 10:17 ` Mihai Donțu
2015-06-10 10:22 ` Takashi Iwai
2015-06-10 10:41 ` Mihai Donțu
2015-06-10 10:50 ` Takashi Iwai
2015-06-10 11:45 ` Mihai Donțu
2015-06-10 12:33 ` Takashi Iwai
2015-06-10 12:50 ` Takashi Iwai
2015-06-10 16:22 ` Mihai Donțu
2015-06-10 16:27 ` Takashi Iwai
2015-06-10 16:43 ` Mihai Donțu
2015-06-10 18:23 ` Takashi Iwai
2015-06-10 22:12 ` Mihai Donțu
2015-06-11 5:01 ` Takashi Iwai
2015-06-11 22:23 ` Mihai Donțu
2015-06-12 7:00 ` Takashi Iwai
2015-06-12 9:45 ` Mihai Donțu
2015-06-12 10:09 ` Takashi Iwai
2015-06-12 14:13 ` Takashi Iwai
2015-06-12 17:28 ` Mihai Donțu
2015-06-14 12:24 ` Jonathan McDowell [this message]
2015-06-15 12:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150614122420.GT28070@earth.li \
--to=noodles@earth.li \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.dontu@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).