linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jonathan McDowell <noodles@earth.li>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Audio crackles with 4.1-rc1
Date: Tue, 19 May 2015 19:09:12 +0200	[thread overview]
Message-ID: <s5hr3qctryf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150519161911.GD28070@earth.li>

At Tue, 19 May 2015 17:19:11 +0100,
Jonathan McDowell wrote:
> 
> On Tue, May 19, 2015 at 08:15:32AM +0200, Takashi Iwai wrote:
> > At Sat, 2 May 2015 16:05:13 +0100,
> > Jonathan McDowell wrote:
> > > 
> > > On Thu, Apr 30, 2015 at 07:06:31PM +0200, Takashi Iwai wrote:
> > > > At Thu, 30 Apr 2015 16:01:31 +0100, Jonathan McDowell wrote:
> > > > > 
> > > > > On Wed, Apr 29, 2015 at 01:54:57PM +0200, Takashi Iwai wrote:
> > > > > > 
> > > > > > One patch you can try (with or without power_save_node
> > > > > > disablement) is below, it squashes the verb sequences at (runtime)
> > > > > > PM resume as we did for 4.0.  Let me know if this changes the
> > > > > > behavior.
> > > > > 
> > > > > Patch alone has no effect. Patch with power_save_node disablement
> > > > > solves the problem. Didn't try power_save_node disablement without
> > > > > the patch.
> > > > 
> > > > Then please confirm that only power_save_node disablement suffices.
> > > > This can be considered as the least change that can be put to 4.1-rc
> > > > if no better fix is found.
> > > 
> > > Setting codec->power_save_node to 0 in patch_alc269 is sufficient; no
> > > noticeable cracking occurring.
> > 
> > Does the patch below have any improvement?
> 
> I still get a clicking on the standby -> active transition with the
> patch provided on top of 4.1-rc4.

OK, just to be sure, could you check whether changing msleep(10) to
msleep(100) makes no difference?  Also put a line like
	pr_info("XXX power up %x\n", nid);
after msleep() call to see which nodes are powered up dynamically.


Takashi

  reply	other threads:[~2015-05-19 17:09 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 11:21 Audio crackles with 4.1-rc1 Jonathan McDowell
2015-04-28 12:00 ` Takashi Iwai
2015-04-28 12:35   ` Jonathan McDowell
2015-04-28 13:05     ` Takashi Iwai
2015-04-28 14:43       ` Takashi Iwai
2015-04-29 11:28         ` Jonathan McDowell
2015-04-29 11:54           ` Takashi Iwai
2015-04-30 15:01             ` Jonathan McDowell
2015-04-30 17:06               ` Takashi Iwai
2015-05-02 15:05                 ` Jonathan McDowell
2015-05-19  6:15                   ` Takashi Iwai
2015-05-19 16:19                     ` Jonathan McDowell
2015-05-19 17:09                       ` Takashi Iwai [this message]
2015-05-19 21:53                         ` Jonathan McDowell
2015-05-20  5:01                           ` Takashi Iwai
2015-05-20 20:02                             ` Jonathan McDowell
2015-06-10 10:17                             ` Mihai Donțu
2015-06-10 10:22                               ` Takashi Iwai
2015-06-10 10:41                                 ` Mihai Donțu
2015-06-10 10:50                                   ` Takashi Iwai
2015-06-10 11:45                                     ` Mihai Donțu
2015-06-10 12:33                                       ` Takashi Iwai
2015-06-10 12:50                                         ` Takashi Iwai
2015-06-10 16:22                                           ` Mihai Donțu
2015-06-10 16:27                                             ` Takashi Iwai
2015-06-10 16:43                                               ` Mihai Donțu
2015-06-10 18:23                                                 ` Takashi Iwai
2015-06-10 22:12                                                   ` Mihai Donțu
2015-06-11  5:01                                                     ` Takashi Iwai
2015-06-11 22:23                                                       ` Mihai Donțu
2015-06-12  7:00                                                         ` Takashi Iwai
2015-06-12  9:45                                                           ` Mihai Donțu
2015-06-12 10:09                                                             ` Takashi Iwai
2015-06-12 14:13                                                               ` Takashi Iwai
2015-06-12 17:28                                                                 ` Mihai Donțu
2015-06-14 12:24                                                                 ` Jonathan McDowell
2015-06-15 12:04                                                                   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr3qctryf.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noodles@earth.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).