From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: "Jens Kuske" <jenskuske@gmail.com>,
devicetree@vger.kernel.org,
"Vishnu Patekar" <vishnupatekar0510@gmail.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI
Date: Sat, 24 Oct 2015 09:13:28 +0200 [thread overview]
Message-ID: <20151024071328.GQ10947@lukather> (raw)
In-Reply-To: <20151023212013.50bcbe4a@OPI2>
[-- Attachment #1: Type: text/plain, Size: 3751 bytes --]
On Fri, Oct 23, 2015 at 09:20:13PM +0200, Jean-Francois Moine wrote:
> On Fri, 23 Oct 2015 20:14:06 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > On Wed, Oct 21, 2015 at 06:20:27PM +0200, Jens Kuske wrote:
> > > + bus_gates: clk@01c20060 {
> > > + #clock-cells = <1>;
> > > + compatible = "allwinner,sun8i-h3-bus-gates-clk";
> > > + reg = <0x01c20060 0x14>;
> > > + clock-indices = <5>, <6>, <8>,
> > > + <9>, <10>, <13>,
> > > + <14>, <17>, <18>,
> > > + <19>, <20>,
> > > + <21>, <23>,
> > > + <24>, <25>,
> > > + <26>, <27>,
> > > + <28>, <29>,
> > > + <30>, <31>, <32>,
> > > + <35>, <36>, <37>,
> > > + <40>, <41>, <43>,
> > > + <44>, <52>, <53>,
> > > + <54>, <64>,
> > > + <65>, <69>, <72>,
> > > + <76>, <77>, <78>,
> > > + <96>, <97>, <98>,
> > > + <112>, <113>,
> > > + <114>, <115>, <116>,
> > > + <128>, <135>;
> > > + clocks = <&ahb1>, <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb2>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb2>,
> > > + <&ahb2>, <&ahb2>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&ahb1>, <&ahb1>,
> > > + <&ahb1>, <&apb1>,
> > > + <&apb1>, <&apb1>, <&apb1>,
> > > + <&apb1>, <&apb1>, <&apb1>,
> > > + <&apb2>, <&apb2>, <&apb2>,
> > > + <&apb2>, <&apb2>,
> > > + <&apb2>, <&apb2>, <&apb2>,
> > > + <&ahb1>, <&ahb1>;
> >
> > This is not really what I had in mind...
> >
> > This IP has 2 parents, and only two parents. The mapping between the
> > IPs should be done in the driver itself, not in the DT where it is
> > very error prone and barely readable.
> >
> > And note that I never have expected you to use clk-simple-gates
> > either. This is a complicated clock, unlike the other we've seen so
> > far, it definitely deserves a driver of its own.
>
> It seems that Allwinner puts the gate definitions anywhere in the array
> of registers, so, I think that the H3 scheme will not be the last
> complicated one,
Maybe, but that's the first one. It doesn't prevent us from reusing
the driver later if it happens.
> and if the parent clocks are in the code instead of in the DT, we
> will have more and more code to develop.
I never asked that either.
> An other way to describe the gates would be to add containers per parent
> (with still a small patch in the clk-simple-gates):
>
> bus_gates: clk@01c20060 {
> #clock-cells = <1>;
> compatible = "allwinner,sun8i-h3-bus-gates-clk";
> reg = <0x01c20060 0x14>;
> ahb1_gates {
> clocks = <&ahb1>;
> clock-indices = <5>, <6>, <8>,
> <9>, <10>, <13>,
> <14>, <18>,
> <19>, <20>,
> ...;
> };
> clock-output-names = "ahb1_ce", "ahb1_dma", "ahb1_mmc0",
> "ahb1_mmc1", "ahb1_mmc2", "ahb1_nand",
> "ahb1_sdram", "ahb1_ts",
> "ahb1_hstimer", "ahb1_spi0",
> ...;
> };
> ahb2_gates {
> clocks = <&ahb2>;
> clock-indices = <17>, <29>,
> <30>, <31>, <32>,
> ...;
> clock-output-names = "ahb2_gmac", "ahb2_ohic1",
> "ahb2_ohic2", "ahb2_ohic3", "ahb1_ve",
> ...;
> };
> apb1_gates {
> ...
> };
> apb2_gates {
> ...
> };
> };
Or simply
bus_gates {
clocks = <&ahb1>, <&ahb2>;
clock-indices = <5>, <6>, <8>, ...
clock-output-names = "bus_ce", "bus_dma", "bus_mmc0"
};
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-24 7:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 16:20 [PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus resets Jens Kuske
2015-10-21 16:20 ` [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske
2015-10-22 8:05 ` Maxime Ripard
2015-10-22 8:29 ` Jean-Francois Moine
2015-10-22 8:47 ` Maxime Ripard
2015-10-22 8:57 ` Jean-Francois Moine
2015-10-22 9:14 ` Maxime Ripard
2015-10-22 11:30 ` Jens Kuske
2015-10-23 18:09 ` Maxime Ripard
2015-10-22 17:30 ` Jean-Francois Moine
2015-10-23 18:14 ` Maxime Ripard
2015-10-23 19:20 ` Jean-Francois Moine
2015-10-24 7:13 ` Maxime Ripard [this message]
2015-10-24 8:47 ` Jean-Francois Moine
2015-10-26 21:06 ` Maxime Ripard
2015-10-27 8:12 ` [linux-sunxi] " Hans de Goede
2015-10-24 8:39 ` Hans de Goede
2015-10-26 21:00 ` Maxime Ripard
2015-10-21 16:20 ` [PATCH 6/6] ARM: dts: sun8i: Add Orange Pi Plus support Jens Kuske
2015-10-22 7:58 ` [PATCH 4/6] reset: sunxi: Add compatible for Allwinner H3 bus resets Maxime Ripard
2015-10-27 16:54 ` Jens Kuske
-- strict thread matches above, loose matches on Subject: below --
2015-05-06 9:31 [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support Jens Kuske
2015-05-06 9:31 ` [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske
2015-05-06 12:19 ` Maxime Ripard
2015-05-06 20:47 ` Jens Kuske
2015-05-09 11:44 ` Maxime Ripard
2015-05-11 8:11 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151024071328.GQ10947@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=hdegoede@redhat.com \
--cc=jenskuske@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=moinejf@free.fr \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).