linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: netanel@annapurnalabs.com
Cc: netdev@vger.kernel.org, davm@davemeloft.net,
	linux-kernel@vger.kernel.org, zorik@annapurnalabs.com,
	saeed@annapurnalabs.com, alex@annapurnalabs.com, msw@amazon.com,
	aligouri@amazon.com, antoine.tenart@free-electrons.com
Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Tue, 14 Jun 2016 22:25:16 -0700 (PDT)	[thread overview]
Message-ID: <20160614.222516.1192717052949905017.davem@davemloft.net> (raw)
In-Reply-To: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com>

From: Netanel Belgazal <netanel@annapurnalabs.com>
Date: Mon, 13 Jun 2016 11:46:13 +0300

> +#define ena_trc_dbg(format, arg...) \
> +	pr_debug("[ENA_COM: %s] " format, __func__, ##arg)
> +#define ena_trc_info(format, arg...) \
> +	pr_info("[ENA_COM: %s] " format, __func__, ##arg)
> +#define ena_trc_warn(format, arg...) \
> +	pr_warn("[ENA_COM: %s] " format, __func__, ##arg)
> +#define ena_trc_err(format, arg...) \
> +	pr_err("[ENA_COM: %s] " format, __func__, ##arg)

These custom tracing macros are quite inappropriate.

We have the function tracer in the kernel when that is needed.  So spitting
out __func__ all over the place is not something that should be found in
drivers these days.

And one can modify pr_fmt do make pr_debug et al. have whatever prefix
one wants.

I suspect there will be several rounds of review to weed out things
like this.  You can preempt a lot of that by removing as much in your
driver that the kernel has existing facilities for.

Thanks.

  parent reply	other threads:[~2016-06-15  5:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13  8:46 [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal
2016-06-13 20:36 ` Matt Wilson
2016-06-15  5:25 ` David Miller [this message]
2016-06-15  6:23   ` Matt Wilson
2016-06-15  6:27     ` David Miller
2016-06-15  6:40       ` Matt Wilson
2016-06-15 18:07 ` Matt Wilson
2016-06-15 18:22   ` Matt Wilson
     [not found]     ` <CAO+Uck_mkRmhkFedb1FsbvuEFFebhYEfYb1UqM+VGSFfKFWN0Q@mail.gmail.com>
2016-06-15 18:39       ` Matt Wilson
2016-06-16 17:55 ` Benjamin Poirier
2016-06-16 18:06   ` Ben Hutchings
2016-06-18  6:16     ` Matt Wilson
2016-06-16 20:46 ` Francois Romieu
2016-06-17  1:09   ` Matt Wilson
2016-06-20 15:18     ` Netanel Belgazal
2016-06-17 21:11 ` Francois Romieu
2016-06-20 15:32   ` Netanel Belgazal
2016-06-20 22:43     ` Francois Romieu
2016-06-21 10:02       ` Netanel Belgazal
2016-06-20  5:20 ` Rosen, Rami
2016-06-20 15:42   ` Netanel Belgazal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614.222516.1192717052949905017.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alex@annapurnalabs.com \
    --cc=aligouri@amazon.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=davm@davemeloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msw@amazon.com \
    --cc=netanel@annapurnalabs.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeed@annapurnalabs.com \
    --cc=zorik@annapurnalabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).