From: Netanel Belgazal <netanel@annapurnalabs.com>
To: "Rosen, Rami" <rami.rosen@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "zorik@annapurnalabs.com" <zorik@annapurnalabs.com>,
"saeed@annapurnalabs.com" <saeed@annapurnalabs.com>,
"alex@annapurnalabs.com" <alex@annapurnalabs.com>,
"msw@amazon.com" <msw@amazon.com>,
"aligouri@amazon.com" <aliguori@amazon.com>,
"antoine.tenart@free-electrons.com"
<antoine.tenart@free-electrons.com>
Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Mon, 20 Jun 2016 18:42:32 +0300 [thread overview]
Message-ID: <7f753555-eb8d-b902-ade8-efee286fe81b@annapurnalabs.com> (raw)
In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F92CD6858D@HASMSX110.ger.corp.intel.com>
On 06/20/2016 08:20 AM, Rosen, Rami wrote:
> Hi all,
>
> A very limited review below.
>
> +
> + /* get capabilities of particular feature */
> + ENA_ADMIN_GET_FEATURE = 8,
>
> Instead /* get capabilities SHOULD BE: /* set capabilities .....
> +
> + /* get capabilities of particular feature */
> + ENA_ADMIN_SET_FEATURE = 9,
> +
> ..
>
>
> +int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
> +{
> + struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;
> ...
>
> You set ret=-EINVAL, but you do not use this ret as you immediately return 0 in the next line, which is the end of the method. Either return ret or return -EINVAL.
> + if (unlikely(ret)) {
> + ena_trc_err("Failed to set hash input. error: %d\n", ret);
> + ret = -EINVAL;
> + }
> +
> + return 0;
> +}
> +
I will return ret.
>
>
> +
> +/* ena_com_set_mmio_read_mode - Enable/disable the mmio reg read mechanism
> + * @ena_dev: ENA communication layer struct
>
>
> Instead realess_supported: SHOULD BE: readless_supported
ack
>
> + * @realess_supported: readless mode (enable/disable)
> + */
> +void ena_com_set_mmio_read_mode(struct ena_com_dev *ena_dev,
> + bool readless_supported);
> +
>
>
>
> +
> +/* ena_com_create_io_queue - Create io queue.
> + * @ena_dev: ENA communication layer struct
>
> Instead ena_com_create_io_ctx SHOULD BE: @ena_com_create_io_ctx
ack
>
> + * ena_com_create_io_ctx - create context structure
> + *
> + * Create the submission and the completion queues.
> + *
> + * @return - 0 on success, negative value on failure.
> + */
> +int ena_com_create_io_queue(struct ena_com_dev *ena_dev,
> + struct ena_com_create_io_ctx *ctx);
> +
>
>
>
>
> +/* ena_com_admin_destroy - Destroy IO queue with the queue id - qid.
> + * @ena_dev: ENA communication layer struct
>
> Missing: @qid
ack
>
> + */
> +void ena_com_destroy_io_queue(struct ena_com_dev *ena_dev, u16 qid);
> +
>
> Regards,
> Rami Rosen
> Intel Corporation
Thanks for the review
prev parent reply other threads:[~2016-06-20 16:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 8:46 [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal
2016-06-13 20:36 ` Matt Wilson
2016-06-15 5:25 ` David Miller
2016-06-15 6:23 ` Matt Wilson
2016-06-15 6:27 ` David Miller
2016-06-15 6:40 ` Matt Wilson
2016-06-15 18:07 ` Matt Wilson
2016-06-15 18:22 ` Matt Wilson
[not found] ` <CAO+Uck_mkRmhkFedb1FsbvuEFFebhYEfYb1UqM+VGSFfKFWN0Q@mail.gmail.com>
2016-06-15 18:39 ` Matt Wilson
2016-06-16 17:55 ` Benjamin Poirier
2016-06-16 18:06 ` Ben Hutchings
2016-06-18 6:16 ` Matt Wilson
2016-06-16 20:46 ` Francois Romieu
2016-06-17 1:09 ` Matt Wilson
2016-06-20 15:18 ` Netanel Belgazal
2016-06-17 21:11 ` Francois Romieu
2016-06-20 15:32 ` Netanel Belgazal
2016-06-20 22:43 ` Francois Romieu
2016-06-21 10:02 ` Netanel Belgazal
2016-06-20 5:20 ` Rosen, Rami
2016-06-20 15:42 ` Netanel Belgazal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f753555-eb8d-b902-ade8-efee286fe81b@annapurnalabs.com \
--to=netanel@annapurnalabs.com \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=rami.rosen@intel.com \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).