From: Francois Romieu <romieu@fr.zoreil.com>
To: Netanel Belgazal <netanel@annapurnalabs.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, zorik@annapurnalabs.com,
saeed@annapurnalabs.com, alex@annapurnalabs.com, msw@amazon.com,
aligouri@amazon.com, antoine.tenart@free-electrons.com
Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Tue, 21 Jun 2016 00:43:16 +0200 [thread overview]
Message-ID: <20160620224316.GA11834@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <ff2fbee5-46c1-15a8-d283-4320e122934a@annapurnalabs.com>
Netanel Belgazal <netanel@annapurnalabs.com> :
[...]
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h
> > new file mode 100644
> > index 0000000..e49ba43
> > --- /dev/null
> > [...]
> > +static inline void ena_com_update_intr_reg(struct ena_eth_io_intr_reg *intr_reg,
> > + u32 rx_delay_interval,
> > + u32 tx_delay_interval,
> > + bool unmask)
> > +{
> > + intr_reg->intr_control = 0;
> > + intr_reg->intr_control |= rx_delay_interval &
> > + ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
> > +
> > + intr_reg->intr_control |=
> > + (tx_delay_interval << ENA_ETH_IO_INTR_REG_TX_INTR_DELAY_SHIFT)
> > + & ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
> > ^^ TX ?
> >
> > Extra: you should not return NETDEV_TX_BUSY in the xmit handler while
> > queueing is still enabled. Please drop packet and return NETDEV_TX_OK.
> Ack.
>
> Thanks for your review.
Ack/nack regarding use of ..._RX_INTR_DELAY_MASK with ..._TX_INTR_DELAY_SHIFT ?
--
Ueimor
next prev parent reply other threads:[~2016-06-20 22:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 8:46 [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal
2016-06-13 20:36 ` Matt Wilson
2016-06-15 5:25 ` David Miller
2016-06-15 6:23 ` Matt Wilson
2016-06-15 6:27 ` David Miller
2016-06-15 6:40 ` Matt Wilson
2016-06-15 18:07 ` Matt Wilson
2016-06-15 18:22 ` Matt Wilson
[not found] ` <CAO+Uck_mkRmhkFedb1FsbvuEFFebhYEfYb1UqM+VGSFfKFWN0Q@mail.gmail.com>
2016-06-15 18:39 ` Matt Wilson
2016-06-16 17:55 ` Benjamin Poirier
2016-06-16 18:06 ` Ben Hutchings
2016-06-18 6:16 ` Matt Wilson
2016-06-16 20:46 ` Francois Romieu
2016-06-17 1:09 ` Matt Wilson
2016-06-20 15:18 ` Netanel Belgazal
2016-06-17 21:11 ` Francois Romieu
2016-06-20 15:32 ` Netanel Belgazal
2016-06-20 22:43 ` Francois Romieu [this message]
2016-06-21 10:02 ` Netanel Belgazal
2016-06-20 5:20 ` Rosen, Rami
2016-06-20 15:42 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620224316.GA11834@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=alex@annapurnalabs.com \
--cc=aligouri@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).