From: Matt Wilson <msw@amzn.com>
To: Netanel Belgazal <netanel@annapurnalabs.com>
Cc: netdev@vger.kernel.org, davem@davemeloft.net,
linux-kernel@vger.kernel.org, zorik@annapurnalabs.com,
saeed@annapurnalabs.com, alex@annapurnalabs.com,
aliguori@amazon.com, antoine.tenart@free-electrons.com
Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Wed, 15 Jun 2016 11:07:17 -0700 [thread overview]
Message-ID: <20160615180717.GA14049@u54ee753d2d1854bda401.ant.amazon.com> (raw)
In-Reply-To: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com>
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
[...]
> +
> +struct ena_napi {
> + struct napi_struct napi ____cacheline_aligned;
> + struct ena_ring *tx_ring;
> + struct ena_ring *rx_ring;
> +#ifndef HAVE_NETDEV_NAPI_LIST
> + struct net_device poll_dev;
> +#endif /* HAVE_NETDEV_NAPI_LIST */
> + u32 qid;
> +};
Netanel,
Sorry I missed this when I read through the patch earlier this week
(though I pointed it out before...). This "#ifndef
HAVE_NETDEV_NAPI_LIST" bit needs to be removed for the in-tree
version.
You also had a few typos in the email addresses on the Cc: line that
I've corrected (davm@avemeloft.net -> davem@davemeloft.net,
aligouri@amazon.com -> aliguori@amazon.com). Please make sure to
correct in your v2 patch.
--msw
next prev parent reply other threads:[~2016-06-15 18:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 8:46 [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal
2016-06-13 20:36 ` Matt Wilson
2016-06-15 5:25 ` David Miller
2016-06-15 6:23 ` Matt Wilson
2016-06-15 6:27 ` David Miller
2016-06-15 6:40 ` Matt Wilson
2016-06-15 18:07 ` Matt Wilson [this message]
2016-06-15 18:22 ` Matt Wilson
[not found] ` <CAO+Uck_mkRmhkFedb1FsbvuEFFebhYEfYb1UqM+VGSFfKFWN0Q@mail.gmail.com>
2016-06-15 18:39 ` Matt Wilson
2016-06-16 17:55 ` Benjamin Poirier
2016-06-16 18:06 ` Ben Hutchings
2016-06-18 6:16 ` Matt Wilson
2016-06-16 20:46 ` Francois Romieu
2016-06-17 1:09 ` Matt Wilson
2016-06-20 15:18 ` Netanel Belgazal
2016-06-17 21:11 ` Francois Romieu
2016-06-20 15:32 ` Netanel Belgazal
2016-06-20 22:43 ` Francois Romieu
2016-06-21 10:02 ` Netanel Belgazal
2016-06-20 5:20 ` Rosen, Rami
2016-06-20 15:42 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615180717.GA14049@u54ee753d2d1854bda401.ant.amazon.com \
--to=msw@amzn.com \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemeloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).