* [PATCH v2 00/17] DS1341 support and code cleanup
@ 2016-06-21 7:18 Andrey Smirnov
2016-06-21 21:32 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Andrey Smirnov @ 2016-06-21 7:18 UTC (permalink / raw)
To: rtc-linux
Cc: Andrey Smirnov, Alessandro Zummo, Alexandre Belloni,
linux-kernel, cphealy
Hi everyone,
This set is a v2 of the DS1307 driver patches. Changes since v1:
- Devicetree bindings are separated into a separate commit
- Device tree properties now have vendor specific prefixes and
documenatation explicitly stating their type
- Three more patches, with improvements to rtctest.c, are added to
the patchset
Any feedback is appreciated.
Thank you,
Andrey Smirnov
Andrey Smirnov (17):
RTC: ds1307: Add DS1341 variant
RTC: ds1307: Disable square wave and timers as default
RTC: ds1307: Add devicetree bindings for DS1341
RTC: ds1307: Add DS1341 specific power-saving options
RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate
RTC: ds1307: Convert want_irq into a predicate
RTC: ds1307: Move chip configuration into a separate routine
RTC: ds1307: Move chip sanity checking into a separate routine
RTC: ds1307: Remove register "cache"
RTC: ds1307: Constify struct ds1307 where possible
RTC: ds1307: Convert goto to a loop
RTC: ds1307: Redefine RX8025_REG_* to minimize extra code
RTC: ds1307: Report oscillator problems more intelligently
RTC: ds1307: Move last bits of sanity checking out of chip_configure
RTC: rtctest: Change alarm IRQ support detection
RTC: rtctest: Change no IRQ detection for RTC_IRQP_READ
RTC: rtctest: Change no IRQ detection for RTC_IRQP_SET
.../devicetree/bindings/rtc/dallas,ds1341.txt | 23 +
drivers/rtc/rtc-ds1307.c | 742 ++++++++++++---------
tools/testing/selftests/timers/rtctest.c | 13 +-
3 files changed, 467 insertions(+), 311 deletions(-)
create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 00/17] DS1341 support and code cleanup
2016-06-21 7:18 [PATCH v2 00/17] DS1341 support and code cleanup Andrey Smirnov
@ 2016-06-21 21:32 ` Alexandre Belloni
2016-06-21 23:51 ` Andrey Smirnov
2016-06-26 13:30 ` Alexandre Belloni
0 siblings, 2 replies; 5+ messages in thread
From: Alexandre Belloni @ 2016-06-21 21:32 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: rtc-linux, Alessandro Zummo, linux-kernel, cphealy
Hi,
On 21/06/2016 at 00:18:22 -0700, Andrey Smirnov wrote :
> Hi everyone,
>
> This set is a v2 of the DS1307 driver patches. Changes since v1:
>
> - Devicetree bindings are separated into a separate commit
>
> - Device tree properties now have vendor specific prefixes and
> documenatation explicitly stating their type
>
> - Three more patches, with improvements to rtctest.c, are added to
> the patchset
>
> Any feedback is appreciated.
>
> Thank you,
> Andrey Smirnov
>
> Andrey Smirnov (17):
> RTC: ds1307: Add DS1341 variant
> RTC: ds1307: Disable square wave and timers as default
> RTC: ds1307: Add devicetree bindings for DS1341
> RTC: ds1307: Add DS1341 specific power-saving options
> RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate
> RTC: ds1307: Convert want_irq into a predicate
I'll have to triple check that one, it breaks in thousand different
ways, every time someone touches that code :)
> RTC: ds1307: Move chip configuration into a separate routine
> RTC: ds1307: Move chip sanity checking into a separate routine
I'm not sure about the cleanup in those two patches yet, It moves a lot
of code and the readability improvement is not obvious
> RTC: ds1307: Remove register "cache"
> RTC: ds1307: Constify struct ds1307 where possible
> RTC: ds1307: Convert goto to a loop
> RTC: ds1307: Redefine RX8025_REG_* to minimize extra code
> RTC: ds1307: Report oscillator problems more intelligently
> RTC: ds1307: Move last bits of sanity checking out of chip_configure
> RTC: rtctest: Change alarm IRQ support detection
> RTC: rtctest: Change no IRQ detection for RTC_IRQP_READ
> RTC: rtctest: Change no IRQ detection for RTC_IRQP_SET
I already had patches for that issue in a development tree, I'll see if
they match what I did.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 00/17] DS1341 support and code cleanup
2016-06-21 21:32 ` Alexandre Belloni
@ 2016-06-21 23:51 ` Andrey Smirnov
2016-06-26 13:30 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Andrey Smirnov @ 2016-06-21 23:51 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: rtc-linux, Alessandro Zummo, linux-kernel, Chris Healy
>>
>> Andrey Smirnov (17):
>> RTC: ds1307: Add DS1341 variant
>> RTC: ds1307: Disable square wave and timers as default
>> RTC: ds1307: Add devicetree bindings for DS1341
>> RTC: ds1307: Add DS1341 specific power-saving options
>> RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate
>> RTC: ds1307: Convert want_irq into a predicate
>
> I'll have to triple check that one, it breaks in thousand different
> ways, every time someone touches that code :)
Wouldn't you agree that this might be an indication that the code is a
bit convoluted and some cleanup is in order? ;-)
>
>> RTC: ds1307: Move chip configuration into a separate routine
>> RTC: ds1307: Move chip sanity checking into a separate routine
>
> I'm not sure about the cleanup in those two patches yet, It moves a lot
> of code and the readability improvement is not obvious
OK, I agree that this patch moves a lot of code, and can't really
argue with "not obvious" since that is subjective. Please let me know
what you decide and I'll change v3 appropriately.
Thanks,
Andrey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 00/17] DS1341 support and code cleanup
2016-06-21 21:32 ` Alexandre Belloni
2016-06-21 23:51 ` Andrey Smirnov
@ 2016-06-26 13:30 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2016-06-26 13:30 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: rtc-linux, Alessandro Zummo, linux-kernel, cphealy
On 21/06/2016 at 23:32:19 +0200, Alexandre Belloni wrote :
> > RTC: rtctest: Change alarm IRQ support detection
> > RTC: rtctest: Change no IRQ detection for RTC_IRQP_READ
> > RTC: rtctest: Change no IRQ detection for RTC_IRQP_SET
>
> I already had patches for that issue in a development tree, I'll see if
> they match what I did.
>
I've applied those now.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 00/17] DS1341 support and code cleanup
@ 2016-06-21 7:14 Andrey Smirnov
0 siblings, 0 replies; 5+ messages in thread
From: Andrey Smirnov @ 2016-06-21 7:14 UTC (permalink / raw)
To: rtc-linux
Cc: Andrey Smirnov, Alessandro Zummo, Alexandre Belloni,
linux-kernel, cphealy
Hi everyone,
This set is a v2 of the DS1307 driver patches. Changes since v1:
- Devicetree bindings are separated into a separate commit
- Device tree properties now have vendor specific prefixes and
documenatation explicitly stating their type
- Three more patches, with improvements to rtctest.c, are added to
the patchset
Any feedback is appreciated.
Thank you,
Andrey Smirnov
Andrey Smirnov (17):
RTC: ds1307: Add DS1341 variant
RTC: ds1307: Disable square wave and timers as default
RTC: ds1307: Add devicetree bindings for DS1341
RTC: ds1307: Add DS1341 specific power-saving options
RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate
RTC: ds1307: Convert want_irq into a predicate
RTC: ds1307: Move chip configuration into a separate routine
RTC: ds1307: Move chip sanity checking into a separate routine
RTC: ds1307: Remove register "cache"
RTC: ds1307: Constify struct ds1307 where possible
RTC: ds1307: Convert goto to a loop
RTC: ds1307: Redefine RX8025_REG_* to minimize extra code
RTC: ds1307: Report oscillator problems more intelligently
RTC: ds1307: Move last bits of sanity checking out of chip_configure
RTC: rtctest: Change alarm IRQ support detection
RTC: rtctest: Change no IRQ detection for RTC_IRQP_READ
RTC: rtctest: Change no IRQ detection for RTC_IRQP_SET
.../devicetree/bindings/rtc/dallas,ds1341.txt | 23 +
drivers/rtc/rtc-ds1307.c | 742 ++++++++++++---------
tools/testing/selftests/timers/rtctest.c | 13 +-
3 files changed, 467 insertions(+), 311 deletions(-)
create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-26 13:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21 7:18 [PATCH v2 00/17] DS1341 support and code cleanup Andrey Smirnov
2016-06-21 21:32 ` Alexandre Belloni
2016-06-21 23:51 ` Andrey Smirnov
2016-06-26 13:30 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2016-06-21 7:14 Andrey Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).