linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1
@ 2016-12-05  2:00 Milo Kim
  2016-12-05  2:00 ` [PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo Milo Kim
  2016-12-05  8:09 ` [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Maxime Ripard
  0 siblings, 2 replies; 6+ messages in thread
From: Milo Kim @ 2016-12-05  2:00 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai
  Cc: devicetree, linux-arm-kernel, linux-kernel, Milo Kim

The board has DDR3 512MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
 arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
index ec63d10..be3668f 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
@@ -45,6 +45,11 @@
 / {
 	model = "FriendlyArm NanoPi M1";
 	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x40000000 0x20000000>;
+	};
 };
 
 &ehci1 {
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo
  2016-12-05  2:00 [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Milo Kim
@ 2016-12-05  2:00 ` Milo Kim
  2016-12-05  8:09 ` [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Maxime Ripard
  1 sibling, 0 replies; 6+ messages in thread
From: Milo Kim @ 2016-12-05  2:00 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai
  Cc: devicetree, linux-arm-kernel, linux-kernel, Milo Kim

The board has DDR3 256MB. This patch helps scanning the memory and
adding memblock through the DT.

Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
 arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
index 8d2cc6e..433f55d 100644
--- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
+++ b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts
@@ -45,4 +45,9 @@
 / {
 	model = "FriendlyARM NanoPi NEO";
 	compatible = "friendlyarm,nanopi-neo", "allwinner,sun8i-h3";
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x40000000 0x10000000>;
+	};
 };
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1
  2016-12-05  2:00 [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Milo Kim
  2016-12-05  2:00 ` [PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo Milo Kim
@ 2016-12-05  8:09 ` Maxime Ripard
  2016-12-06  7:23   ` Milo Kim
  1 sibling, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2016-12-05  8:09 UTC (permalink / raw)
  To: Milo Kim; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> The board has DDR3 512MB. This patch helps scanning the memory and
> adding memblock through the DT.
> 
> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> index ec63d10..be3668f 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> @@ -45,6 +45,11 @@
>  / {
>  	model = "FriendlyArm NanoPi M1";
>  	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> +
> +	memory@40000000 {
> +		device_type = "memory";
> +		reg = <0x40000000 0x20000000>;
> +	};

U-boot will fill that up, so there's no need to put it there.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1
  2016-12-05  8:09 ` [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Maxime Ripard
@ 2016-12-06  7:23   ` Milo Kim
  2016-12-06 14:00     ` Maxime Ripard
  0 siblings, 1 reply; 6+ messages in thread
From: Milo Kim @ 2016-12-06  7:23 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel

On 12/05/2016 05:09 PM, Maxime Ripard wrote:
> On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
>> The board has DDR3 512MB. This patch helps scanning the memory and
>> adding memblock through the DT.
>>
>> Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
>> ---
>>  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> index ec63d10..be3668f 100644
>> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
>> @@ -45,6 +45,11 @@
>>  / {
>>  	model = "FriendlyArm NanoPi M1";
>>  	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
>> +
>> +	memory@40000000 {
>> +		device_type = "memory";
>> +		reg = <0x40000000 0x20000000>;
>> +	};
>
> U-boot will fill that up, so there's no need to put it there.

Right, my intention was adding memblock through the DT whether the 
bootload does or not. However I'm not sure the situation (missing 
memblock in u-boot) could really happen.

Best regards,
Milo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1
  2016-12-06  7:23   ` Milo Kim
@ 2016-12-06 14:00     ` Maxime Ripard
  2016-12-06 14:28       ` Milo Kim
  0 siblings, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2016-12-06 14:00 UTC (permalink / raw)
  To: Milo Kim; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On Tue, Dec 06, 2016 at 04:23:57PM +0900, Milo Kim wrote:
> On 12/05/2016 05:09 PM, Maxime Ripard wrote:
> > On Mon, Dec 05, 2016 at 11:00:31AM +0900, Milo Kim wrote:
> > > The board has DDR3 512MB. This patch helps scanning the memory and
> > > adding memblock through the DT.
> > > 
> > > Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
> > > ---
> > >  arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > index ec63d10..be3668f 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1.dts
> > > @@ -45,6 +45,11 @@
> > >  / {
> > >  	model = "FriendlyArm NanoPi M1";
> > >  	compatible = "friendlyarm,nanopi-m1", "allwinner,sun8i-h3";
> > > +
> > > +	memory@40000000 {
> > > +		device_type = "memory";
> > > +		reg = <0x40000000 0x20000000>;
> > > +	};
> > 
> > U-boot will fill that up, so there's no need to put it there.
> 
> Right, my intention was adding memblock through the DT whether the bootload
> does or not. However I'm not sure the situation (missing memblock in u-boot)
> could really happen.

No, we need a recent U-Boot in order to boot, and such a uboot will
setup the memory node anyway.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1
  2016-12-06 14:00     ` Maxime Ripard
@ 2016-12-06 14:28       ` Milo Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Milo Kim @ 2016-12-06 14:28 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel

On 12/06/2016 11:00 PM, Maxime Ripard wrote:
> No, we need a recent U-Boot in order to boot, and such a uboot will
> setup the memory node anyway.

Got it. Thanks! Please just ignore my patches.

Best regards,
Milo

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-12-06 14:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-05  2:00 [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Milo Kim
2016-12-05  2:00 ` [PATCH 2/2] ARM: dts: sun8i: Specify memblock for Nano Pi Neo Milo Kim
2016-12-05  8:09 ` [PATCH 1/2] ARM: dts: sun8i: Specify memblock for Nano Pi M1 Maxime Ripard
2016-12-06  7:23   ` Milo Kim
2016-12-06 14:00     ` Maxime Ripard
2016-12-06 14:28       ` Milo Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).