[PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces

[PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces

[Martin Karamihov]

checkpatch fixes: removes not necessary braces 

[PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Martin Karamihov]

Signed-off-by: Martin Karamihov <martinowar@gmail.com>
---
 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
 		power_level_offset[11] = data;
 	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
 		power_level_offset[12] = data;
-	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
+	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
 		power_level_offset[13] = data;
-	}
 }
 
 static void rtl_addr_delay(struct adapter *adapt,
-- 
2.11.0

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Greg KH]

On Sat, Jan 28, 2017 at 10:34:36AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I can't take a patch with no changelog text :(

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces

[Greg KH]

On Sat, Jan 28, 2017 at 10:34:35AM +0200, Martin Karamihov wrote:
> checkpatch fixes: removes not necessary braces 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


I don't see any patch here, why is this email being sent?  You don't
need a "cover letter" for just a single patch.

thanks,

greg k-h

[PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Martin Karamihov]

Signed-off-by: Martin Karamihov <martinowar@gmail.com>
---
checkpatch fixes: remove not necessary braces

 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
 		power_level_offset[11] = data;
 	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
 		power_level_offset[12] = data;
-	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
+	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
 		power_level_offset[13] = data;
-	}
 }
 
 static void rtl_addr_delay(struct adapter *adapt,
-- 
2.11.0

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Greg KH]

On Sat, Jan 28, 2017 at 10:49:10AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
> checkpatch fixes: remove not necessary braces

{sigh}

Please take some time, and go read Documentation/SubmittingPatches.
Then wait a day, review the patches that other people send out, and then
compose your patch to match the requirements and what you see other
people do.

good luck!

greg k-h

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Bjørn Mork]

Greg KH <gregkh@linuxfoundation.org> writes:

> Please take some time, and go read Documentation/SubmittingPatches.

That's quickly done nowadays:

 bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
 This file has moved to process/submitting-patches.rst


I don't know why it was necessary to move that file, but it looks like
you, and the gazillion links and references to this document, just have
to adopt to a new location.

Or submit a patch to fix it :)



Bjørn

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[martinowar]

On 01/29/2017 06:43 PM, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
>> Please take some time, and go read Documentation/SubmittingPatches.
> That's quickly done nowadays:
>
>   bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
>   This file has moved to process/submitting-patches.rst
>
>
> I don't know why it was necessary to move that file, but it looks like
> you, and the gazillion links and references to this document, just have
> to adopt to a new location.
>
> Or submit a patch to fix it :)
>
>
>
> Bjørn

Hi all,


Sorry for the noise and thank you for the polite dialogue. Another 
eudyptula participant here, you guess :) I will try to figure out my 
mistakes and will send the patch again.


Martin

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Joe Perches]

On Sun, 2017-01-29 at 17:43 +0100, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > Please take some time, and go read Documentation/SubmittingPatches.
> 
> That's quickly done nowadays:
> 
>  bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
>  This file has moved to process/submitting-patches.rst
> 
> 
> I don't know why it was necessary to move that file, but it looks like
> you, and the gazillion links and references to this document, just have
> to adopt to a new location.
> 
> Or submit a patch to fix it :)

I did exactly that.
https://lkml.org/lkml/2017/1/10/1059