* [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces
@ 2017-01-28 8:34 Martin Karamihov
2017-01-28 8:34 ` [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Martin Karamihov
2017-01-28 8:41 ` [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces Greg KH
0 siblings, 2 replies; 9+ messages in thread
From: Martin Karamihov @ 2017-01-28 8:34 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, devel, linux-kernel
checkpatch fixes: removes not necessary braces
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
2017-01-28 8:34 [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces Martin Karamihov
@ 2017-01-28 8:34 ` Martin Karamihov
2017-01-28 8:41 ` Greg KH
2017-01-28 8:41 ` [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces Greg KH
1 sibling, 1 reply; 9+ messages in thread
From: Martin Karamihov @ 2017-01-28 8:34 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, devel, linux-kernel
Signed-off-by: Martin Karamihov <martinowar@gmail.com>
---
drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
power_level_offset[11] = data;
if (regaddr == rTxAGC_B_Mcs11_Mcs08)
power_level_offset[12] = data;
- if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
+ if (regaddr == rTxAGC_B_Mcs15_Mcs12)
power_level_offset[13] = data;
- }
}
static void rtl_addr_delay(struct adapter *adapt,
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
2017-01-28 8:34 ` [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Martin Karamihov
@ 2017-01-28 8:41 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2017-01-28 8:41 UTC (permalink / raw)
To: Martin Karamihov; +Cc: devel, linux-kernel, Larry.Finger
On Sat, Jan 28, 2017 at 10:34:36AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
> drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
I can't take a patch with no changelog text :(
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces
2017-01-28 8:34 [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces Martin Karamihov
2017-01-28 8:34 ` [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Martin Karamihov
@ 2017-01-28 8:41 ` Greg KH
1 sibling, 0 replies; 9+ messages in thread
From: Greg KH @ 2017-01-28 8:41 UTC (permalink / raw)
To: Martin Karamihov; +Cc: devel, linux-kernel, Larry.Finger
On Sat, Jan 28, 2017 at 10:34:35AM +0200, Martin Karamihov wrote:
> checkpatch fixes: removes not necessary braces
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
I don't see any patch here, why is this email being sent? You don't
need a "cover letter" for just a single patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
2017-01-29 16:43 ` Bjørn Mork
2017-01-29 18:57 ` martinowar
@ 2017-02-02 22:53 ` Joe Perches
1 sibling, 0 replies; 9+ messages in thread
From: Joe Perches @ 2017-02-02 22:53 UTC (permalink / raw)
To: Bjørn Mork, Greg KH
Cc: Martin Karamihov, devel, linux-kernel, Larry.Finger
On Sun, 2017-01-29 at 17:43 +0100, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
> > Please take some time, and go read Documentation/SubmittingPatches.
>
> That's quickly done nowadays:
>
> bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
> This file has moved to process/submitting-patches.rst
>
>
> I don't know why it was necessary to move that file, but it looks like
> you, and the gazillion links and references to this document, just have
> to adopt to a new location.
>
> Or submit a patch to fix it :)
I did exactly that.
https://lkml.org/lkml/2017/1/10/1059
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
2017-01-29 16:43 ` Bjørn Mork
@ 2017-01-29 18:57 ` martinowar
2017-02-02 22:53 ` Joe Perches
1 sibling, 0 replies; 9+ messages in thread
From: martinowar @ 2017-01-29 18:57 UTC (permalink / raw)
To: Bjørn Mork, Greg KH; +Cc: devel, linux-kernel, linux-kernel, Larry.Finger
On 01/29/2017 06:43 PM, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
>> Please take some time, and go read Documentation/SubmittingPatches.
> That's quickly done nowadays:
>
> bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
> This file has moved to process/submitting-patches.rst
>
>
> I don't know why it was necessary to move that file, but it looks like
> you, and the gazillion links and references to this document, just have
> to adopt to a new location.
>
> Or submit a patch to fix it :)
>
>
>
> Bjørn
Hi all,
Sorry for the noise and thank you for the polite dialogue. Another
eudyptula participant here, you guess :) I will try to figure out my
mistakes and will send the patch again.
Martin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
2017-01-28 9:11 ` Greg KH
@ 2017-01-29 16:43 ` Bjørn Mork
2017-01-29 18:57 ` martinowar
2017-02-02 22:53 ` Joe Perches
0 siblings, 2 replies; 9+ messages in thread
From: Bjørn Mork @ 2017-01-29 16:43 UTC (permalink / raw)
To: Greg KH; +Cc: Martin Karamihov, devel, linux-kernel, Larry.Finger
Greg KH <gregkh@linuxfoundation.org> writes:
> Please take some time, and go read Documentation/SubmittingPatches.
That's quickly done nowadays:
bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
This file has moved to process/submitting-patches.rst
I don't know why it was necessary to move that file, but it looks like
you, and the gazillion links and references to this document, just have
to adopt to a new location.
Or submit a patch to fix it :)
Bjørn
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
2017-01-28 8:49 [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Martin Karamihov
@ 2017-01-28 9:11 ` Greg KH
2017-01-29 16:43 ` Bjørn Mork
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2017-01-28 9:11 UTC (permalink / raw)
To: Martin Karamihov; +Cc: devel, linux-kernel, Larry.Finger
On Sat, Jan 28, 2017 at 10:49:10AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
> checkpatch fixes: remove not necessary braces
{sigh}
Please take some time, and go read Documentation/SubmittingPatches.
Then wait a day, review the patches that other people send out, and then
compose your patch to match the requirements and what you see other
people do.
good luck!
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
@ 2017-01-28 8:49 Martin Karamihov
2017-01-28 9:11 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Martin Karamihov @ 2017-01-28 8:49 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, devel, linux-kernel
Signed-off-by: Martin Karamihov <martinowar@gmail.com>
---
checkpatch fixes: remove not necessary braces
drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
power_level_offset[11] = data;
if (regaddr == rTxAGC_B_Mcs11_Mcs08)
power_level_offset[12] = data;
- if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
+ if (regaddr == rTxAGC_B_Mcs15_Mcs12)
power_level_offset[13] = data;
- }
}
static void rtl_addr_delay(struct adapter *adapt,
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-02-02 22:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-28 8:34 [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces Martin Karamihov
2017-01-28 8:34 ` [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Martin Karamihov
2017-01-28 8:41 ` Greg KH
2017-01-28 8:41 ` [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces Greg KH
2017-01-28 8:49 [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Martin Karamihov
2017-01-28 9:11 ` Greg KH
2017-01-29 16:43 ` Bjørn Mork
2017-01-29 18:57 ` martinowar
2017-02-02 22:53 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).