[PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Martin Karamihov]

Signed-off-by: Martin Karamihov <martinowar@gmail.com>
---
checkpatch fixes: remove not necessary braces

 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
 		power_level_offset[11] = data;
 	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
 		power_level_offset[12] = data;
-	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
+	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
 		power_level_offset[13] = data;
-	}
 }
 
 static void rtl_addr_delay(struct adapter *adapt,
-- 
2.11.0

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Greg KH]

On Sat, Jan 28, 2017 at 10:49:10AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
> checkpatch fixes: remove not necessary braces

{sigh}

Please take some time, and go read Documentation/SubmittingPatches.
Then wait a day, review the patches that other people send out, and then
compose your patch to match the requirements and what you see other
people do.

good luck!

greg k-h

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Bjørn Mork]

Greg KH <gregkh@linuxfoundation.org> writes:

> Please take some time, and go read Documentation/SubmittingPatches.

That's quickly done nowadays:

 bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
 This file has moved to process/submitting-patches.rst


I don't know why it was necessary to move that file, but it looks like
you, and the gazillion links and references to this document, just have
to adopt to a new location.

Or submit a patch to fix it :)



Bjørn

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[martinowar]

On 01/29/2017 06:43 PM, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
>> Please take some time, and go read Documentation/SubmittingPatches.
> That's quickly done nowadays:
>
>   bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
>   This file has moved to process/submitting-patches.rst
>
>
> I don't know why it was necessary to move that file, but it looks like
> you, and the gazillion links and references to this document, just have
> to adopt to a new location.
>
> Or submit a patch to fix it :)
>
>
>
> Bjørn

Hi all,


Sorry for the noise and thank you for the polite dialogue. Another 
eudyptula participant here, you guess :) I will try to figure out my 
mistakes and will send the patch again.


Martin

[PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

[Martin Karamihov]

This is checkpatch fix for hal/bb_cfg.c file:
remove not necessary braces {}

Signed-off-by: Martin Karamihov <martinowar@gmail.com>
---
 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
 		power_level_offset[11] = data;
 	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
 		power_level_offset[12] = data;
-	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
+	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
 		power_level_offset[13] = data;
-	}
 }
 
 static void rtl_addr_delay(struct adapter *adapt,
-- 
2.11.0

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

[Joe Perches]

On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote:
> This is checkpatch fix for hal/bb_cfg.c file:
> remove not necessary braces {}
> 
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> index 134fa6c595a8..26e0ef224299 100644
> --- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
> +++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> @@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
>  		power_level_offset[11] = data;
>  	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
>  		power_level_offset[12] = data;
> -	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
> +	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
>  		power_level_offset[13] = data;
> -	}

presumably, this and the regaddr block above it
should be an else if or a switch/case.

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

[Martin Karamihov]

On 02/01/2017 12:39 AM, Joe Perches wrote:
> On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote:
>> This is checkpatch fix for hal/bb_cfg.c file:
>> remove not necessary braces {}
>>
>> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
>> ---
>>   drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
>> index 134fa6c595a8..26e0ef224299 100644
>> --- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
>> +++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
>> @@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
>>   		power_level_offset[11] = data;
>>   	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
>>   		power_level_offset[12] = data;
>> -	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
>> +	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
>>   		power_level_offset[13] = data;
>> -	}
> presumably, this and the regaddr block above it
> should be an else if or a switch/case.
>
>

I will prepare the patch if this code modification is needed right now. 
Is it?

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

[Joe Perches]

On Wed, 2017-02-01 at 18:36 +0200, Martin Karamihov wrote:
> 
> On 02/01/2017 12:39 AM, Joe Perches wrote:
> > On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote:
> > > This is checkpatch fix for hal/bb_cfg.c file:
> > > remove not necessary braces {}
> > > 
> > > Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> > > ---
> > >   drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> > > index 134fa6c595a8..26e0ef224299 100644
> > > --- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
> > > +++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> > > @@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
> > >   		power_level_offset[11] = data;
> > >   	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
> > >   		power_level_offset[12] = data;
> > > -	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
> > > +	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
> > >   		power_level_offset[13] = data;
> > > -	}
> > 
> > presumably, this and the regaddr block above it
> > should be an else if or a switch/case.
> > 
> I will prepare the patch if this code modification is needed right now. 
> Is it?

No more nor less than the suggested brace removal.
Do please remember (or learn) that checkpatch is
a brainless script and clarifying the code for a
human reader is much more important than making a
file not have any checkpatch warnings.

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

[Martin Karamihov]

On 02/01/2017 08:11 PM, Joe Perches wrote:
> ...and clarifying the code for a
> human reader is much more important than making a
> file not have any checkpatch warnings.

I agree. I respect the developers' own coding style and believe that 
some things (>80 characters long lines, name conventions, etc) should be 
fixed by themselves (if they want to do that). I selected several TODOs 
with requests for code cleanups and chose a fix in attempt to accomplish 
my task with minimal inconvenience for the maintainers. I failed in my 
first attempts breaking some basic rules, sorry about that.

Martin

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Joe Perches]

On Sun, 2017-01-29 at 17:43 +0100, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > Please take some time, and go read Documentation/SubmittingPatches.
> 
> That's quickly done nowadays:
> 
>  bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
>  This file has moved to process/submitting-patches.rst
> 
> 
> I don't know why it was necessary to move that file, but it looks like
> you, and the gazillion links and references to this document, just have
> to adopt to a new location.
> 
> Or submit a patch to fix it :)

I did exactly that.
https://lkml.org/lkml/2017/1/10/1059

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

[Joe Perches]

On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote:
> On 02/01/2017 08:11 PM, Joe Perches wrote:
> > ...and clarifying the code for a
> > human reader is much more important than making a
> > file not have any checkpatch warnings.
> 
> I agree. I respect the developers' own coding style and believe that 
> some things (>80 characters long lines, name conventions, etc) should be 
> fixed by themselves (if they want to do that). I selected several TODOs 
> with requests for code cleanups and chose a fix in attempt to accomplish 
> my task with minimal inconvenience for the maintainers. I failed in my 
> first attempts breaking some basic rules, sorry about that.

No, not at all.  You did fine for a basic checkpatch cleanup.
I just wanted to tell you to think beyond checkpatch.

cheers, Joe

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Greg KH]

On Sat, Jan 28, 2017 at 10:34:36AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I can't take a patch with no changelog text :(

[PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

[Martin Karamihov]

Signed-off-by: Martin Karamihov <martinowar@gmail.com>
---
 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
 		power_level_offset[11] = data;
 	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
 		power_level_offset[12] = data;
-	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
+	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
 		power_level_offset[13] = data;
-	}
 }
 
 static void rtl_addr_delay(struct adapter *adapt,
-- 
2.11.0