From: Matt Fleming <matt@codeblueprint.co.uk>
To: David Howells <dhowells@redhat.com>
Cc: ard.biesheuvel@linaro.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7] efi: Get the secure boot status [ver #7]
Date: Thu, 2 Feb 2017 21:34:29 +0000 [thread overview]
Message-ID: <20170202213429.GP31613@codeblueprint.co.uk> (raw)
In-Reply-To: <148587562967.4026.18171897997650345605.stgit@warthog.procyon.org.uk>
On Tue, 31 Jan, at 03:13:49PM, David Howells wrote:
> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> index f99978db6b6f..57c2c9c71e53 100644
> --- a/arch/x86/boot/compressed/eboot.c
> +++ b/arch/x86/boot/compressed/eboot.c
> @@ -988,6 +988,12 @@ struct boot_params *efi_main(struct efi_config *c,
> else
> setup_boot_services32(efi_early);
>
> + /* If the boot loader gave us a value for secure_boot then we use that,
> + * otherwise we ask the BIOS.
> + */
> + if (boot_params->secure_boot == efi_secureboot_mode_unset)
> + boot_params->secure_boot = efi_get_secureboot(sys_table);
> +
> setup_graphics(boot_params);
>
> setup_efi_pci(boot_params);
It's not a big deal, but this multi-line comment format isn't correct.
Either Ard or I will fix it up when applying this patch. Same goes for
the comment in patch 5.
Otherwise this patch looks fine.
next prev parent reply other threads:[~2017-02-02 21:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 15:13 [PATCH 0/7] efi: Pass secure boot mode to kernel [ver #7] David Howells
2017-01-31 15:13 ` [PATCH 1/7] x86/efi: Allow invocation of arbitrary runtime services " David Howells
2017-01-31 15:13 ` [PATCH 2/7] arm/efi: " David Howells
2017-01-31 15:13 ` [PATCH 3/7] efi: Add SHIM and image security database GUID definitions " David Howells
2017-01-31 15:13 ` [PATCH 4/7] efi: Get the secure boot status " David Howells
2017-01-31 17:37 ` kbuild test robot
2017-01-31 18:04 ` kbuild test robot
2017-02-02 21:34 ` Matt Fleming [this message]
2017-01-31 15:13 ` [PATCH 5/7] efi: Disable secure boot if shim is in insecure mode " David Howells
2017-01-31 15:14 ` [PATCH 6/7] efi: Handle secure boot from UEFI-2.6 " David Howells
2017-01-31 18:19 ` Ard Biesheuvel
2017-01-31 18:59 ` David Howells
2017-02-01 10:15 ` Ard Biesheuvel
2017-02-01 12:33 ` David Howells
2017-02-01 14:44 ` Ard Biesheuvel
2017-02-01 15:00 ` David Howells
2017-02-01 15:02 ` Ard Biesheuvel
2017-02-02 21:36 ` Matt Fleming
2017-02-02 21:45 ` Ard Biesheuvel
2017-02-01 10:02 ` David Howells
2017-01-31 15:14 ` [PATCH 7/7] efi: Print the secure boot status in x86 setup_arch() " David Howells
2017-02-03 16:07 ` Ard Biesheuvel
2017-02-03 16:21 ` David Howells
2017-02-03 16:23 ` Ard Biesheuvel
2017-02-03 16:27 ` David Howells
2017-02-03 16:29 ` David Howells
2017-02-03 16:29 ` Ard Biesheuvel
2017-02-03 17:00 ` Ard Biesheuvel
2017-02-03 17:19 ` David Howells
2017-01-31 16:45 ` [PATCH 0/7] efi: Pass secure boot mode to kernel " Ard Biesheuvel
2017-01-31 17:04 ` David Howells
2017-01-31 18:20 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202213429.GP31613@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).