linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf, tools: Fix display of data source snoop indication
@ 2017-04-19 19:53 Andi Kleen
  2017-04-19 21:53 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 5+ messages in thread
From: Andi Kleen @ 2017-04-19 19:53 UTC (permalink / raw)
  To: acme; +Cc: jolsa, linux-kernel, Andi Kleen, eranian

From: Andi Kleen <ak@linux.intel.com>

perf mem report doesn't display the data source snoop indication correctly.

In the kernel API the definition is

but the table used by the perf tools exchanged Hit and Miss

        "None",
        "Miss",
        "Hit",

Fix the table in perf.

Cc: eranian@google.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/util/mem-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 1d4ab53c60ca..865ba3c39284 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
 static const char * const snoop_access[] = {
 	"N/A",
 	"None",
-	"Miss",
 	"Hit",
+	"Miss",
 	"HitM",
 };
 
-- 
2.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] perf, tools: Fix display of data source snoop indication
  2017-04-19 19:53 [PATCH] perf, tools: Fix display of data source snoop indication Andi Kleen
@ 2017-04-19 21:53 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-04-19 21:53 UTC (permalink / raw)
  To: Andi Kleen; +Cc: jolsa, linux-kernel, Andi Kleen, eranian

Em Wed, Apr 19, 2017 at 12:53:37PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> perf mem report doesn't display the data source snoop indication correctly.
> 
> In the kernel API the definition is

I fixed this already, prepending the lines starting with # with two
spaces, so that it doesn't vanishes one 3rd time 8-)

- Arnaldo
 
> but the table used by the perf tools exchanged Hit and Miss
> 
>         "None",
>         "Miss",
>         "Hit",
> 
> Fix the table in perf.
> 
> Cc: eranian@google.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/util/mem-events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 1d4ab53c60ca..865ba3c39284 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
>  static const char * const snoop_access[] = {
>  	"N/A",
>  	"None",
> -	"Miss",
>  	"Hit",
> +	"Miss",
>  	"HitM",
>  };
>  
> -- 
> 2.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] perf, tools: Fix display of data source snoop indication
  2017-04-19 18:46 ` Arnaldo Carvalho de Melo
@ 2017-04-19 18:50   ` Andi Kleen
  0 siblings, 0 replies; 5+ messages in thread
From: Andi Kleen @ 2017-04-19 18:50 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: Andi Kleen, jolsa, linux-kernel, eranian

On Wed, Apr 19, 2017 at 03:46:13PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > perf mem report doesn't display the data source snoop indication correctly.
> > 
> > In the kernel API the definition is
> 
> missing something?

#define PERF_MEM_SNOOP_NONE     0x02 /* no snoop */
#define PERF_MEM_SNOOP_HIT      0x04 /* snoop hit */
#define PERF_MEM_SNOOP_MISS     0x08 /* snoop miss */

>  
> > but the table used by the perf tools exchanged Hit and Miss
> > 
> >         "None",
> >         "Miss",
> >         "Hit",
> > 
> > Fix the table in perf.
> > 
> > Cc: eranian@google.com
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> > ---
> >  tools/perf/util/mem-events.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> > index 1d4ab53c60ca..865ba3c39284 100644
> > --- a/tools/perf/util/mem-events.c
> > +++ b/tools/perf/util/mem-events.c
> > @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
> >  static const char * const snoop_access[] = {
> >  	"N/A",
> >  	"None",
> > -	"Miss",
> >  	"Hit",
> > +	"Miss",
> >  	"HitM",
> >  };
> >  
> > -- 
> > 2.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] perf, tools: Fix display of data source snoop indication
  2017-04-19 17:49 Andi Kleen
@ 2017-04-19 18:46 ` Arnaldo Carvalho de Melo
  2017-04-19 18:50   ` Andi Kleen
  0 siblings, 1 reply; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-04-19 18:46 UTC (permalink / raw)
  To: Andi Kleen; +Cc: jolsa, linux-kernel, Andi Kleen, eranian

Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> perf mem report doesn't display the data source snoop indication correctly.
> 
> In the kernel API the definition is

missing something?
 
> but the table used by the perf tools exchanged Hit and Miss
> 
>         "None",
>         "Miss",
>         "Hit",
> 
> Fix the table in perf.
> 
> Cc: eranian@google.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/util/mem-events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 1d4ab53c60ca..865ba3c39284 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
>  static const char * const snoop_access[] = {
>  	"N/A",
>  	"None",
> -	"Miss",
>  	"Hit",
> +	"Miss",
>  	"HitM",
>  };
>  
> -- 
> 2.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] perf, tools: Fix display of data source snoop indication
@ 2017-04-19 17:49 Andi Kleen
  2017-04-19 18:46 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 5+ messages in thread
From: Andi Kleen @ 2017-04-19 17:49 UTC (permalink / raw)
  To: acme; +Cc: jolsa, linux-kernel, Andi Kleen, eranian

From: Andi Kleen <ak@linux.intel.com>

perf mem report doesn't display the data source snoop indication correctly.

In the kernel API the definition is

but the table used by the perf tools exchanged Hit and Miss

        "None",
        "Miss",
        "Hit",

Fix the table in perf.

Cc: eranian@google.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/util/mem-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 1d4ab53c60ca..865ba3c39284 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
 static const char * const snoop_access[] = {
 	"N/A",
 	"None",
-	"Miss",
 	"Hit",
+	"Miss",
 	"HitM",
 };
 
-- 
2.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-04-19 21:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 19:53 [PATCH] perf, tools: Fix display of data source snoop indication Andi Kleen
2017-04-19 21:53 ` Arnaldo Carvalho de Melo
  -- strict thread matches above, loose matches on Subject: below --
2017-04-19 17:49 Andi Kleen
2017-04-19 18:46 ` Arnaldo Carvalho de Melo
2017-04-19 18:50   ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).