From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@intel.com
Cc: mingo@redhat.com, eranian@google.com,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
acme@redhat.com, jolsa@redhat.com, torvalds@linux-foundation.org,
tglx@linutronix.de, vincent.weaver@maine.edu, ak@linux.intel.com
Subject: Re: [PATCH 2/2] perf/x86/intel, watchdog: Switch NMI watchdog to ref cycles on x86
Date: Mon, 22 May 2017 14:03:21 +0200 [thread overview]
Message-ID: <20170522120321.e3b7my5lsjue6jpb@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1495213582-3635-2-git-send-email-kan.liang@intel.com>
On Fri, May 19, 2017 at 10:06:22AM -0700, kan.liang@intel.com wrote:
> This patch was once merged, but reverted later.
> Because ref-cycles can not be used anymore when watchdog is enabled.
> The commit is 44530d588e142a96cf0cd345a7cb8911c4f88720
>
> The patch 1/2 has extended the ref-cycles to GP counter. The concern
> should be gone.
So its not a problem if every Atom prior to Goldmont, and all Core/Core2
products regress?
P6 and P4 you've entirely broken, as they don't have REF_CPU_CYCLES at all.
So no, I don't think this is right even now.
next prev parent reply other threads:[~2017-05-22 12:03 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 17:06 [PATCH 1/2] perf/x86/intel: enable CPU ref_cycles for GP counter kan.liang
2017-05-19 17:06 ` [PATCH 2/2] perf/x86/intel, watchdog: Switch NMI watchdog to ref cycles on x86 kan.liang
2017-05-22 12:03 ` Peter Zijlstra [this message]
2017-05-22 12:04 ` Peter Zijlstra
2017-05-22 16:58 ` Liang, Kan
2017-05-22 19:24 ` Peter Zijlstra
2017-05-22 18:20 ` Stephane Eranian
2017-05-22 20:01 ` Andi Kleen
2017-05-22 8:30 ` [PATCH 1/2] perf/x86/intel: enable CPU ref_cycles for GP counter Peter Zijlstra
2017-05-22 18:15 ` Stephane Eranian
2017-05-22 9:19 ` Peter Zijlstra
2017-05-22 12:22 ` Peter Zijlstra
2017-05-22 16:59 ` Liang, Kan
2017-05-22 16:55 ` Liang, Kan
2017-05-22 19:23 ` Peter Zijlstra
2017-05-22 19:28 ` Stephane Eranian
2017-05-22 21:51 ` Liang, Kan
2017-05-23 6:39 ` Peter Zijlstra
2017-05-23 6:42 ` Stephane Eranian
2017-05-24 15:45 ` Andi Kleen
2017-05-24 16:01 ` Vince Weaver
2017-05-24 16:55 ` Andi Kleen
2017-05-28 20:31 ` Stephane Eranian
2017-05-30 9:25 ` Peter Zijlstra
2017-05-30 13:51 ` Andi Kleen
2017-05-30 16:28 ` Peter Zijlstra
2017-05-30 16:41 ` Stephane Eranian
2017-05-30 17:22 ` Andi Kleen
2017-05-30 17:40 ` Peter Zijlstra
2017-05-30 17:51 ` Andi Kleen
2017-05-30 18:59 ` Peter Zijlstra
2017-05-30 19:40 ` Andi Kleen
2017-05-30 16:39 ` Stephane Eranian
2017-05-30 16:55 ` Thomas Gleixner
2017-05-30 17:25 ` Peter Zijlstra
2017-05-31 20:57 ` Vince Weaver
2017-05-28 2:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522120321.e3b7my5lsjue6jpb@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).