* [PATCH] iio: hi8435: remote ampersands from hi8435_info definition
@ 2017-05-23 8:07 Nikita Yushchenko
2017-05-24 19:28 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Nikita Yushchenko @ 2017-05-23 8:07 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Sanchayan Maity, Gregor Boirie,
Matt Ranostay
Cc: linux-iio, linux-kernel, Chris Healy, Jeff White,
Vladimir Barinov, Nikita Yushchenko
C syntax allows apersands when initializing structures fields with
function pointers, but in Linux sources ampersands are normally not used
in thix context.
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
---
drivers/iio/adc/hi8435.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
index 28fc699f00f6..ef5c286c8e67 100644
--- a/drivers/iio/adc/hi8435.c
+++ b/drivers/iio/adc/hi8435.c
@@ -414,11 +414,11 @@ static const struct iio_chan_spec hi8435_channels[] = {
static const struct iio_info hi8435_info = {
.driver_module = THIS_MODULE,
.read_raw = hi8435_read_raw,
- .read_event_config = &hi8435_read_event_config,
+ .read_event_config = hi8435_read_event_config,
.write_event_config = hi8435_write_event_config,
- .read_event_value = &hi8435_read_event_value,
- .write_event_value = &hi8435_write_event_value,
- .debugfs_reg_access = &hi8435_debugfs_reg_access,
+ .read_event_value = hi8435_read_event_value,
+ .write_event_value = hi8435_write_event_value,
+ .debugfs_reg_access = hi8435_debugfs_reg_access,
};
static void hi8435_iio_push_event(struct iio_dev *idev, unsigned int val)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: hi8435: remote ampersands from hi8435_info definition
2017-05-23 8:07 [PATCH] iio: hi8435: remote ampersands from hi8435_info definition Nikita Yushchenko
@ 2017-05-24 19:28 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-05-24 19:28 UTC (permalink / raw)
To: Nikita Yushchenko
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Sanchayan Maity, Gregor Boirie, Matt Ranostay, linux-iio,
linux-kernel, Chris Healy, Jeff White, Vladimir Barinov
On Tue, 23 May 2017 11:07:46 +0300
Nikita Yushchenko <nikita.yoush@cogentembedded.com> wrote:
> C syntax allows apersands when initializing structures fields with
> function pointers, but in Linux sources ampersands are normally not used
> in thix context.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/iio/adc/hi8435.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
> index 28fc699f00f6..ef5c286c8e67 100644
> --- a/drivers/iio/adc/hi8435.c
> +++ b/drivers/iio/adc/hi8435.c
> @@ -414,11 +414,11 @@ static const struct iio_chan_spec hi8435_channels[] = {
> static const struct iio_info hi8435_info = {
> .driver_module = THIS_MODULE,
> .read_raw = hi8435_read_raw,
> - .read_event_config = &hi8435_read_event_config,
> + .read_event_config = hi8435_read_event_config,
> .write_event_config = hi8435_write_event_config,
> - .read_event_value = &hi8435_read_event_value,
> - .write_event_value = &hi8435_write_event_value,
> - .debugfs_reg_access = &hi8435_debugfs_reg_access,
> + .read_event_value = hi8435_read_event_value,
> + .write_event_value = hi8435_write_event_value,
> + .debugfs_reg_access = hi8435_debugfs_reg_access,
> };
>
> static void hi8435_iio_push_event(struct iio_dev *idev, unsigned int val)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-24 19:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-23 8:07 [PATCH] iio: hi8435: remote ampersands from hi8435_info definition Nikita Yushchenko
2017-05-24 19:28 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).